kris/boringssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
3d59e04bce
boringssl/crypto
History
Adam Langley 3d59e04bce Fix test used for not-in-place CBC mode. 
With NO_ASM defined, the recent AEAD changes broke the tests. The
problem is that the generic CBC mode code tests whether in != out and
omits to save the IV, assuming that it'll be able to read the old
ciphertext block.

However, consider the case where out = in - 16:

    1       2      3       4
|-------|-------|------|-------|
    ^       ^
    |       |
   out     in

First time around, 1 = decrypt(2) ^ iv and everything is fine, because
the IV was preconfigured. However, the next iteration of the loop sets
2 = decrypt(3) and tries to XOR it with the contents of the previous
ciphertext block… from 2.

Change-Id: Ibabff430704fad246de132b4d6d514f6a0362734
2015-05-21 13:27:37 -07:00
..
aes Don't use .arch in aarch64 asm with Clang. 2015-05-05 00:28:03 +00:00
asn1 Convert reference counts in crypto/ 2015-05-20 19:15:26 +00:00
base64 Add malloc test support to unit tests. 2015-05-21 17:59:48 +00:00
bio Fix some malloc test crashs. 2015-05-21 18:00:10 +00:00
bn Add malloc test support to unit tests. 2015-05-21 17:59:48 +00:00
buf Precompute sorted array for error strings. 2015-02-09 17:35:31 -08:00
bytestring Fix some malloc test crashs. 2015-05-21 18:00:10 +00:00
chacha Switch nonce type in chacha_vec.c to uint32_t. 2015-02-13 13:16:59 -08:00
cipher Fix some malloc test crashs. 2015-05-21 18:00:10 +00:00
cmac Add support for CMAC (RFC 4493). 2015-05-07 21:13:41 +00:00
conf Add NCONF_load_bio. 2015-04-06 16:58:45 -07:00
des Implement |DES_ede2_cbc_encrypt|. 2015-05-20 18:36:01 +00:00
dh Add malloc test support to unit tests. 2015-05-21 17:59:48 +00:00
digest Add malloc test support to unit tests. 2015-05-21 17:59:48 +00:00
dsa Fix some malloc test crashs. 2015-05-21 18:00:10 +00:00
ec Fix some malloc test crashs. 2015-05-21 18:00:10 +00:00
ecdh Add in missing curly braces part 2. 2015-02-11 23:14:04 +00:00
ecdsa Add malloc test support to unit tests. 2015-05-21 17:59:48 +00:00
engine Precompute sorted array for error strings. 2015-02-09 17:35:31 -08:00
err Fix some malloc test crashs. 2015-05-21 18:00:10 +00:00
evp Add malloc test support to unit tests. 2015-05-21 17:59:48 +00:00
hkdf Add malloc test support to unit tests. 2015-05-21 17:59:48 +00:00
hmac Add malloc test support to unit tests. 2015-05-21 17:59:48 +00:00
lhash Fix some malloc test crashs. 2015-05-21 18:00:10 +00:00
md4 Eliminate unnecessary includes from low-level crypto modules. 2015-04-13 20:49:18 +00:00
md5 Remove explicit .hiddens from x86_64 perlasm files. 2015-02-25 21:26:16 +00:00
modes Fix test used for not-in-place CBC mode. 2015-05-21 13:27:37 -07:00
obj Remove unnecessary NULL checks, part 4. 2015-05-04 23:13:12 +00:00
pem Eliminate unnecessary includes from low-level crypto modules. 2015-04-13 20:49:18 +00:00
perlasm Add assembly support for 32-bit iOS. 2015-05-04 22:44:24 +00:00
pkcs8 Add malloc test support to unit tests. 2015-05-21 17:59:48 +00:00
poly1305 Fix ARM Clang build. 2015-05-05 00:24:59 +00:00
rand Don't use uninitialized memory in RAND_bytes. 2015-05-15 20:31:27 +00:00
rc4 Mind the end of the buffer in aligned case of generic RC4 implementation. 2015-05-12 19:31:09 +00:00
rsa Add malloc test support to unit tests. 2015-05-21 17:59:48 +00:00
sha Add assembly support for 32-bit iOS. 2015-05-04 22:44:24 +00:00
stack Remove unnecessary NULL checks, part 4. 2015-05-04 23:13:12 +00:00
test Add malloc test support to unit tests. 2015-05-21 17:59:48 +00:00
x509 Add malloc test support to unit tests. 2015-05-21 17:59:48 +00:00
x509v3 Add malloc test support to unit tests. 2015-05-21 17:59:48 +00:00
arm_arch.h aarch64 support. 2015-01-14 23:38:11 +00:00
CMakeLists.txt Add malloc test support to unit tests. 2015-05-21 17:59:48 +00:00
constant_time_test.c Update constant-time operations. 2014-11-10 13:48:30 -08:00
cpu-arm-asm.S Don't probe for NEON with SIGILL on aarch64. 2015-02-03 19:56:25 +00:00
cpu-arm.c Support Trusty, an embedded platform. 2015-05-08 18:34:55 +00:00
cpu-intel.c Eliminate unnecessary includes from low-level crypto modules. 2015-04-13 20:49:18 +00:00
cpu-x86_64-asm.pl Remove explicit .hiddens from x86_64 perlasm files. 2015-02-25 21:26:16 +00:00
cpu-x86-asm.pl Never set RC4_CHAR. 2015-02-20 23:59:59 +00:00
crypto.c Fix |SSLeay|. 2015-05-20 17:44:44 +00:00
directory_posix.c Eliminate unnecessary includes from low-level crypto modules. 2015-04-13 20:49:18 +00:00
directory_win.c Eliminate unnecessary includes from low-level crypto modules. 2015-04-13 20:49:18 +00:00
directory.h
ex_data.c Remove unnecessary NULL checks, part 3. 2015-05-04 23:12:04 +00:00
header_removed.h
internal.h Try to fix MSVC and __STDC_VERSION__ again. 2015-05-20 13:42:12 -07:00
mem.c Lowercase some Windows headers. 2015-03-31 22:21:42 +00:00
refcount_c11.c Cast refcounts to _Atomic before use. 2015-05-20 13:39:22 -07:00
refcount_lock.c Add infrastructure for reference counts. 2015-05-20 19:14:59 +00:00
refcount_test.c Specify argc and argv arguments to refcount_test:main. 2015-05-20 13:49:41 -07:00
thread_none.c Support Trusty, an embedded platform. 2015-05-08 18:34:55 +00:00
thread_pthread.c Support Trusty, an embedded platform. 2015-05-08 18:34:55 +00:00
thread_test.c Support Trusty, an embedded platform. 2015-05-08 18:34:55 +00:00
thread_win.c Support Trusty, an embedded platform. 2015-05-08 18:34:55 +00:00
thread.c Remove leftovers of the old-style locks. 2015-05-20 19:18:44 +00:00
time_support.c Eliminate unnecessary includes from low-level crypto modules. 2015-04-13 20:49:18 +00:00