5267ef7b4a
Update-Note: This tweaks the SSL_shutdown behavior. OpenSSL's original SSL_shutdown behavior was an incoherent mix of discarding the record and rejecting it (it would return SSL_ERROR_SYSCALL but retrying the operation would discard it). SSLeay appears to have intended to discard it, so we previously "fixed" it actually discard. However, this behavior is somewhat bizarre and means we skip over unbounded data, which we typically try to avoid. If you are trying to cleanly shutdown the TLS portion of your protocol, surely it is at a point where additional data is a syntax error. I suspect I originally did not realize that, because the discarded record did not properly continue the loop, SSL_shutdown would appear as if it rejected the data, and so it's unlikely anyone was relying on that behavior. Discussion in https://github.com/openssl/openssl/pull/6340 suggests (some of) upstream also prefers rejecting. Change-Id: Icde419049306ed17eb06ce1a7e1ff587901166f3 Reviewed-on: https://boringssl-review.googlesource.com/28864 Commit-Queue: David Benjamin <davidben@google.com> CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Reviewed-by: Steven Valdez <svaldez@google.com> |
||
|---|---|---|
| .. | ||
| runner | ||
| async_bio.cc | ||
| async_bio.h | ||
| bssl_shim.cc | ||
| CMakeLists.txt | ||
| fuzzer_tags.h | ||
| fuzzer.h | ||
| packeted_bio.cc | ||
| packeted_bio.h | ||
| PORTING.md | ||
| README.md | ||
| test_config.cc | ||
| test_config.h | ||
BoringSSL SSL Tests
This directory contains BoringSSL's protocol-level test suite.
Testing a TLS implementation can be difficult. We need to produce invalid but sufficiently correct handshakes to get our implementation close to its edge cases. TLS's cryptographic steps mean we cannot use a transcript and effectively need a TLS implementation on the other end. But we do not wish to litter BoringSSL with options for bugs to test against.
Instead, we use a fork of the Go crypto/tls package, heavily patched with
configurable bugs. This code, along with a test suite and harness written in Go,
lives in the runner directory. The harness runs BoringSSL via a C/C++ shim
binary which lives in this directory. All communication with the shim binary
occurs with command-line flags, sockets, and standard I/O.
This strategy also ensures we always test against a second implementation. All features should be implemented twice, once in C for BoringSSL and once in Go for testing. If possible, the Go code should be suitable for potentially upstreaming. However, sometimes test code has different needs. For example, our test DTLS code enforces strict ordering on sequence numbers and has controlled packet drop simulation.
To run the tests manually, run go test from the runner directory. It takes
command-line flags found at the top of runner/runner.go. The -help option
also works after using go test -c to make a runner.test binary first.
If adding a new test, these files may be a good starting point:
runner/runner.go: the test harness and all the individual tests.runner/common.go: contains theConfigandProtocolBugsstruct which control the Go TLS implementation's behavior.test_config.h,test_config.cc: the command-line flags which control the shim's behavior.bssl_shim.cc: the shim binary itself.
For porting the test suite to a different implementation see PORTING.md.