fa65113400
The private key callback may not push one of its own (it's possible to register a custom error library and whatnot, but this is tedious). If the callback does not push any, we report SSL_ERROR_SYSCALL. This is not completely wrong, as "syscall" really means "I don't know, something you gave me, probably the BIO, failed so I assume you know what happened", but most callers just check errno. And indeed cert_cb pushes its own error, so this probably should as well. Update-Note: Custom private key callbacks which push an error code on failure will report both that error followed by SSL_R_PRIVATE_KEY_OPERATION_FAILED. Callbacks which did not push any error will switch from SSL_ERROR_SYSCALL to SSL_ERROR_SSL with SSL_R_PRIVATE_KEY_OPERATION_FAILED. Change-Id: I7e90cd327fe0cbcff395470381a3591364a82c74 Reviewed-on: https://boringssl-review.googlesource.com/25544 Reviewed-by: Adam Langley <agl@google.com> |
||
---|---|---|
.. | ||
test | ||
bio_ssl.cc | ||
CMakeLists.txt | ||
custom_extensions.cc | ||
d1_both.cc | ||
d1_lib.cc | ||
d1_pkt.cc | ||
d1_srtp.cc | ||
dtls_method.cc | ||
dtls_record.cc | ||
handoff.cc | ||
handshake_client.cc | ||
handshake_server.cc | ||
handshake.cc | ||
internal.h | ||
s3_both.cc | ||
s3_lib.cc | ||
s3_pkt.cc | ||
span_test.cc | ||
ssl_aead_ctx.cc | ||
ssl_asn1.cc | ||
ssl_buffer.cc | ||
ssl_cert.cc | ||
ssl_cipher.cc | ||
ssl_file.cc | ||
ssl_key_share.cc | ||
ssl_lib.cc | ||
ssl_privkey.cc | ||
ssl_session.cc | ||
ssl_stat.cc | ||
ssl_test.cc | ||
ssl_transcript.cc | ||
ssl_versions.cc | ||
ssl_x509.cc | ||
t1_enc.cc | ||
t1_lib.cc | ||
tls13_both.cc | ||
tls13_client.cc | ||
tls13_enc.cc | ||
tls13_server.cc | ||
tls_method.cc | ||
tls_record.cc |