492c9aa90c
Historically, OpenSSL filled in a fake session ID for ticket-only client sessions. Conscrypt relies on this to implement some weird Java API where every session has an ID and may be queried out of the client session cache and, e.g., revoked that way. (Note that a correct client session cache is not keyed by session ID and indeed this allows one server to knock out another server's sessions by matching session IDs. But existing APIs are existing APIs.) For consistency between TLS 1.2 and TLS 1.3, as well as matching OpenSSL's TLS 1.3 implementation, do the same in TLS 1.3. Note this smooths over our cross-version resumption tests by allowing for something odd: it is now syntactically possible to resume a TLS 1.3 session at TLS 1.2. It doesn't matter either way, but now a different codepath rejects certain cases. Change-Id: I9caf4f0c3b2e2e24ae25752826d47bce77e65616 Reviewed-on: https://boringssl-review.googlesource.com/31525 Reviewed-by: Steven Valdez <svaldez@google.com> Commit-Queue: David Benjamin <davidben@google.com> CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> |
||
|---|---|---|
| .. | ||
| runner | ||
| async_bio.cc | ||
| async_bio.h | ||
| bssl_shim.cc | ||
| CMakeLists.txt | ||
| fuzzer_tags.h | ||
| fuzzer.h | ||
| handshake_util.cc | ||
| handshake_util.h | ||
| handshaker.cc | ||
| packeted_bio.cc | ||
| packeted_bio.h | ||
| PORTING.md | ||
| README.md | ||
| settings_writer.cc | ||
| settings_writer.h | ||
| test_config.cc | ||
| test_config.h | ||
| test_state.cc | ||
| test_state.h | ||
BoringSSL SSL Tests
This directory contains BoringSSL's protocol-level test suite.
Testing a TLS implementation can be difficult. We need to produce invalid but sufficiently correct handshakes to get our implementation close to its edge cases. TLS's cryptographic steps mean we cannot use a transcript and effectively need a TLS implementation on the other end. But we do not wish to litter BoringSSL with options for bugs to test against.
Instead, we use a fork of the Go crypto/tls package, heavily patched with
configurable bugs. This code, along with a test suite and harness written in Go,
lives in the runner directory. The harness runs BoringSSL via a C/C++ shim
binary which lives in this directory. All communication with the shim binary
occurs with command-line flags, sockets, and standard I/O.
This strategy also ensures we always test against a second implementation. All features should be implemented twice, once in C for BoringSSL and once in Go for testing. If possible, the Go code should be suitable for potentially upstreaming. However, sometimes test code has different needs. For example, our test DTLS code enforces strict ordering on sequence numbers and has controlled packet drop simulation.
To run the tests manually, run go test from the runner directory. It takes
command-line flags found at the top of runner/runner.go. The -help option
also works after using go test -c to make a runner.test binary first.
If adding a new test, these files may be a good starting point:
runner/runner.go: the test harness and all the individual tests.runner/common.go: contains theConfigandProtocolBugsstruct which control the Go TLS implementation's behavior.test_config.h,test_config.cc: the command-line flags which control the shim's behavior.bssl_shim.cc: the shim binary itself.
For porting the test suite to a different implementation see PORTING.md.