kris/boringssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
2,478 Commits 12 Branches 0 Tags 38 MiB
C 43.1%
C++ 23.5%
Go 13.6%
Raku 10.8%
Perl 4%
Other 4.9%
4c34026d12
Go to file
David Benjamin 4c34026d12 Fix poly1305-x86.pl. 
Imported from patch attached to
https://rt.openssl.org/Ticket/Display.html?id=4439.

But with the extra vs $extra typo fixed.

The root problem appears to be that lazy_reduction tries to use paddd instead
of paddq when they believe the sum will not overflow a u32. In the final call
to lazy_reduction, this is not true. svaldez and I attempted to work through
the bounds, but the bounds derived from the cited paper imply paddd is always
fine. Empirically in a debugger, the bounds are exceeded in the test case.

I requested more comments from upstream on the bug. When upstream lands their
final fix (hopefully with comments), I will update this code. In the meantime,
let's stop carrying known-broken stuff.

(vlazy_reduction is probably something similar, but since we don't enable that
code, we haven't bothered analyzing it.)

Also add the smaller of the two test cases that catch the bug. (The other uses
an update pattern which isn't quite what poly1305_test does.)

Change-Id: I446ed47c21f10b41a0745de96ab119a3f6fd7801
Reviewed-on: https://boringssl-review.googlesource.com/7544
Reviewed-by: Steven Valdez <svaldez@google.com>
Reviewed-by: David Benjamin <davidben@google.com>
2016-03-24 15:04:23 +00:00
.github Add a PULL_REQUEST_TEMPLATE. 2016-03-08 15:23:52 +00:00
crypto Fix poly1305-x86.pl. 2016-03-24 15:04:23 +00:00
decrepit Add |DH_generate_parameters| to decrepit. 2016-03-10 17:44:59 +00:00
fuzz Update FUZZING documentation about max_len. 2016-03-22 18:46:35 +00:00
include/openssl Add CBS_ASN1_UTF8STRING define. 2016-03-23 19:29:49 +00:00
ssl ssl->ctx cannot be NULL. 2016-03-22 15:24:10 +00:00
tool Move function declarations to internal header. 2016-03-20 16:56:32 +00:00
util Fixing assembly coverage 2016-03-23 18:23:42 +00:00
.clang-format Inital import. 2014-06-20 13:17:32 -07:00
.gitignore Fix documentation generation on Windows. 2015-08-19 00:45:42 +00:00
BUILDING.md Enable upstream's ChaCha20 assembly for x86 and ARM (32- and 64-bit). 2016-02-23 17:19:45 +00:00
CMakeLists.txt Build with -Wmissing-prototypes -Wmissing-declarations. 2016-03-20 17:05:03 +00:00
codereview.settings Add a codereview.settings file. 2014-11-18 22:21:33 +00:00
CONTRIBUTING.md Add a CONTRIBUTING.md file. 2016-02-10 21:38:19 +00:00
FUZZING.md Update FUZZING documentation about max_len. 2016-03-22 18:46:35 +00:00
LICENSE Add some bug references to the LICENSE file. 2016-02-22 20:16:48 +00:00
PORTING.md Document the d2i object reuse changes in PORTING.md. 2016-02-02 16:21:20 +00:00
README.md Add a CONTRIBUTING.md file. 2016-02-10 21:38:19 +00:00
STYLE.md Update link to Google style guide. 2015-11-03 02:02:12 +00:00

README.md

BoringSSL

BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.

Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.

Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.

BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.

Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.

There are other files in this directory which might be helpful: