boringssl

History

David Benjamin 5c9d411e14 Fix some compact unwind errors. The Mac ld gets unhappy about "weird" unwind directives: In chacha20_poly1305_x86_64.pl, $keyp is being pushed on the stack (according to the comment) because it gets clobbered in the computation somewhere. $keyp is %r9 which is not callee-saved (it's an argument register), so we don't need to tag it with .cfi_offset. In x25519-asm-x86_64.S, x25519_x86_64_mul saves %rdi on the stack. However it too is not callee-saved (it's an argument register) and should not have a .cfi_offset. %rdi also does not appear to be written to anywhere in the function, so there's no need to save it at all. (This does not resolve the "r15 is saved too far from return address" errors. Just the non-standard register ones.) BUG=176 Change-Id: I53f3f7db3d1745384fb47cb52cd6536aabb5065e Reviewed-on: https://boringssl-review.googlesource.com/13560 Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Adam Langley <agl@google.com>	2017-02-02 22:05:06 +00:00
..
chacha20_poly1305_x86_64.pl	Fix some compact unwind errors.	2017-02-02 22:05:06 +00:00

David Benjamin 5c9d411e14 Fix some compact unwind errors.

The Mac ld gets unhappy about "weird" unwind directives:

In chacha20_poly1305_x86_64.pl, $keyp is being pushed on the stack
(according to the comment) because it gets clobbered in the computation
somewhere. $keyp is %r9 which is not callee-saved (it's an argument
register), so we don't need to tag it with .cfi_offset.

In x25519-asm-x86_64.S, x25519_x86_64_mul saves %rdi on the stack.
However it too is not callee-saved (it's an argument register) and
should not have a .cfi_offset. %rdi also does not appear to be written
to anywhere in the function, so there's no need to save it at all.

(This does not resolve the "r15 is saved too far from return address"
errors. Just the non-standard register ones.)

BUG=176

Change-Id: I53f3f7db3d1745384fb47cb52cd6536aabb5065e
Reviewed-on: https://boringssl-review.googlesource.com/13560
Commit-Queue: David Benjamin <davidben@google.com>
Reviewed-by: Adam Langley <agl@google.com>

2017-02-02 22:05:06 +00:00

chacha20_poly1305_x86_64.pl

Fix some compact unwind errors.

2017-02-02 22:05:06 +00:00