kris/boringssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
5d1ec73b0f
boringssl/crypto/asn1
History
David Benjamin 5c20c444c4 Don't set *pval to NULL in asn1_item_ex_combine_new. 
While *pval is usually a pointer in rare circumstances it can be a long
value. One some platforms (e.g. WIN64) where
sizeof(long) < sizeof(ASN1_VALUE *) this will write past the field.

*pval is initialised correctly in the rest of ASN1_item_ex_new so setting it
to NULL is unecessary anyway.

Thanks to Julien Kauffmann for reporting this issue.

(Imported from upstream's f617b4969a9261b9d7d381670aefbe2cf766a2cb.)

Change-Id: I8cc777f7ab126dcef3a0278a82d3fc91faf4c231
Reviewed-on: https://boringssl-review.googlesource.com/4510
Reviewed-by: Adam Langley <agl@google.com>
2015-05-04 22:54:51 +00:00
..
a_bitstr.c Remove string.h from base.h. 2015-02-02 19:14:15 +00:00
a_bool.c
a_bytes.c Remove string.h from base.h. 2015-02-02 19:14:15 +00:00
a_d2i_fp.c Error codes are uint32_t, not unsigned long. 2015-03-13 19:41:42 +00:00
a_dup.c
a_enum.c Remove string.h from base.h. 2015-02-02 19:14:15 +00:00
a_gentm.c Eliminate unnecessary includes from low-level crypto modules. 2015-04-13 20:49:18 +00:00
a_i2d_fp.c
a_int.c Ensure BN_asc2bn, BN_dec2bn, and BN_hex2bn never give -0. 2015-04-23 20:53:24 +00:00
a_mbstr.c Remove string.h from base.h. 2015-02-02 19:14:15 +00:00
a_object.c Remove string.h from base.h. 2015-02-02 19:14:15 +00:00
a_octet.c
a_print.c
a_strnid.c Remove string.h from base.h. 2015-02-02 19:14:15 +00:00
a_time.c Eliminate unnecessary includes from low-level crypto modules. 2015-04-13 20:49:18 +00:00
a_type.c Fix ASN1_TYPE_cmp 2015-03-19 19:48:41 +00:00
a_utctm.c Eliminate unnecessary includes from low-level crypto modules. 2015-04-13 20:49:18 +00:00
a_utf8.c
asn1_lib.c Prune away (almost) all of asn1_mac.h 2015-04-08 20:42:57 +00:00
asn1_locl.h Move the X509_NAME typedef into x509.h. 2014-10-28 22:38:38 +00:00
asn1_par.c Fix wrong numbers being passed as string lengths 2015-03-19 11:07:45 +00:00
asn_pack.c Remove some dead code. 2014-08-19 19:00:49 +00:00
bio_asn1.c Remove string.h from base.h. 2015-02-02 19:14:15 +00:00
bio_ndef.c Fix two unchecked mallocs in crypto/asn1. 2015-03-10 02:31:29 +00:00
charmap.pl Tag a number of globals as const. 2015-01-14 21:53:00 +00:00
CMakeLists.txt Precompute sorted array for error strings. 2015-02-09 17:35:31 -08:00
f_enum.c Fix a2i_ASN1_* leak on failure. 2014-11-06 01:29:59 +00:00
f_int.c Fix a2i_ASN1_* leak on failure. 2014-11-06 01:29:59 +00:00
f_string.c Fix a2i_ASN1_* leak on failure. 2014-11-06 01:29:59 +00:00
t_bitst.c Remove string.h from base.h. 2015-02-02 19:14:15 +00:00
t_pkey.c
tasn_dec.c Enable MSVC warning C4701, use of potentially uninitialized variable. 2015-04-13 20:32:26 +00:00
tasn_enc.c Remove string.h from base.h. 2015-02-02 19:14:15 +00:00
tasn_fre.c
tasn_new.c Don't set *pval to NULL in asn1_item_ex_combine_new. 2015-05-04 22:54:51 +00:00
tasn_prn.c ASN.1 print fix. 2015-03-19 11:32:45 +00:00
tasn_typ.c Allocate string types directly. 2015-03-19 11:47:52 +00:00
tasn_utl.c Eliminate unnecessary includes from low-level crypto modules. 2015-04-13 20:49:18 +00:00
x_bignum.c Tag a number of globals as const. 2015-01-14 21:53:00 +00:00
x_long.c Remove string.h from base.h. 2015-02-02 19:14:15 +00:00