kris/boringssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
2,190 Commits 12 Branches 0 Tags 38 MiB
C 43.1%
C++ 23.5%
Go 13.6%
Raku 10.8%
Perl 4%
Other 4.9%
62882187c9
Go to file
Adam Langley 62882187c9 Update comments to better document in-place semantics. 
(Comment-only change; no functional difference.)

Some code was broken by the |d2i_ECDSA_SIG| change in 87897a8c. It was
passing in a pointer to an existing |ECDSA_SIG| as the first argument
and then simply assuming that the structure would be updated in place.
The comments on the function suggested that this was reasonable.

This change updates the comments that use similar wording to either note
that the function will never update in-place, or else to note that
depending on that is a bad idea for the future.

I've also audited all the uses of these functions that I can find and,
in addition to the one case with |d2i_ECDSA_SIG|, there are several
users of |d2i_PrivateKey| that could become a problem in the future.
I'll try to fix them before it does become an issue.

Change-Id: I769f7b2e0b5308d09ea07dd447e02fc161795071
Reviewed-on: https://boringssl-review.googlesource.com/6902
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Adam Langley <agl@google.com>
2016-01-19 17:01:37 +00:00
crypto Update comments to better document in-place semantics. 2016-01-19 17:01:37 +00:00
decrepit Fix AES XTS mode key size. 2015-11-19 18:08:33 +00:00
fuzz Update the fuzz tests for the server. 2015-12-22 16:35:07 -08:00
include/openssl Update comments to better document in-place semantics. 2016-01-19 17:01:37 +00:00
ssl Add a helper function to normalize the current version. 2016-01-15 22:17:00 +00:00
tool Make it possible to tell what curve was used on the server. 2015-12-22 23:12:25 +00:00
util Add curve25519/asm/x25519-asm-x86_64.S. 2016-01-14 22:36:58 +00:00
.clang-format Inital import. 2014-06-20 13:17:32 -07:00
.gitignore Fix documentation generation on Windows. 2015-08-19 00:45:42 +00:00
BUILDING.md Make the instructions for downloading the ARM compiler easier to copy and paste. 2015-10-30 20:47:08 +00:00
CMakeLists.txt Remove NO_ASM define that I accidently included in the previous commit. 2015-12-22 16:34:33 +00:00
codereview.settings
FUZZING.md Update and fix fuzzing instructions. 2015-11-10 23:37:36 +00:00
LICENSE Note that some files carry in Intel license. 2015-07-28 00:55:32 +00:00
PORTING.md Update PORTING.md for the new renego API. 2015-10-26 19:27:56 +00:00
README.md Add four, basic fuzz tests. 2015-11-10 19:14:01 +00:00
STYLE.md Update link to Google style guide. 2015-11-03 02:02:12 +00:00

README.md

BoringSSL

BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.

Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.

Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.

BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.

Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.

There are other files in this directory which might be helpful:

  • PORTING.md: how to port OpenSSL-using code to BoringSSL.
  • BUILDING.md: how to build BoringSSL
  • STYLE.md: rules and guidelines for coding style.
  • include/openssl: public headers with API documentation in comments. Also available online.
  • FUZZING.md: information about fuzzing BoringSSL.