boringssl/ssl
David Benjamin 63c79122e0 Remove the redundant version check in ssl_session_cmp.
This partitions the session ID space of the internal cache by version,
which is nominally something we want, but we must check the version
externally anyway for both tickets and external session cache. That
makes this measure redundant. (Servers generate session IDs and 2^256 is
huge, so there would never accidentally be a collision.)

This cuts down on the "key" in the internal session cache, which will
simplify adding something like an lh_SSL_SESSION_retrieve_key function.
(LHASH is currently lax about keys because it can freely stack-allocate
partially-initialized structs. C++ is a bit more finicky about this.)

Change-Id: I656fd9dbf023dccb163d2e8049eff8f1f9a0e21b
Reviewed-on: https://boringssl-review.googlesource.com/29585
Commit-Queue: David Benjamin <davidben@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
Reviewed-by: Adam Langley <agl@google.com>
2018-07-03 22:54:16 +00:00
..
test Remove the redundant version check in ssl_session_cmp. 2018-07-03 22:54:16 +00:00
bio_ssl.cc
CMakeLists.txt Add initial, experimental support for split handshakes. 2018-01-31 22:24:17 +00:00
custom_extensions.cc
d1_both.cc Fix build with GCC 4.9.2 and -Wtype-limits. 2018-05-08 22:21:45 +00:00
d1_lib.cc Give DTLS1_STATE a destructor. 2017-10-25 03:23:26 +00:00
d1_pkt.cc Make SSL3_BUFFER a proper C++ class. 2017-10-24 17:32:45 +00:00
d1_srtp.cc Move srtp_profiles to SSL_CONFIG. 2018-05-03 15:20:13 +00:00
dtls_method.cc Remove trailing whitespace from ssl/. 2018-02-26 22:05:13 +00:00
dtls_record.cc Use the actual record header, rather than reassembling it. 2018-04-10 19:52:33 +00:00
handoff.cc Remove SSL 3.0 implementation. 2018-06-28 16:54:58 +00:00
handshake_client.cc Add bssl::UpRef. 2018-07-03 22:47:36 +00:00
handshake_server.cc Add bssl::UpRef. 2018-07-03 22:47:36 +00:00
handshake.cc Remove SSL 3.0 implementation. 2018-06-28 16:54:58 +00:00
internal.h Namespace SSL_X509_METHOD. 2018-07-03 21:41:36 +00:00
s3_both.cc Remove SSL 3.0 implementation. 2018-06-28 16:54:58 +00:00
s3_lib.cc SSL_CONFIG: new struct for sheddable handshake configuration. 2018-05-01 20:40:16 +00:00
s3_pkt.cc Pack encrypted handshake messages together. 2018-05-29 14:28:56 +00:00
span_test.cc
ssl_aead_ctx.cc Remove SSL 3.0 implementation. 2018-06-28 16:54:58 +00:00
ssl_asn1.cc Add bssl::UpRef. 2018-07-03 22:47:36 +00:00
ssl_buffer.cc Move init_buf and rwstate into SSL3_STATE. 2017-10-24 18:55:05 +00:00
ssl_cert.cc Add bssl::UpRef. 2018-07-03 22:47:36 +00:00
ssl_cipher.cc Remove SSL 3.0 implementation. 2018-06-28 16:54:58 +00:00
ssl_file.cc Avoid modifying stack in sk_find. 2018-04-12 21:02:12 +00:00
ssl_key_share.cc Check for nullptr result of SSLKeyShare::Create(). 2018-04-10 22:55:53 +00:00
ssl_lib.cc Remove the redundant version check in ssl_session_cmp. 2018-07-03 22:54:16 +00:00
ssl_privkey.cc Add bssl::UpRef. 2018-07-03 22:47:36 +00:00
ssl_session.cc Remove the redundant version check in ssl_session_cmp. 2018-07-03 22:54:16 +00:00
ssl_stat.cc Remove trailing whitespace from ssl/. 2018-02-26 22:05:13 +00:00
ssl_test.cc Add bssl::UpRef. 2018-07-03 22:47:36 +00:00
ssl_transcript.cc Remove SSL 3.0 implementation. 2018-06-28 16:54:58 +00:00
ssl_versions.cc Remove SSL 3.0 implementation. 2018-06-28 16:54:58 +00:00
ssl_x509.cc Add bssl::UpRef. 2018-07-03 22:47:36 +00:00
t1_enc.cc Remove SSL 3.0 implementation. 2018-06-28 16:54:58 +00:00
t1_lib.cc Remove SSL 3.0 implementation. 2018-06-28 16:54:58 +00:00
tls13_both.cc Implement the client side of certificate compression. 2018-06-18 22:16:11 +00:00
tls13_client.cc Flip SSL_SESSION fields to bool. 2018-07-03 21:26:16 +00:00
tls13_enc.cc Remove draft22 and experiment2. 2018-01-31 18:07:53 +00:00
tls13_server.cc Flip SSL_SESSION fields to bool. 2018-07-03 21:26:16 +00:00
tls_method.cc Pack encrypted handshake messages together. 2018-05-29 14:28:56 +00:00
tls_record.cc Use the actual record header, rather than reassembling it. 2018-04-10 19:52:33 +00:00