boringssl/ssl/test
David Benjamin c7ce977fb9 Ignore all extensions but renegotiation_info in SSL 3.0.
SSL 3.0 used to have a nice and simple rule around extensions. They don't
exist. And then RFC 5746 came along and made this all extremely confusing.

In an SSL 3.0 server, rather than blocking ServerHello extension
emission when renegotiation_info is missing, ignore all ClientHello
extensions but renegotiation_info. This avoids a mismatch between local
state and the extensions with emit.

Notably if, for some reason, a ClientHello includes the session_ticket
extension, does NOT include renegotiation_info or the SCSV, and yet the
client or server are decrepit enough to negotiate SSL 3.0, the
connection will fail due to unexpected NewSessionTicket message.

See https://crbug.com/425979#c9 for a discussion of something similar
that came up in diagnosing https://poodle.io/'s buggy POODLE check.
This is analogous to upstream's
5a3d8eebb7667b32af0ccc3f12f314df6809d32d.

(Not supporting renego as a server in any form anyway, we may as well
completely ignore extensions, but then our extensions callbacks can't
assume the parse hooks are always called. This way the various NULL
handlers still function.)

Change-Id: Ie689a0e9ffb0369ef7a20ab4231005e87f32d5f8
Reviewed-on: https://boringssl-review.googlesource.com/6180
Reviewed-by: Adam Langley <agl@google.com>
2015-10-11 20:47:19 +00:00
..
runner Ignore all extensions but renegotiation_info in SSL 3.0. 2015-10-11 20:47:19 +00:00
async_bio.cc Use just one style for the shim. 2015-02-10 01:18:24 +00:00
async_bio.h Remove std::unique_ptr dependency on bssl_shim's scoped types. 2015-03-31 23:03:06 +00:00
bssl_shim.cc Use |strtok| rather than |strtok_r|. 2015-09-23 15:01:07 -07:00
CMakeLists.txt Add malloc test support to unit tests. 2015-05-21 17:59:48 +00:00
packeted_bio.cc Remove OPENSSL_timeval. 2015-05-08 18:03:07 +00:00
packeted_bio.h Remove OPENSSL_timeval. 2015-05-08 18:03:07 +00:00
scoped_types.h Remove std::unique_ptr dependency on bssl_shim's scoped types. 2015-03-31 23:03:06 +00:00
test_config.cc Adding more options for signing digest fallback. 2015-09-23 21:55:01 +00:00
test_config.h Adding more options for signing digest fallback. 2015-09-23 21:55:01 +00:00