6df6540766
TLS 1.3 includes a server-random-based anti-downgrade signal, as a workaround for TLS 1.2's ServerKeyExchange signature failing to cover the entire handshake. However, because TLS 1.3 draft versions are each doomed to die, we cannot deploy it until the final RFC. (Suppose a draft-TLS-1.3 client checked the signal and spoke to a final-TLS-1.3 server. The server would correctly negotiate TLS 1.2 and send the signal. But the client would then break. An anologous situation exists with reversed roles.) However, it appears that Cisco devices have non-compliant TLS 1.2 implementations[1] and copy over another server's server-random when acting as a TLS terminator (client and server back-to-back). Hopefully they are the only ones doing this. Implement a measurement-only version with a different value. This sentinel must not be enforced, but it will tell us whether enforcing it will cause problems. [1] https://www.ietf.org/mail-archive/web/tls/current/msg25168.html Bug: 226 Change-Id: I976880bdb2ef26f51592b2f6b3b97664342679c8 Reviewed-on: https://boringssl-review.googlesource.com/24284 Commit-Queue: David Benjamin <davidben@google.com> CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Reviewed-by: Adam Langley <agl@google.com> |
||
|---|---|---|
| .. | ||
| runner | ||
| async_bio.cc | ||
| async_bio.h | ||
| bssl_shim.cc | ||
| CMakeLists.txt | ||
| fuzzer_tags.h | ||
| fuzzer.h | ||
| packeted_bio.cc | ||
| packeted_bio.h | ||
| PORTING.md | ||
| README.md | ||
| test_config.cc | ||
| test_config.h | ||
BoringSSL SSL Tests
This directory contains BoringSSL's protocol-level test suite.
Testing a TLS implementation can be difficult. We need to produce invalid but sufficiently correct handshakes to get our implementation close to its edge cases. TLS's cryptographic steps mean we cannot use a transcript and effectively need a TLS implementation on the other end. But we do not wish to litter BoringSSL with options for bugs to test against.
Instead, we use a fork of the Go crypto/tls package, heavily patched with
configurable bugs. This code, along with a test suite and harness written in Go,
lives in the runner directory. The harness runs BoringSSL via a C/C++ shim
binary which lives in this directory. All communication with the shim binary
occurs with command-line flags, sockets, and standard I/O.
This strategy also ensures we always test against a second implementation. All features should be implemented twice, once in C for BoringSSL and once in Go for testing. If possible, the Go code should be suitable for potentially upstreaming. However, sometimes test code has different needs. For example, our test DTLS code enforces strict ordering on sequence numbers and has controlled packet drop simulation.
To run the tests manually, run go test from the runner directory. It takes
command-line flags found at the top of runner/runner.go. The -help option
also works after using go test -c to make a runner.test binary first.
If adding a new test, these files may be a good starting point:
runner/runner.go: the test harness and all the individual tests.runner/common.go: contains theConfigandProtocolBugsstruct which control the Go TLS implementation's behavior.test_config.h,test_config.cc: the command-line flags which control the shim's behavior.bssl_shim.cc: the shim binary itself.
For porting the test suite to a different implementation see PORTING.md.