boringssl

History

David Benjamin 8370bfd6d1 Remove unhelpful warning about changing state numbers. This dates all the way to SSLeay 0.9.0b. At this point the application/handshake interleave logic in ssl3_read_bytes was already present: (( (s->state & SSL_ST_CONNECT) && (s->state >= SSL3_ST_CW_CLNT_HELLO_A) && (s->state <= SSL3_ST_CR_SRVR_HELLO_A) ) \|\| ( (s->state & SSL_ST_ACCEPT) && (s->state <= SSL3_ST_SW_HELLO_REQ_A) && (s->state >= SSL3_ST_SR_CLNT_HELLO_A) ) The comment is attached to SSL3_ST_SR_CLNT_HELLO_A, so I suspect this is what it was about. This logic is gone now, so let's remove that scary warning. Change-Id: I45f13b53b79e35d80e6074b0942600434deb0684 Reviewed-on: https://boringssl-review.googlesource.com/6299 Reviewed-by: Adam Langley <alangley@gmail.com>	2015-10-26 17:48:57 +00:00
..
openssl	Remove unhelpful warning about changing state numbers.	2015-10-26 17:48:57 +00:00

David Benjamin 8370bfd6d1 Remove unhelpful warning about changing state numbers.

This dates all the way to SSLeay 0.9.0b. At this point the
application/handshake interleave logic in ssl3_read_bytes was already
present:

((
  (s->state & SSL_ST_CONNECT) &&
  (s->state >= SSL3_ST_CW_CLNT_HELLO_A) &&
  (s->state <= SSL3_ST_CR_SRVR_HELLO_A)
 ) || (
  (s->state & SSL_ST_ACCEPT) &&
  (s->state <= SSL3_ST_SW_HELLO_REQ_A) &&
  (s->state >= SSL3_ST_SR_CLNT_HELLO_A)
 )

The comment is attached to SSL3_ST_SR_CLNT_HELLO_A, so I suspect this is
what it was about. This logic is gone now, so let's remove that scary
warning.

Change-Id: I45f13b53b79e35d80e6074b0942600434deb0684
Reviewed-on: https://boringssl-review.googlesource.com/6299
Reviewed-by: Adam Langley <alangley@gmail.com>

2015-10-26 17:48:57 +00:00

openssl

Remove unhelpful warning about changing state numbers.

2015-10-26 17:48:57 +00:00