958346a5e7
It's not completely clear to me why select_cetificate_cb behaves the way it does, however not only is it confusing, but it makes assumptions about the application using BoringSSL (it's not always possible to implement custom logic outside of the callbacks provided by libssl), that make this callback somewhat useless. Case in point, the callback can be used for changing min/max protocol versions based on per-site policies, and select_certificate_cb is the only place where SSL_set_min/max_proto_version() can be used (e.g. you can't call them in cert_cb because it's too late), but the decision on the specific versions to use might depend on configuration that needs retrieving asynchronously from over the network, which requires re-running the callback multiple times. Change-Id: Ia8e151b163628545373e7fd1f327e9af207478a6 Reviewed-on: https://boringssl-review.googlesource.com/13000 Reviewed-by: David Benjamin <davidben@google.com> Commit-Queue: David Benjamin <davidben@google.com> |
||
|---|---|---|
| .. | ||
| runner | ||
| async_bio.cc | ||
| async_bio.h | ||
| bssl_shim.cc | ||
| CMakeLists.txt | ||
| packeted_bio.cc | ||
| packeted_bio.h | ||
| PORTING.md | ||
| README.md | ||
| test_config.cc | ||
| test_config.h | ||
BoringSSL SSL Tests
This directory contains BoringSSL's protocol-level test suite.
Testing a TLS implementation can be difficult. We need to produce invalid but sufficiently correct handshakes to get our implementation close to its edge cases. TLS's cryptographic steps mean we cannot use a transcript and effectively need a TLS implementation on the other end. But we do not wish to litter BoringSSL with options for bugs to test against.
Instead, we use a fork of the Go crypto/tls package, heavily patched with
configurable bugs. This code, along with a test suite and harness written in Go,
lives in the runner directory. The harness runs BoringSSL via a C/C++ shim
binary which lives in this directory. All communication with the shim binary
occurs with command-line flags, sockets, and standard I/O.
This strategy also ensures we always test against a second implementation. All features should be implemented twice, once in C for BoringSSL and once in Go for testing. If possible, the Go code should be suitable for potentially upstreaming. However, sometimes test code has different needs. For example, our test DTLS code enforces strict ordering on sequence numbers and has controlled packet drop simulation.
To run the tests manually, run go test from the runner directory. It takes
command-line flags found at the top of runner/runner.go. The -help option
also works after using go test -c to make a runner.test binary first.
If adding a new test, these files may be a good starting point:
runner/runner.go: the test harness and all the individual tests.runner/common.go: contains theConfigandProtocolBugsstruct which control the Go TLS implementation's behavior.test_config.h,test_config.cc: the command-line flags which control the shim's behavior.bssl_shim.cc: the shim binary itself.
For porting the test suite to a different implementation see PORTING.md.