kris/boringssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
9a89250285
boringssl/ssl
History
David Benjamin 9a89250285 Don't use std::is_trivially_destructable. 
It returns false for incomplete types (or is undefined prior to C++14),
so other instantiations can get confused. Instead, require an explicit
kAllowUniquePtr toggle.

I tried using sizeof(T) to SFINAE-detect an incomplete type but ran into
MSVC issues, I think
https://connect.microsoft.com/VisualStudio/feedback/details/820390/vc-sizeof-doesnt-work-as-expected-in-sfinae-context
Though it seems this also may cause ODR violations if different
compilation units disagree on whether a type is complete. This is all a
mess, so just do the boring thing.

Bug: 132
Change-Id: I6f2d47499f16e75f62629c76f43a5329e91c6daf
Reviewed-on: https://boringssl-review.googlesource.com/18464
Reviewed-by: Steven Valdez <svaldez@google.com>
Commit-Queue: Steven Valdez <svaldez@google.com>
2017-07-26 20:55:37 +00:00
..
test Send correct fatal alert the renegotation extension fails to match. 2017-07-25 21:02:43 +00:00
bio_ssl.cc Switch a number of files to C++. 2017-07-12 20:54:02 +00:00
CMakeLists.txt Add bssl::SealRecord and bssl::OpenRecord. 2017-07-24 20:14:08 +00:00
custom_extensions.cc Switch BORINGSSL_INTERNAL_CXX_TYPES in favor of subclassing games. 2017-07-20 17:24:12 +00:00
d1_both.cc Convert SSL_TRANSCRIPT to C++. 2017-07-20 21:10:02 +00:00
d1_lib.cc Switch BORINGSSL_INTERNAL_CXX_TYPES in favor of subclassing games. 2017-07-20 17:24:12 +00:00
d1_pkt.cc Switch BORINGSSL_INTERNAL_CXX_TYPES in favor of subclassing games. 2017-07-20 17:24:12 +00:00
d1_srtp.cc Switch BORINGSSL_INTERNAL_CXX_TYPES in favor of subclassing games. 2017-07-20 17:24:12 +00:00
dtls_method.cc Switch BORINGSSL_INTERNAL_CXX_TYPES in favor of subclassing games. 2017-07-20 17:24:12 +00:00
dtls_record.cc Switch BORINGSSL_INTERNAL_CXX_TYPES in favor of subclassing games. 2017-07-20 17:24:12 +00:00
handshake_client.cc Return null from SSL_get0_peer_certificates if unauthenticated. 2017-07-25 18:53:48 +00:00
handshake_server.cc Return null from SSL_get0_peer_certificates if unauthenticated. 2017-07-25 18:53:48 +00:00
internal.h Don't use std::is_trivially_destructable. 2017-07-26 20:55:37 +00:00
s3_both.cc Convert SSL_ECDH_CTX to C++. 2017-07-20 21:27:23 +00:00
s3_lib.cc Switch BORINGSSL_INTERNAL_CXX_TYPES in favor of subclassing games. 2017-07-20 17:24:12 +00:00
s3_pkt.cc Switch BORINGSSL_INTERNAL_CXX_TYPES in favor of subclassing games. 2017-07-20 17:24:12 +00:00
span_test.cc Add bssl::SealRecord and bssl::OpenRecord. 2017-07-24 20:14:08 +00:00
ssl_aead_ctx.cc Switch BORINGSSL_INTERNAL_CXX_TYPES in favor of subclassing games. 2017-07-20 17:24:12 +00:00
ssl_asn1.cc Remove obsolete TODOs. 2017-07-24 22:28:34 +00:00
ssl_buffer.cc Switch BORINGSSL_INTERNAL_CXX_TYPES in favor of subclassing games. 2017-07-20 17:24:12 +00:00
ssl_cert.cc Return null from SSL_get0_peer_certificates if unauthenticated. 2017-07-25 18:53:48 +00:00
ssl_cipher.cc Document the behaviour of non-standard separators in cipher strings. 2017-07-25 20:48:44 +00:00
ssl_file.cc Switch BORINGSSL_INTERNAL_CXX_TYPES in favor of subclassing games. 2017-07-20 17:24:12 +00:00
ssl_key_share.cc Convert SSL_ECDH_CTX to C++. 2017-07-20 21:27:23 +00:00
ssl_lib.cc Add a bunch of scopers. 2017-07-20 20:38:55 +00:00
ssl_privkey.cc Add a bunch of scopers. 2017-07-20 20:38:55 +00:00
ssl_session.cc Add a bunch of scopers. 2017-07-20 20:38:55 +00:00
ssl_stat.cc Switch BORINGSSL_INTERNAL_CXX_TYPES in favor of subclassing games. 2017-07-20 17:24:12 +00:00
ssl_test.cc Document the behaviour of non-standard separators in cipher strings. 2017-07-25 20:48:44 +00:00
ssl_transcript.cc Convert SSL_TRANSCRIPT to C++. 2017-07-20 21:10:02 +00:00
ssl_versions.cc Switch BORINGSSL_INTERNAL_CXX_TYPES in favor of subclassing games. 2017-07-20 17:24:12 +00:00
ssl_x509.cc Add a bunch of scopers. 2017-07-20 20:38:55 +00:00
t1_enc.cc Convert SSL_TRANSCRIPT to C++. 2017-07-20 21:10:02 +00:00
t1_lib.cc Send correct fatal alert the renegotation extension fails to match. 2017-07-25 21:02:43 +00:00
tls13_both.cc Return null from SSL_get0_peer_certificates if unauthenticated. 2017-07-25 18:53:48 +00:00
tls13_client.cc Convert SSL_ECDH_CTX to C++. 2017-07-20 21:27:23 +00:00
tls13_enc.cc Convert SSL_TRANSCRIPT to C++. 2017-07-20 21:10:02 +00:00
tls13_server.cc Convert SSL_TRANSCRIPT to C++. 2017-07-20 21:10:02 +00:00
tls_method.cc Switch BORINGSSL_INTERNAL_CXX_TYPES in favor of subclassing games. 2017-07-20 17:24:12 +00:00
tls_record.cc Add bssl::SealRecord and bssl::OpenRecord. 2017-07-24 20:14:08 +00:00