9c01e00c2e
Previously, the ASN.1 functions in bytestring were capable of processing indefinite length elements when the _ber functions were used. That works well enough for PKCS#3, but NSS goes a bit crazy with BER encoding and PKCS#12. Rather than complicate the core bytestring functions further, the BER support is removed from them and moved to a separate function that converts from BER to DER (if needed). Change-Id: I2212b28e99bab9fab8c61f80d2012d3e5a3cc2f0 Reviewed-on: https://boringssl-review.googlesource.com/1591 Reviewed-by: Adam Langley <agl@google.com>
455 lines
13 KiB
C
455 lines
13 KiB
C
/* Copyright (c) 2014, Google Inc.
|
|
*
|
|
* Permission to use, copy, modify, and/or distribute this software for any
|
|
* purpose with or without fee is hereby granted, provided that the above
|
|
* copyright notice and this permission notice appear in all copies.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
|
|
* WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
|
|
* MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY
|
|
* SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
|
|
* WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION
|
|
* OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN
|
|
* CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */
|
|
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
|
|
#include <openssl/bytestring.h>
|
|
|
|
#include "internal.h"
|
|
|
|
|
|
static int test_skip(void) {
|
|
static const uint8_t kData[] = {1, 2, 3};
|
|
CBS data;
|
|
|
|
CBS_init(&data, kData, sizeof(kData));
|
|
return CBS_len(&data) == 3 &&
|
|
CBS_skip(&data, 1) &&
|
|
CBS_len(&data) == 2 &&
|
|
CBS_skip(&data, 2) &&
|
|
CBS_len(&data) == 0 &&
|
|
!CBS_skip(&data, 1);
|
|
}
|
|
|
|
static int test_get_u(void) {
|
|
static const uint8_t kData[] = {1, 2, 3, 4, 5, 6, 7, 8, 9, 10};
|
|
uint8_t u8;
|
|
uint16_t u16;
|
|
uint32_t u32;
|
|
CBS data;
|
|
|
|
CBS_init(&data, kData, sizeof(kData));
|
|
return CBS_get_u8(&data, &u8) &&
|
|
u8 == 1 &&
|
|
CBS_get_u16(&data, &u16) &&
|
|
u16 == 0x203 &&
|
|
CBS_get_u24(&data, &u32) &&
|
|
u32 == 0x40506 &&
|
|
CBS_get_u32(&data, &u32) &&
|
|
u32 == 0x708090a &&
|
|
!CBS_get_u8(&data, &u8);
|
|
}
|
|
|
|
static int test_get_prefixed(void) {
|
|
static const uint8_t kData[] = {1, 2, 0, 2, 3, 4, 0, 0, 3, 3, 2, 1};
|
|
uint8_t u8;
|
|
uint16_t u16;
|
|
uint32_t u32;
|
|
CBS data, prefixed;
|
|
|
|
CBS_init(&data, kData, sizeof(kData));
|
|
return CBS_get_u8_length_prefixed(&data, &prefixed) &&
|
|
CBS_len(&prefixed) == 1 &&
|
|
CBS_get_u8(&prefixed, &u8) &&
|
|
u8 == 2 &&
|
|
CBS_get_u16_length_prefixed(&data, &prefixed) &&
|
|
CBS_len(&prefixed) == 2 &&
|
|
CBS_get_u16(&prefixed, &u16) &&
|
|
u16 == 0x304 &&
|
|
CBS_get_u24_length_prefixed(&data, &prefixed) &&
|
|
CBS_len(&prefixed) == 3 &&
|
|
CBS_get_u24(&prefixed, &u32) &&
|
|
u32 == 0x30201;
|
|
}
|
|
|
|
static int test_get_prefixed_bad(void) {
|
|
static const uint8_t kData1[] = {2, 1};
|
|
static const uint8_t kData2[] = {0, 2, 1};
|
|
static const uint8_t kData3[] = {0, 0, 2, 1};
|
|
CBS data, prefixed;
|
|
|
|
CBS_init(&data, kData1, sizeof(kData1));
|
|
if (CBS_get_u8_length_prefixed(&data, &prefixed)) {
|
|
return 0;
|
|
}
|
|
|
|
CBS_init(&data, kData2, sizeof(kData2));
|
|
if (CBS_get_u16_length_prefixed(&data, &prefixed)) {
|
|
return 0;
|
|
}
|
|
|
|
CBS_init(&data, kData3, sizeof(kData3));
|
|
if (CBS_get_u24_length_prefixed(&data, &prefixed)) {
|
|
return 0;
|
|
}
|
|
|
|
return 1;
|
|
}
|
|
|
|
static int test_get_asn1(void) {
|
|
static const uint8_t kData1[] = {0x30, 2, 1, 2};
|
|
static const uint8_t kData2[] = {0x30, 3, 1, 2};
|
|
static const uint8_t kData3[] = {0x30, 0x80};
|
|
static const uint8_t kData4[] = {0x30, 0x81, 1, 1};
|
|
static const uint8_t kData5[] = {0x30, 0x82, 0, 1, 1};
|
|
|
|
CBS data, contents;
|
|
|
|
CBS_init(&data, kData1, sizeof(kData1));
|
|
if (!CBS_get_asn1(&data, &contents, 0x30) ||
|
|
CBS_len(&contents) != 2 ||
|
|
memcmp(CBS_data(&contents), "\x01\x02", 2) != 0) {
|
|
return 0;
|
|
}
|
|
|
|
CBS_init(&data, kData2, sizeof(kData2));
|
|
/* data is truncated */
|
|
if (CBS_get_asn1(&data, &contents, 0x30)) {
|
|
return 0;
|
|
}
|
|
|
|
CBS_init(&data, kData3, sizeof(kData3));
|
|
/* zero byte length of length */
|
|
if (CBS_get_asn1(&data, &contents, 0x30)) {
|
|
return 0;
|
|
}
|
|
|
|
CBS_init(&data, kData4, sizeof(kData4));
|
|
/* long form mistakenly used. */
|
|
if (CBS_get_asn1(&data, &contents, 0x30)) {
|
|
return 0;
|
|
}
|
|
|
|
CBS_init(&data, kData5, sizeof(kData5));
|
|
/* length takes too many bytes. */
|
|
if (CBS_get_asn1(&data, &contents, 0x30)) {
|
|
return 0;
|
|
}
|
|
|
|
CBS_init(&data, kData1, sizeof(kData1));
|
|
/* wrong tag. */
|
|
if (CBS_get_asn1(&data, &contents, 0x31)) {
|
|
return 0;
|
|
}
|
|
|
|
return 1;
|
|
}
|
|
|
|
static int test_cbb_basic(void) {
|
|
static const uint8_t kExpected[] = {1, 2, 3, 4, 5, 6, 7, 8};
|
|
uint8_t *buf;
|
|
size_t buf_len;
|
|
int ok;
|
|
CBB cbb;
|
|
|
|
if (!CBB_init(&cbb, 100)) {
|
|
return 0;
|
|
}
|
|
CBB_cleanup(&cbb);
|
|
|
|
if (!CBB_init(&cbb, 0) ||
|
|
!CBB_add_u8(&cbb, 1) ||
|
|
!CBB_add_u16(&cbb, 0x203) ||
|
|
!CBB_add_u24(&cbb, 0x40506) ||
|
|
!CBB_add_bytes(&cbb, (const uint8_t*) "\x07\x08", 2) ||
|
|
!CBB_finish(&cbb, &buf, &buf_len)) {
|
|
return 0;
|
|
}
|
|
|
|
ok = buf_len == sizeof(kExpected) && memcmp(buf, kExpected, buf_len) == 0;
|
|
free(buf);
|
|
return ok;
|
|
}
|
|
|
|
static int test_cbb_fixed(void) {
|
|
CBB cbb;
|
|
uint8_t buf[1];
|
|
uint8_t *out_buf;
|
|
size_t out_size;
|
|
|
|
if (!CBB_init_fixed(&cbb, NULL, 0) ||
|
|
CBB_add_u8(&cbb, 1) ||
|
|
!CBB_finish(&cbb, &out_buf, &out_size) ||
|
|
out_buf != NULL ||
|
|
out_size != 0) {
|
|
return 0;
|
|
}
|
|
|
|
if (!CBB_init_fixed(&cbb, buf, 1) ||
|
|
!CBB_add_u8(&cbb, 1) ||
|
|
CBB_add_u8(&cbb, 2) ||
|
|
!CBB_finish(&cbb, &out_buf, &out_size) ||
|
|
out_buf != buf ||
|
|
out_size != 1 ||
|
|
buf[0] != 1) {
|
|
return 0;
|
|
}
|
|
|
|
return 1;
|
|
}
|
|
|
|
static int test_cbb_finish_child(void) {
|
|
CBB cbb, child;
|
|
uint8_t *out_buf;
|
|
size_t out_size;
|
|
|
|
if (!CBB_init(&cbb, 16) ||
|
|
!CBB_add_u8_length_prefixed(&cbb, &child) ||
|
|
CBB_finish(&child, &out_buf, &out_size) ||
|
|
!CBB_finish(&cbb, &out_buf, &out_size) ||
|
|
out_size != 1 ||
|
|
out_buf[0] != 0) {
|
|
return 0;
|
|
}
|
|
|
|
free(out_buf);
|
|
return 1;
|
|
}
|
|
|
|
static int test_cbb_prefixed(void) {
|
|
static const uint8_t kExpected[] = {0, 1, 1, 0, 2, 2, 3, 0, 0, 3,
|
|
4, 5, 6, 5, 4, 1, 0, 1, 2};
|
|
uint8_t *buf;
|
|
size_t buf_len;
|
|
CBB cbb, contents, inner_contents, inner_inner_contents;
|
|
int ok;
|
|
|
|
if (!CBB_init(&cbb, 0) ||
|
|
!CBB_add_u8_length_prefixed(&cbb, &contents) ||
|
|
!CBB_add_u8_length_prefixed(&cbb, &contents) ||
|
|
!CBB_add_u8(&contents, 1) ||
|
|
!CBB_add_u16_length_prefixed(&cbb, &contents) ||
|
|
!CBB_add_u16(&contents, 0x203) ||
|
|
!CBB_add_u24_length_prefixed(&cbb, &contents) ||
|
|
!CBB_add_u24(&contents, 0x40506) ||
|
|
!CBB_add_u8_length_prefixed(&cbb, &contents) ||
|
|
!CBB_add_u8_length_prefixed(&contents, &inner_contents) ||
|
|
!CBB_add_u8(&inner_contents, 1) ||
|
|
!CBB_add_u16_length_prefixed(&inner_contents, &inner_inner_contents) ||
|
|
!CBB_add_u8(&inner_inner_contents, 2) ||
|
|
!CBB_finish(&cbb, &buf, &buf_len)) {
|
|
return 0;
|
|
}
|
|
|
|
ok = buf_len == sizeof(kExpected) && memcmp(buf, kExpected, buf_len) == 0;
|
|
free(buf);
|
|
return ok;
|
|
}
|
|
|
|
static int test_cbb_misuse(void) {
|
|
CBB cbb, child, contents;
|
|
uint8_t *buf;
|
|
size_t buf_len;
|
|
|
|
if (!CBB_init(&cbb, 0) ||
|
|
!CBB_add_u8_length_prefixed(&cbb, &child) ||
|
|
!CBB_add_u8(&child, 1) ||
|
|
!CBB_add_u8(&cbb, 2)) {
|
|
return 0;
|
|
}
|
|
|
|
/* Since we wrote to |cbb|, |child| is now invalid and attempts to write to
|
|
* it should fail. */
|
|
if (CBB_add_u8(&child, 1) ||
|
|
CBB_add_u16(&child, 1) ||
|
|
CBB_add_u24(&child, 1) ||
|
|
CBB_add_u8_length_prefixed(&child, &contents) ||
|
|
CBB_add_u16_length_prefixed(&child, &contents) ||
|
|
CBB_add_asn1(&child, &contents, 1) ||
|
|
CBB_add_bytes(&child, (const uint8_t*) "a", 1)) {
|
|
fprintf(stderr, "CBB operation on invalid CBB did not fail.\n");
|
|
return 0;
|
|
}
|
|
|
|
if (!CBB_finish(&cbb, &buf, &buf_len) ||
|
|
buf_len != 3 ||
|
|
memcmp(buf, "\x01\x01\x02", 3) != 0) {
|
|
return 0;
|
|
}
|
|
|
|
free(buf);
|
|
|
|
return 1;
|
|
}
|
|
|
|
static int test_cbb_asn1(void) {
|
|
static const uint8_t kExpected[] = {0x30, 3, 1, 2, 3};
|
|
uint8_t *buf, *test_data;
|
|
size_t buf_len;
|
|
CBB cbb, contents, inner_contents;
|
|
|
|
if (!CBB_init(&cbb, 0) ||
|
|
!CBB_add_asn1(&cbb, &contents, 0x30) ||
|
|
!CBB_add_bytes(&contents, (const uint8_t*) "\x01\x02\x03", 3) ||
|
|
!CBB_finish(&cbb, &buf, &buf_len)) {
|
|
return 0;
|
|
}
|
|
|
|
if (buf_len != sizeof(kExpected) || memcmp(buf, kExpected, buf_len) != 0) {
|
|
return 0;
|
|
}
|
|
free(buf);
|
|
|
|
test_data = malloc(100000);
|
|
memset(test_data, 0x42, 100000);
|
|
|
|
if (!CBB_init(&cbb, 0) ||
|
|
!CBB_add_asn1(&cbb, &contents, 0x30) ||
|
|
!CBB_add_bytes(&contents, test_data, 130) ||
|
|
!CBB_finish(&cbb, &buf, &buf_len)) {
|
|
return 0;
|
|
}
|
|
|
|
if (buf_len != 3 + 130 ||
|
|
memcmp(buf, "\x30\x81\x82", 3) != 0 ||
|
|
memcmp(buf + 3, test_data, 130) != 0) {
|
|
return 0;
|
|
}
|
|
free(buf);
|
|
|
|
if (!CBB_init(&cbb, 0) ||
|
|
!CBB_add_asn1(&cbb, &contents, 0x30) ||
|
|
!CBB_add_bytes(&contents, test_data, 1000) ||
|
|
!CBB_finish(&cbb, &buf, &buf_len)) {
|
|
return 0;
|
|
}
|
|
|
|
if (buf_len != 4 + 1000 ||
|
|
memcmp(buf, "\x30\x82\x03\xe8", 4) != 0 ||
|
|
memcmp(buf + 4, test_data, 1000)) {
|
|
return 0;
|
|
}
|
|
free(buf);
|
|
|
|
if (!CBB_init(&cbb, 0) ||
|
|
!CBB_add_asn1(&cbb, &contents, 0x30) ||
|
|
!CBB_add_asn1(&contents, &inner_contents, 0x30) ||
|
|
!CBB_add_bytes(&inner_contents, test_data, 100000) ||
|
|
!CBB_finish(&cbb, &buf, &buf_len)) {
|
|
return 0;
|
|
}
|
|
|
|
if (buf_len != 5 + 5 + 100000 ||
|
|
memcmp(buf, "\x30\x83\x01\x86\xa5\x30\x83\x01\x86\xa0", 10) != 0 ||
|
|
memcmp(buf + 10, test_data, 100000)) {
|
|
return 0;
|
|
}
|
|
free(buf);
|
|
|
|
free(test_data);
|
|
return 1;
|
|
}
|
|
|
|
static int do_ber_convert(const char *name,
|
|
const uint8_t *der_expected, size_t der_len,
|
|
const uint8_t *ber, size_t ber_len) {
|
|
CBS in;
|
|
uint8_t *out;
|
|
size_t out_len;
|
|
|
|
CBS_init(&in, ber, ber_len);
|
|
if (!CBS_asn1_ber_to_der(&in, &out, &out_len)) {
|
|
fprintf(stderr, "%s: CBS_asn1_ber_to_der failed.\n", name);
|
|
return 0;
|
|
}
|
|
|
|
if (out == NULL) {
|
|
if (ber_len != der_len ||
|
|
memcmp(der_expected, ber, ber_len) != 0) {
|
|
fprintf(stderr, "%s: incorrect unconverted result.\n", name);
|
|
return 0;
|
|
}
|
|
|
|
return 1;
|
|
}
|
|
|
|
if (out_len != der_len ||
|
|
memcmp(out, der_expected, der_len) != 0) {
|
|
fprintf(stderr, "%s: incorrect converted result.\n", name);
|
|
return 0;
|
|
}
|
|
|
|
free(out);
|
|
return 1;
|
|
}
|
|
|
|
static int test_ber_convert(void) {
|
|
static const uint8_t kSimpleBER[] = {0x01, 0x01, 0x00};
|
|
|
|
/* kIndefBER contains a SEQUENCE with an indefinite length. */
|
|
static const uint8_t kIndefBER[] = {0x30, 0x80, 0x01, 0x01, 0x02, 0x00, 0x00};
|
|
static const uint8_t kIndefDER[] = {0x30, 0x03, 0x01, 0x01, 0x02};
|
|
|
|
/* kOctetStringBER contains an indefinite length OCTETSTRING with two parts.
|
|
* These parts need to be concatenated in DER form. */
|
|
static const uint8_t kOctetStringBER[] = {0x24, 0x80, 0x04, 0x02, 0, 1,
|
|
0x04, 0x02, 2, 3, 0x00, 0x00};
|
|
static const uint8_t kOctetStringDER[] = {0x04, 0x04, 0, 1, 2, 3};
|
|
|
|
/* kNSSBER is part of a PKCS#12 message generated by NSS that uses indefinite
|
|
* length elements extensively. */
|
|
static const uint8_t kNSSBER[] = {
|
|
0x30, 0x80, 0x02, 0x01, 0x03, 0x30, 0x80, 0x06, 0x09, 0x2a, 0x86, 0x48,
|
|
0x86, 0xf7, 0x0d, 0x01, 0x07, 0x01, 0xa0, 0x80, 0x24, 0x80, 0x04, 0x04,
|
|
0x01, 0x02, 0x03, 0x04, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x30, 0x39,
|
|
0x30, 0x21, 0x30, 0x09, 0x06, 0x05, 0x2b, 0x0e, 0x03, 0x02, 0x1a, 0x05,
|
|
0x00, 0x04, 0x14, 0x84, 0x98, 0xfc, 0x66, 0x33, 0xee, 0xba, 0xe7, 0x90,
|
|
0xc1, 0xb6, 0xe8, 0x8f, 0xfe, 0x1d, 0xc5, 0xa5, 0x97, 0x93, 0x3e, 0x04,
|
|
0x10, 0x38, 0x62, 0xc6, 0x44, 0x12, 0xd5, 0x30, 0x00, 0xf8, 0xf2, 0x1b,
|
|
0xf0, 0x6e, 0x10, 0x9b, 0xb8, 0x02, 0x02, 0x07, 0xd0, 0x00, 0x00,
|
|
};
|
|
|
|
static const uint8_t kNSSDER[] = {
|
|
0x30, 0x53, 0x02, 0x01, 0x03, 0x30, 0x13, 0x06, 0x09, 0x2a, 0x86,
|
|
0x48, 0x86, 0xf7, 0x0d, 0x01, 0x07, 0x01, 0xa0, 0x06, 0x04, 0x04,
|
|
0x01, 0x02, 0x03, 0x04, 0x30, 0x39, 0x30, 0x21, 0x30, 0x09, 0x06,
|
|
0x05, 0x2b, 0x0e, 0x03, 0x02, 0x1a, 0x05, 0x00, 0x04, 0x14, 0x84,
|
|
0x98, 0xfc, 0x66, 0x33, 0xee, 0xba, 0xe7, 0x90, 0xc1, 0xb6, 0xe8,
|
|
0x8f, 0xfe, 0x1d, 0xc5, 0xa5, 0x97, 0x93, 0x3e, 0x04, 0x10, 0x38,
|
|
0x62, 0xc6, 0x44, 0x12, 0xd5, 0x30, 0x00, 0xf8, 0xf2, 0x1b, 0xf0,
|
|
0x6e, 0x10, 0x9b, 0xb8, 0x02, 0x02, 0x07, 0xd0,
|
|
};
|
|
|
|
return do_ber_convert("kSimpleBER", kSimpleBER, sizeof(kSimpleBER),
|
|
kSimpleBER, sizeof(kSimpleBER)) &&
|
|
do_ber_convert("kIndefBER", kIndefDER, sizeof(kIndefDER), kIndefBER,
|
|
sizeof(kIndefBER)) &&
|
|
do_ber_convert("kOctetStringBER", kOctetStringDER,
|
|
sizeof(kOctetStringDER), kOctetStringBER,
|
|
sizeof(kOctetStringBER)) &&
|
|
do_ber_convert("kNSSBER", kNSSDER, sizeof(kNSSDER), kNSSBER,
|
|
sizeof(kNSSBER));
|
|
}
|
|
|
|
int main(void) {
|
|
if (!test_skip() ||
|
|
!test_get_u() ||
|
|
!test_get_prefixed() ||
|
|
!test_get_prefixed_bad() ||
|
|
!test_get_asn1() ||
|
|
!test_cbb_basic() ||
|
|
!test_cbb_fixed() ||
|
|
!test_cbb_finish_child() ||
|
|
!test_cbb_misuse() ||
|
|
!test_cbb_prefixed() ||
|
|
!test_cbb_asn1() ||
|
|
!test_ber_convert()) {
|
|
return 1;
|
|
}
|
|
|
|
printf("PASS\n");
|
|
return 0;
|
|
}
|