kris/boringssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
a3d76d019f
boringssl/ssl/test
History
David Benjamin b853f315dd Fix handling of ServerHellos with omitted extensions. 
Due to SSL 3.0 legacy, TLS 1.0 through 1.2 allow ClientHello and
ServerHello messages to omit the extensions field altogether, rather
than write an empty field. We broke this in
https://boringssl-review.googlesource.com/c/17704/ when we needed to a
second ServerHello parsing path.

Fix this and add some regression tests to explicitly test both the
omitted and empty extensions ClientHello and ServerHello cases.

Bug: chromium:743218
Change-Id: I8297ba608570238e19f12ea44a9fe2fe9d881d28
Reviewed-on: https://boringssl-review.googlesource.com/17904
Reviewed-by: David Benjamin <davidben@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
2017-07-14 23:17:40 +00:00
..
runner Fix handling of ServerHellos with omitted extensions. 2017-07-14 23:17:40 +00:00
async_bio.cc Work around language and compiler bug in memcpy, etc. 2016-12-21 20:34:47 +00:00
async_bio.h Replace Scoped* heap types with bssl::UniquePtr. 2016-09-01 22:22:54 +00:00
bssl_shim.cc Add some timestamps to connect/accept failures. 2017-07-14 20:55:40 +00:00
CMakeLists.txt
fuzzer.h Fix TLS 1.3 variant fuzzers. 2017-07-14 20:21:24 +00:00
packeted_bio.cc Remove support for blocking DTLS timeout handling. 2017-03-01 19:59:28 +00:00
packeted_bio.h Remove support for blocking DTLS timeout handling. 2017-03-01 19:59:28 +00:00
PORTING.md Document that malloc tests require a longer timeout. 2016-09-30 19:13:05 +00:00
README.md Adding PORTING.md for instructions on how to port the test runner 2016-08-16 17:53:28 +00:00
test_config.cc Implement experimental alternate encoding of TLS 1.3. 2017-07-10 18:15:08 +00:00
test_config.h Implement experimental alternate encoding of TLS 1.3. 2017-07-10 18:15:08 +00:00

README.md

BoringSSL SSL Tests

This directory contains BoringSSL's protocol-level test suite.

Testing a TLS implementation can be difficult. We need to produce invalid but sufficiently correct handshakes to get our implementation close to its edge cases. TLS's cryptographic steps mean we cannot use a transcript and effectively need a TLS implementation on the other end. But we do not wish to litter BoringSSL with options for bugs to test against.

Instead, we use a fork of the Go crypto/tls package, heavily patched with configurable bugs. This code, along with a test suite and harness written in Go, lives in the runner directory. The harness runs BoringSSL via a C/C++ shim binary which lives in this directory. All communication with the shim binary occurs with command-line flags, sockets, and standard I/O.

This strategy also ensures we always test against a second implementation. All features should be implemented twice, once in C for BoringSSL and once in Go for testing. If possible, the Go code should be suitable for potentially upstreaming. However, sometimes test code has different needs. For example, our test DTLS code enforces strict ordering on sequence numbers and has controlled packet drop simulation.

To run the tests manually, run go test from the runner directory. It takes command-line flags found at the top of runner/runner.go. The -help option also works after using go test -c to make a runner.test binary first.

If adding a new test, these files may be a good starting point:

  • runner/runner.go: the test harness and all the individual tests.
  • runner/common.go: contains the Config and ProtocolBugs struct which control the Go TLS implementation's behavior.
  • test_config.h, test_config.cc: the command-line flags which control the shim's behavior.
  • bssl_shim.cc: the shim binary itself.

For porting the test suite to a different implementation see PORTING.md.