kris/boringssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
a565d29ce6
boringssl/ssl
History
David Benjamin a565d29ce6 Remove alert mapping machinery. 
For TLS, this machinery only exists to swallow no_certificate alerts
which only get sent in an SSL 3.0 codepath anyway. It's much less a
no-op for SSL 3.0 which, strictly speaking, has only a subset of TLS's
alerts.

This gets messy around version negotiation because of the complex
relationship between enc_method, have_version, and version which all get
set at different times. Given that SSL 3.0 is nearly dead and all these
alerts are fatal to the connection anyway, this doesn't seem worth
carrying around. (It doesn't work very well anyway. An SSLv3-only server
may still send a record_overflow alert before version negotiation.)

This removes the last place enc_method is accessed prior to version
negotiation.

Change-Id: I79a704259fca69e4df76bd5a6846c9373f46f5a9
Reviewed-on: https://boringssl-review.googlesource.com/6843
Reviewed-by: Adam Langley <alangley@gmail.com>
2016-01-27 21:28:48 +00:00
..
pqueue Add a run_tests target to run all tests. 2015-10-26 20:33:44 +00:00
test Remove alert mapping machinery. 2016-01-27 21:28:48 +00:00
CMakeLists.txt Implement draft-ietf-tls-curve25519-01 in C. 2015-12-22 21:51:30 +00:00
custom_extensions.c
d1_both.c Switch s to ssl everywhere. 2015-12-22 23:28:22 +00:00
d1_clnt.c Prune finished labels from SSL3_ENC_METHOD. 2016-01-15 22:04:53 +00:00
d1_lib.c Switch s to ssl everywhere. 2015-12-22 23:28:22 +00:00
d1_meth.c Pull ChangeCipherSpec into the handshake state machine. 2015-12-16 18:36:57 +00:00
d1_pkt.c Move aead_{read,write}_ctx and next_proto_negotiated into ssl->s3. 2016-01-15 21:40:25 +00:00
d1_srtp.c Add defines for SRTP profiles using GCM ciphers from RFC 7714. 2015-12-10 23:18:16 +00:00
d1_srvr.c Prune finished labels from SSL3_ENC_METHOD. 2016-01-15 22:04:53 +00:00
dtls_record.c Move aead_{read,write}_ctx and next_proto_negotiated into ssl->s3. 2016-01-15 21:40:25 +00:00
internal.h Remove alert mapping machinery. 2016-01-27 21:28:48 +00:00
s3_both.c Replace enc_flags with normalized version checks. 2016-01-27 21:17:55 +00:00
s3_clnt.c Replace enc_flags with normalized version checks. 2016-01-27 21:17:55 +00:00
s3_enc.c Remove alert mapping machinery. 2016-01-27 21:28:48 +00:00
s3_lib.c Replace enc_flags with normalized version checks. 2016-01-27 21:17:55 +00:00
s3_meth.c Pull ChangeCipherSpec into the handshake state machine. 2015-12-16 18:36:57 +00:00
s3_pkt.c Remove alert mapping machinery. 2016-01-27 21:28:48 +00:00
s3_srvr.c Replace enc_flags with normalized version checks. 2016-01-27 21:17:55 +00:00
ssl_aead_ctx.c Implement draft-ietf-tls-chacha20-poly1305-04. 2015-12-16 23:34:56 +00:00
ssl_asn1.c Check for overflow when parsing a CBS with d2i_*. 2015-11-16 23:17:42 +00:00
ssl_buffer.c Remove SSL_OP_MICROSOFT_BIG_SSLV3_BUFFER. 2015-12-15 19:14:00 +00:00
ssl_cert.c Remove unreachable code to duplicate DH keys. 2015-12-16 21:20:12 +00:00
ssl_cipher.c Fix -Wformat-nonliteral violation in ssl_cipher.c. 2016-01-21 20:56:59 +00:00
ssl_ecdh.c Drop the silly 'ECDH_' prefix on X25519. 2016-01-20 17:26:13 +00:00
ssl_file.c
ssl_lib.c Replace enc_flags with normalized version checks. 2016-01-27 21:17:55 +00:00
ssl_rsa.c Add get0 getters for EVP_PKEY. 2015-11-20 23:34:12 +00:00
ssl_session.c Consider session if the client supports tickets but offered a session ID. 2016-01-15 20:08:52 +00:00
ssl_stat.c
ssl_test.cc Implement draft-ietf-tls-chacha20-poly1305-04. 2015-12-16 23:34:56 +00:00
t1_enc.c Remove alert mapping machinery. 2016-01-27 21:28:48 +00:00
t1_lib.c Replace enc_flags with normalized version checks. 2016-01-27 21:17:55 +00:00
tls_record.c Replace enc_flags with normalized version checks. 2016-01-27 21:17:55 +00:00