kris/boringssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
ade291c566
boringssl/crypto
History
David Benjamin ade291c566 Clean up the DES_key_schedule logic. 
It's not clear why OpenSSL had a union. The comment says something about sizes
of long, since OpenSSL doesn't use stdint.h. But the variable is treated as a
bunch of uint32_t's, not DES_cblocks.

The key schedule is also always used by iterating or indexing into a uint32_t*,
treating the 16 2-word subkeys as a single uint32_t[32]. Instead, index into
them properly shush any picky tools. The compiler should be able to figure out
what's going on and optimize it appropriately.

BUG=517495

Change-Id: I83d0e63ac2c6fb76fac1dceda9f2fd6762074341
Reviewed-on: https://boringssl-review.googlesource.com/5627
Reviewed-by: Adam Langley <agl@google.com>
2015-08-07 01:55:59 +00:00
..
aes Convert remaining Latin-1 files to UTF-8. 2015-07-29 19:22:55 +00:00
asn1 Remove the func parameter to OPENSSL_PUT_ERROR. 2015-07-16 02:02:37 +00:00
base64 Add malloc test support to unit tests. 2015-05-21 17:59:48 +00:00
bio Avoid using |WIN32| and use |OPENSSL_WINDOWS| instead. 2015-07-31 22:34:34 +00:00
bn Remove stray (void)0. 2015-08-07 01:53:43 +00:00
buf Remove the func parameter to OPENSSL_PUT_ERROR. 2015-07-16 02:02:37 +00:00
bytestring Make CBB_len return a length, not remaining. 2015-07-09 19:20:09 +00:00
chacha Emit #if guards for ARM assembly files. 2015-06-23 21:00:32 +00:00
cipher Add |EVP_rc2_cbc| and implement |EVP_CTRL_SET_RC2_KEY_BITS|. 2015-08-05 21:23:56 +00:00
cmac Remove BIO dependency from cmac_test. 2015-08-07 01:53:01 +00:00
conf Remove the func parameter to OPENSSL_PUT_ERROR. 2015-07-16 02:02:37 +00:00
des Clean up the DES_key_schedule logic. 2015-08-07 01:55:59 +00:00
dh Remove the func parameter to OPENSSL_PUT_ERROR. 2015-07-16 02:02:37 +00:00
digest Remove the func parameter to OPENSSL_PUT_ERROR. 2015-07-16 02:02:37 +00:00
dsa Remove the func parameter to OPENSSL_PUT_ERROR. 2015-07-16 02:02:37 +00:00
ec Improve error checking of some |BN_CTX_get| callers. 2015-08-07 00:50:17 +00:00
ecdh Remove the func parameter to OPENSSL_PUT_ERROR. 2015-07-16 02:02:37 +00:00
ecdsa Improve error checking of some |BN_CTX_get| callers. 2015-08-07 00:50:17 +00:00
engine Precompute sorted array for error strings. 2015-02-09 17:35:31 -08:00
err Avoid using |WIN32| and use |OPENSSL_WINDOWS| instead. 2015-07-31 22:34:34 +00:00
evp Fix Windows build. 2015-08-05 21:26:34 +00:00
hkdf Remove the func parameter to OPENSSL_PUT_ERROR. 2015-07-16 02:02:37 +00:00
hmac Fix typo in |HMAC_CTX_cleanup|. 2015-07-16 20:38:54 +00:00
lhash Fix some typos in license headers. 2015-07-29 19:23:51 +00:00
md4 Fix integer types in low-level hash functions. 2015-06-01 22:12:21 +00:00
md5 Fix some typos in license headers. 2015-07-29 19:23:51 +00:00
modes Remove BIO dependency from cmac_test. 2015-08-07 01:53:01 +00:00
obj Remove the func parameter to OPENSSL_PUT_ERROR. 2015-07-16 02:02:37 +00:00
pem Remove the func parameter to OPENSSL_PUT_ERROR. 2015-07-16 02:02:37 +00:00
perlasm Emit #if guards for ARM assembly files. 2015-06-23 21:00:32 +00:00
pkcs8 Consistently participate in err for PKCS12_* functions. 2015-08-05 18:53:06 +00:00
poly1305 Fix Windows build. 2015-07-10 19:07:24 +00:00
rand Make methods of |RAND_SSLEay| do reasonable things. 2015-07-23 17:58:51 +00:00
rc4 Convert remaining Latin-1 files to UTF-8. 2015-07-29 19:22:55 +00:00
rsa Improve error checking of some |BN_CTX_get| callers. 2015-08-07 00:50:17 +00:00
sha Convert remaining Latin-1 files to UTF-8. 2015-07-29 19:22:55 +00:00
stack Remove unnecessary NULL checks, part 4. 2015-05-04 23:13:12 +00:00
test Remove BIO dependency from cmac_test. 2015-08-07 01:53:01 +00:00
x509 Reserve ex_data index zero for app_data. 2015-07-20 16:56:34 +00:00
x509v3 Remove the func parameter to OPENSSL_PUT_ERROR. 2015-07-16 02:02:37 +00:00
arm_arch.h aarch64 support. 2015-01-14 23:38:11 +00:00
CMakeLists.txt Replace cpuid assembly with C code. 2015-07-20 18:59:44 +00:00
constant_time_test.c Update constant-time operations. 2014-11-10 13:48:30 -08:00
cpu-arm-asm.S Don't probe for NEON with SIGILL on aarch64. 2015-02-03 19:56:25 +00:00
cpu-arm.c Fix more warnings about old-style prototypes. 2015-08-04 02:09:39 +00:00
cpu-intel.c Surround immintrin.h includes with warning pragmas. 2015-07-20 20:08:26 +00:00
crypto.c Fix |SSLeay|. 2015-05-20 17:44:44 +00:00
directory_posix.c Eliminate unnecessary includes from low-level crypto modules. 2015-04-13 20:49:18 +00:00
directory_win.c Eliminate unnecessary includes from low-level crypto modules. 2015-04-13 20:49:18 +00:00
directory.h Add visibility rules. 2014-07-31 22:03:11 +00:00
ex_data.c Reserve ex_data index zero for app_data. 2015-07-20 16:56:34 +00:00
header_removed.h Add ISC header to a handful of files. 2014-06-26 10:26:42 -07:00
internal.h Reserve ex_data index zero for app_data. 2015-07-20 16:56:34 +00:00
mem.c Fix some typos in license headers. 2015-07-29 19:23:51 +00:00
refcount_c11.c Cast refcounts to _Atomic before use. 2015-05-20 13:39:22 -07:00
refcount_lock.c Add infrastructure for reference counts. 2015-05-20 19:14:59 +00:00
refcount_test.c Specify argc and argv arguments to refcount_test:main. 2015-05-20 13:49:41 -07:00
thread_none.c Support Trusty, an embedded platform. 2015-05-08 18:34:55 +00:00
thread_pthread.c Support Trusty, an embedded platform. 2015-05-08 18:34:55 +00:00
thread_test.c Use the correct case for Windows headers. 2015-06-09 21:38:04 +00:00
thread_win.c Support Trusty, an embedded platform. 2015-05-08 18:34:55 +00:00
thread.c Remove leftovers of the old-style locks. 2015-05-20 19:18:44 +00:00
time_support.c Eliminate unnecessary includes from low-level crypto modules. 2015-04-13 20:49:18 +00:00