boringssl

History

David Benjamin ade291c566 Clean up the DES_key_schedule logic. It's not clear why OpenSSL had a union. The comment says something about sizes of long, since OpenSSL doesn't use stdint.h. But the variable is treated as a bunch of uint32_t's, not DES_cblocks. The key schedule is also always used by iterating or indexing into a uint32_t*, treating the 16 2-word subkeys as a single uint32_t[32]. Instead, index into them properly shush any picky tools. The compiler should be able to figure out what's going on and optimize it appropriately. BUG=517495 Change-Id: I83d0e63ac2c6fb76fac1dceda9f2fd6762074341 Reviewed-on: https://boringssl-review.googlesource.com/5627 Reviewed-by: Adam Langley <agl@google.com>	2015-08-07 01:55:59 +00:00
..
openssl	Clean up the DES_key_schedule logic.	2015-08-07 01:55:59 +00:00

David Benjamin ade291c566 Clean up the DES_key_schedule logic.

It's not clear why OpenSSL had a union. The comment says something about sizes
of long, since OpenSSL doesn't use stdint.h. But the variable is treated as a
bunch of uint32_t's, not DES_cblocks.

The key schedule is also always used by iterating or indexing into a uint32_t*,
treating the 16 2-word subkeys as a single uint32_t[32]. Instead, index into
them properly shush any picky tools. The compiler should be able to figure out
what's going on and optimize it appropriately.

BUG=517495

Change-Id: I83d0e63ac2c6fb76fac1dceda9f2fd6762074341
Reviewed-on: https://boringssl-review.googlesource.com/5627
Reviewed-by: Adam Langley <agl@google.com>

2015-08-07 01:55:59 +00:00

openssl

Clean up the DES_key_schedule logic.

2015-08-07 01:55:59 +00:00