c2e8d016f5
This was also caught by the in-progress unwind tester. There are two issues here. First, .cfi_endproc must come after ret to fully cover the function. More importantly, this function is confused about whether it has a frame pointer or not. It looks like it does (movq %rsp, %rbp), and annotates accordingly, but it does not actually use the frame pointer. It cannot. $y4 is rbp and gets clobbered immediately after the preamble! Remove this instruction and align the CFI annotations with a frame-pointer-less function. Bug: 181 Change-Id: I47b5f9798b3bcee1748e537b21c173d312a14b42 Reviewed-on: https://boringssl-review.googlesource.com/c/33947 Reviewed-by: Adam Langley <agl@google.com> Commit-Queue: David Benjamin <davidben@google.com> |
||
---|---|---|
.. | ||
asm | ||
ec_key.c | ||
ec_montgomery.c | ||
ec_scalar_base_mult_tests.txt | ||
ec_test.cc | ||
ec.c | ||
felem.c | ||
internal.h | ||
make_ec_scalar_base_mult_tests.go | ||
make_p256-x86_64-table.go | ||
make_p256-x86_64-tests.go | ||
oct.c | ||
p224-64.c | ||
p256-x86_64_test.cc | ||
p256-x86_64_tests.txt | ||
p256-x86_64-table.h | ||
p256-x86_64.c | ||
p256-x86_64.h | ||
scalar.c | ||
simple_mul.c | ||
simple.c | ||
util.c | ||
wnaf.c |