ce45588695
C99 added macros such as PRIu64 to inttypes.h, but it said to exclude them from C++ unless __STDC_FORMAT_MACROS or __STDC_CONSTANT_MACROS was defined. This text was never incorporated into any C++ standard and explicitly overruled in C++11. Some libc headers followed C99. Notably, glibc prior to 2.18 (https://sourceware.org/bugzilla/show_bug.cgi?id=15366) and old versions of the Android NDK. In the NDK, although it was fixed some time ago (API level 20), the NDK used to use separate headers per API level. Only applications using minSdkVersion >= 20 would get the fix. Starting NDK r14, "unified" headers are available which, among other things, make the fix available (opt-in) independent of minSdkVersion. In r15, unified headers are opt-out, and in r16 they are mandatory. Try removing these and see if anyone notices. The former is past our five year watermark. The latter is not and Android has hit https://boringssl-review.googlesource.com/c/boringssl/+/32686 before, but unless it is really widespread, it's probably simpler to ask consumers to define __STDC_CONSTANT_MACROS and __STDC_FORMAT_MACROS globally. Update-Note: If you see compile failures relating to PRIu64, UINT64_MAX, and friends, update your glibc or NDK. As a short-term fix, add __STDC_CONSTANT_MACROS and __STDC_FORMAT_MACROS to your build, but get in touch so we have a sense of how widespread it is. Bug: 198 Change-Id: I56cca5f9acdff803de1748254bc45096e4c959c2 Reviewed-on: https://boringssl-review.googlesource.com/c/33146 Reviewed-by: Adam Langley <agl@google.com> Commit-Queue: Adam Langley <agl@google.com> CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> |
||
|---|---|---|
| .. | ||
| runner | ||
| async_bio.cc | ||
| async_bio.h | ||
| bssl_shim.cc | ||
| CMakeLists.txt | ||
| fuzzer_tags.h | ||
| fuzzer.h | ||
| handshake_util.cc | ||
| handshake_util.h | ||
| handshaker.cc | ||
| packeted_bio.cc | ||
| packeted_bio.h | ||
| PORTING.md | ||
| README.md | ||
| settings_writer.cc | ||
| settings_writer.h | ||
| test_config.cc | ||
| test_config.h | ||
| test_state.cc | ||
| test_state.h | ||
BoringSSL SSL Tests
This directory contains BoringSSL's protocol-level test suite.
Testing a TLS implementation can be difficult. We need to produce invalid but sufficiently correct handshakes to get our implementation close to its edge cases. TLS's cryptographic steps mean we cannot use a transcript and effectively need a TLS implementation on the other end. But we do not wish to litter BoringSSL with options for bugs to test against.
Instead, we use a fork of the Go crypto/tls package, heavily patched with
configurable bugs. This code, along with a test suite and harness written in Go,
lives in the runner directory. The harness runs BoringSSL via a C/C++ shim
binary which lives in this directory. All communication with the shim binary
occurs with command-line flags, sockets, and standard I/O.
This strategy also ensures we always test against a second implementation. All features should be implemented twice, once in C for BoringSSL and once in Go for testing. If possible, the Go code should be suitable for potentially upstreaming. However, sometimes test code has different needs. For example, our test DTLS code enforces strict ordering on sequence numbers and has controlled packet drop simulation.
To run the tests manually, run go test from the runner directory. It takes
command-line flags found at the top of runner/runner.go. The -help option
also works after using go test -c to make a runner.test binary first.
If adding a new test, these files may be a good starting point:
runner/runner.go: the test harness and all the individual tests.runner/common.go: contains theConfigandProtocolBugsstruct which control the Go TLS implementation's behavior.test_config.h,test_config.cc: the command-line flags which control the shim's behavior.bssl_shim.cc: the shim binary itself.
For porting the test suite to a different implementation see PORTING.md.