d62fe6f3e8
EC_KEY_copy left unset fields alone, which meant it was possible to create an EC_KEY with mismatched private key and group. Nothing was using EC_KEY_copy anyway, and in keeping of us generally preferring fresh objects over object reuse, remove it. EC_KEY_dup itself can also be made simpler by using the very setters available. Additionally, skip copying the method table. As of https://boringssl-review.googlesource.com/16344, we no longer copy the ex_data, so we probably shouldn't copy the method pointers either, aligning with RSAPrivateKey_dup. Update-Note: If I missed anything and someone uses EC_KEY_copy, it should be easy to port them to EC_KEY_dup. Change-Id: Ibbdcea73345d91fa143fbe70a15bb527972693e8 Reviewed-on: https://boringssl-review.googlesource.com/26404 Reviewed-by: Steven Valdez <svaldez@google.com> Commit-Queue: David Benjamin <davidben@google.com> CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> |
||
|---|---|---|
| .. | ||
| openssl | ||