Go to file
David Benjamin f3a8b12ac3 Remove SSL_SESSION::cipher_id.
As of our 82b7da271f, an SSL_SESSION created
externally always has a cipher set. Unknown ciphers are rejected early. Prior
to that, an SSL_SESSION would only have a valid cipher or valid cipher_id
depending on whether it came from an internal or external session cache.

See upstream's 6a8afe2201cd888e472e44225d3c9ca5fae1ca62 and
c566205319beeaa196e247400c7eb0c16388372b for more context.

Since we don't get ourselves into this strange situation and s->cipher is now
always valid for established SSL_SESSION objects (the existence of
unestablished SSL_SESSION objects during a handshake is awkward, but something
to deal with later), do away with s->cipher_id altogether. An application
should be able to handle failing to parse an SSL_SESSION instead of parsing it
successfuly but rejecting all resumptions.

Change-Id: I2f064a815e0db657b109c7c9269ac6c726d1ffed
Reviewed-on: https://boringssl-review.googlesource.com/2703
Reviewed-by: Adam Langley <agl@google.com>
2015-01-14 21:10:55 +00:00
crypto Add tests for padding variations. 2015-01-14 21:09:16 +00:00
doc
include/openssl Remove SSL_SESSION::cipher_id. 2015-01-14 21:10:55 +00:00
ssl Remove SSL_SESSION::cipher_id. 2015-01-14 21:10:55 +00:00
tool Add the ability to run a server from the command line tool. 2014-12-11 10:47:21 -08:00
util Implement SSLv3 ciphers with stateful AEADs. 2015-01-14 20:55:58 +00:00
.clang-format
.gitignore
BUILDING Build with yasm on Win64 as well. 2014-10-31 22:02:45 +00:00
CMakeLists.txt Remove -std=c89 from compiler command line. 2015-01-12 23:45:34 +00:00
codereview.settings Add a codereview.settings file. 2014-11-18 22:21:33 +00:00