boringssl/crypto/fipsmodule/ec
David Benjamin dd935202c9 Zero-initialize tmp in ec_GFp_simple_mul_single.
Although the original value of tmp does not matter, the selects
ultimately do bit operations on the uninitialized values and thus depend
on them behaving like *some* consistent concrete value. The C spec
appears to allow uninitialized values to resolve to trap
representations, which means this isn't quite valid..

(If I'm reading it wrong and the compiler must behave as if there were a
consistent value in there, it's probably fine, but there's no sense in
risking compiler bugs on a subtle corner of things.)

Change-Id: Id4547b0ec702414b387e906c4de55595e6214ddb
Reviewed-on: https://boringssl-review.googlesource.com/29124
Commit-Queue: Steven Valdez <svaldez@google.com>
Reviewed-by: Steven Valdez <svaldez@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
2018-06-13 19:58:24 +00:00
..
asm Enable ADX assembly. 2018-05-11 21:57:13 +00:00
ec_key.c Store EC_KEY's private key as an EC_SCALAR. 2018-03-07 21:17:31 +00:00
ec_montgomery.c Implement constant-time generic multiplication. 2018-04-27 20:11:29 +00:00
ec_scalar_base_mult_tests.txt Add some EC base point multiplication test vectors. 2018-03-27 23:33:24 +00:00
ec_test.cc Add test coverage for the a != -3 case. 2018-04-02 18:25:08 +00:00
ec.c More compatibility stuff. 2018-05-15 23:57:53 +00:00
felem.c Add missing #include of <openssl/err.h>. 2018-05-01 01:00:44 +00:00
internal.h Implement constant-time generic multiplication. 2018-04-27 20:11:29 +00:00
make_ec_scalar_base_mult_tests.go Add some EC base point multiplication test vectors. 2018-03-27 23:33:24 +00:00
make_p256-x86_64-table.go Add utility program for emitting P-256 x86-64 table. 2018-03-26 16:28:42 +00:00
oct.c Name constant-time functions more consistently. 2018-03-29 23:30:55 +00:00
p224-64.c Clear mallocs in ec_wNAF_mul. 2018-04-27 19:44:58 +00:00
p256-x86_64_test.cc Add some tests for scalar operations. 2018-04-24 16:12:34 +00:00
p256-x86_64_tests.txt Add some tests for scalar operations. 2018-04-24 16:12:34 +00:00
p256-x86_64-table.h Add utility program for emitting P-256 x86-64 table. 2018-03-26 16:28:42 +00:00
p256-x86_64.c Clear mallocs in ec_wNAF_mul. 2018-04-27 19:44:58 +00:00
p256-x86_64.h Add some tests for scalar operations. 2018-04-24 16:12:34 +00:00
scalar.c Add missing #include of <openssl/mem.h>. 2018-05-04 16:51:04 +00:00
simple_mul.c Zero-initialize tmp in ec_GFp_simple_mul_single. 2018-06-13 19:58:24 +00:00
simple.c Implement constant-time generic multiplication. 2018-04-27 20:11:29 +00:00
util.c
wnaf.c Implement constant-time generic multiplication. 2018-04-27 20:11:29 +00:00