kris/pqc
1
1
Fork 0
Code Issues Pull Requests Releases Wiki Activity
4f19ea25d0
pqc/crypto_sign/sphincs-shake256-128f-robust/clean/hash_state.h

8 lines
81 B
C
Raw Normal View History

Eliminate the global state This PR sacrifices passing some extra arguments to get rid of the global state. * Haraka needs state in all hash calls, this results in changes to the hash functions specified in `hash.h`. The extra pointers passed would not be necessary for SHA256 or SHAKE256. * SHAKE256 did not have global state, but uniformity in the implementations requires us to pass around the new state context anyway. Otherwise, @joostrijneveld's SPHINCS+ generator doesn't really work anymore). We introduce a new header file called `primitive.h` which defines the required state type for the generic functions. I did not go into replacing _all_ occurrences of state variables by the new `hash_state` macro.
2019-06-21 13:34:36 +01:00
#ifndef SPX_PRIMITIVE_H
#define SPX_PRIMITIVE_H
Remove const This was causing compilation failures with clang, that there were duplicate const keywords once the macro was expanded in hash.h
2019-07-17 01:22:45 +01:00
#define hash_state int
Eliminate the global state This PR sacrifices passing some extra arguments to get rid of the global state. * Haraka needs state in all hash calls, this results in changes to the hash functions specified in `hash.h`. The extra pointers passed would not be necessary for SHA256 or SHAKE256. * SHAKE256 did not have global state, but uniformity in the implementations requires us to pass around the new state context anyway. Otherwise, @joostrijneveld's SPHINCS+ generator doesn't really work anymore). We introduce a new header file called `primitive.h` which defines the required state type for the generic functions. I did not go into replacing _all_ occurrences of state variables by the new `hash_state` macro.
2019-06-21 13:34:36 +01:00
#endif
Reference in New Issue Copy Permalink