kris/pqc
1
1
Vork 0
Code Kwesties Pull-aanvragen Publicaties Wiki Activiteit

Don't fail if decapsulating with wrong keys doesn't return -1

Bladeren bron 
Closes #11
This commit is contained in:
Thom Wiggers 2019-01-29 16:05:44 +01:00
bovenliggende 31449679bd
commit 37be4a2044
Geen bekende sleutel gevonden voor deze handtekening in de database
GPG sleutel-ID: 001BB0A7CE26E363
2 gewijzigde bestanden met toevoegingen van 3 en 3 verwijderingen
Statistieken weergeven Download Patch-bestand Download Diff-bestand Expand all files Collapse all files

2
README.md
Bestand weergeven

@ -42,7 +42,7 @@ _The checking of items on this list is still being developed. Checked items shou
* [x] `randombytes.c`
* [ ] API functions return `0` on success, negative on failure
* [x] 0 on success
* [ ] Negative on failure (currently: partially)
* [ ] Negative on failure (within restrictions of FO transform).
* [ ] No dynamic memory allocations
* [ ] No branching on secret data (dynamically checked using valgrind)
* [ ] No access to secret memory locations (dynamically checked using valgrind)

4
test/crypto_kem/functest.c
Bestand weergeven

@ -137,8 +137,8 @@ static int test_invalid_ciphertext(void) {
sendb[pos % CRYPTO_CIPHERTEXTBYTES] ^= 23;
// Alice uses Bobs response to get her secret key
if ((returncode = crypto_kem_dec(key_a, sendb, sk_a)) > -1) {
printf("ERROR crypto_kem_dec should fail (negative returncode) but returned %d\n", returncode);
if ((returncode = crypto_kem_dec(key_a, sendb, sk_a)) > 0) {
printf("ERROR crypto_kem_dec should either fail (negative returncode) or succeed (return 0) but returned %d\n", returncode);
return -1;
}