kris/pqc
1
1
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Move #if check from manual to automatic

Browse Source
This commit is contained in:
Joost Rijneveld 2019-04-09 16:56:11 +02:00
parent dfe9508551
commit 56e8d17a7d
No known key found for this signature in database
GPG Key ID: A4FE39CF49CBC553
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.github/pull_request_template.md vendored
View File

@ -6,7 +6,6 @@
#### Manually checked properties #### Manually checked properties
<!-- These checkboxes serve for the maintainers of PQClean to verify your submission. Please do not check them yourself. --> <!-- These checkboxes serve for the maintainers of PQClean to verify your submission. Please do not check them yourself. -->
* [ ] `#if`/`#ifdef`s only for header encapsulation
* [ ] No stringification macros * [ ] No stringification macros
* [ ] Output-parameter pointers in functions are on the left * [ ] Output-parameter pointers in functions are on the left
* [ ] Negative return values on failure of API functions (within restrictions of FO transform). * [ ] Negative return values on failure of API functions (within restrictions of FO transform).

2
README.md
View File

@ -36,6 +36,7 @@ _The checking of items on this list is still being developed. Checked items shou
* [x] API functions do not write outside provided buffers * [x] API functions do not write outside provided buffers
* [x] `api.h` cannot include external files * [x] `api.h` cannot include external files
* [x] Compiles with `-Wall -Wextra -Wpedantic -Werror` with `gcc` and `clang` * [x] Compiles with `-Wall -Wextra -Wpedantic -Werror` with `gcc` and `clang`
* [x] `#if`/`#ifdef`s only for header encapsulation
* [x] Consistent test vectors across runs * [x] Consistent test vectors across runs
* [x] Consistent test vectors on big-endian and little-endian machines * [x] Consistent test vectors on big-endian and little-endian machines
* [x] Consistent test vectors on 32-bit and 64-bit machines * [x] Consistent test vectors on 32-bit and 64-bit machines
@ -66,7 +67,6 @@ _The checking of items on this list is still being developed. Checked items shou
## Requirements on C implementations that are manually checked ## Requirements on C implementations that are manually checked
* Minimalist Makefiles * Minimalist Makefiles
* `#if`/`#ifdef`s only for header encapsulation
* No stringification macros * No stringification macros
* Output-parameter pointers in functions are on the left * Output-parameter pointers in functions are on the left
* `const` arguments are labeled as `const` * `const` arguments are labeled as `const`