kris/pqc
1
1
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Update PR template along practice (#254)

Browse Source 
* remove automatically checked property

* Allow PR-submitters to self-document.

We don't ever use these, so allow submitters of PRs to self-document.
This commit is contained in:
Thom Wiggers 2019-12-12 13:38:34 +01:00 committed by Kris Kwiatkowski
parent a4e31f16a2
commit 784973a8fb
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/pull_request_template.md vendored
View File

@ -4,12 +4,10 @@
<!-- If you are not submitting a new scheme, we suggest removing the following lines --> <!-- If you are not submitting a new scheme, we suggest removing the following lines -->
#### Manually checked properties #### Manually checked properties
<!-- These checkboxes serve for the maintainers of PQClean to verify your submission. Please do not check them yourself. -->
* [ ] No stringification macros * [ ] No stringification macros
* [ ] Output-parameter pointers in functions are on the left * [ ] Output-parameter pointers in functions are on the left
* [ ] Negative return values on failure of API functions (within restrictions of FO transform). * [ ] Negative return values on failure of API functions (within restrictions of FO transform).
* [ ] `const` arguments are labeled as `const`
* [ ] variable declarations at the beginning (except in `for (size_t i=...`) * [ ] variable declarations at the beginning (except in `for (size_t i=...`)
* Optional: * Optional:
* [ ] All integer types are of fixed size, using `stdint.h` types (including `uint8_t` instead of `unsigned char`) * [ ] All integer types are of fixed size, using `stdint.h` types (including `uint8_t` instead of `unsigned char`)