kris/pqc
1
1
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge pull request #240 from PQClean/clang9.0.0

Browse Source 
Fix Clang 9.0.0 warnings
This commit is contained in:
Thom Wiggers 2019-10-30 14:06:56 +01:00 committed by GitHub
commit c8347a0866
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
20 changed files with 20 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.clang-tidy
View File

@ -1,5 +1,5 @@
--- ---
Checks: '*,-llvm-header-guard,-hicpp-*,-readability-function-size,-google-readability-todo,-readability-magic-numbers,-cppcoreguidelines-avoid-magic-numbers,-readability-isolate-declaration,-readability-uppercase-literal-suffix' Checks: '*,-llvm-header-guard,-hicpp-*,-readability-function-size,-google-readability-todo,-readability-magic-numbers,-cppcoreguidelines-avoid-magic-numbers,-readability-isolate-declaration,-readability-uppercase-literal-suffix,-clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling'
WarningsAsErrors: '*' WarningsAsErrors: '*'
HeaderFilterRegex: '.*' HeaderFilterRegex: '.*'
AnalyzeTemporaryDtors: false AnalyzeTemporaryDtors: false

6
crypto_kem/kyber768/avx2/indcpa.c
View File

@ -199,11 +199,7 @@ static void gen_matrix(polyvec *a, const uint8_t *seed, int transposed) {
PQCLEAN_KYBER768_AVX2_poly_nttunpack(&a[2].vec[0]); PQCLEAN_KYBER768_AVX2_poly_nttunpack(&a[2].vec[0]);
PQCLEAN_KYBER768_AVX2_poly_nttunpack(&a[2].vec[1]); PQCLEAN_KYBER768_AVX2_poly_nttunpack(&a[2].vec[1]);
if (transposed) { PQCLEAN_KYBER768_AVX2_kyber_shake128_absorb(&state1x, seed, 2, 2);
PQCLEAN_KYBER768_AVX2_kyber_shake128_absorb(&state1x, seed, 2, 2);
} else {
PQCLEAN_KYBER768_AVX2_kyber_shake128_absorb(&state1x, seed, 2, 2);
}
PQCLEAN_KYBER768_AVX2_kyber_shake128_squeezeblocks(buf.x[0], GEN_MATRIX_MAXNBLOCKS, &state1x); PQCLEAN_KYBER768_AVX2_kyber_shake128_squeezeblocks(buf.x[0], GEN_MATRIX_MAXNBLOCKS, &state1x);
bufbytes = GEN_MATRIX_MAXNBLOCKS * XOF_BLOCKBYTES; bufbytes = GEN_MATRIX_MAXNBLOCKS * XOF_BLOCKBYTES;

2
crypto_sign/rainbowIIIc-classic/clean/rainbow.c
View File

@ -15,8 +15,6 @@
#include <string.h> #include <string.h>
#define MAX_ATTEMPT_FRMAT 128 #define MAX_ATTEMPT_FRMAT 128
#define _MAX_O ((_O1 > _O2) ? _O1 : _O2)
#define _MAX_O_BYTE ((_O1_BYTE > _O2_BYTE) ? _O1_BYTE : _O2_BYTE)
int PQCLEAN_RAINBOWIIICCLASSIC_CLEAN_rainbow_sign(uint8_t *signature, const sk_t *sk, const uint8_t *_digest) { int PQCLEAN_RAINBOWIIICCLASSIC_CLEAN_rainbow_sign(uint8_t *signature, const sk_t *sk, const uint8_t *_digest) {
uint8_t mat_l1[_O1 * _O1_BYTE]; uint8_t mat_l1[_O1 * _O1_BYTE];

2
crypto_sign/rainbowIIIc-classic/clean/rainbow_config.h
View File

@ -9,6 +9,7 @@
#define _V1 68 #define _V1 68
#define _O1 36 #define _O1 36
#define _O2 36 #define _O2 36
#define _MAX_O 36
#define _HASH_LEN 48 #define _HASH_LEN 48
@ -27,6 +28,7 @@
#define _V2_BYTE (_V2) #define _V2_BYTE (_V2)
#define _O1_BYTE (_O1) #define _O1_BYTE (_O1)
#define _O2_BYTE (_O2) #define _O2_BYTE (_O2)
#define _MAX_O_BYTE (_MAX_O)
#define _PUB_N_BYTE (_PUB_N) #define _PUB_N_BYTE (_PUB_N)
#define _PUB_M_BYTE (_PUB_M) #define _PUB_M_BYTE (_PUB_M)

2
crypto_sign/rainbowIIIc-cyclic-compressed/clean/rainbow.c
View File

@ -15,8 +15,6 @@
#include <string.h> #include <string.h>
#define MAX_ATTEMPT_FRMAT 128 #define MAX_ATTEMPT_FRMAT 128
#define _MAX_O ((_O1 > _O2) ? _O1 : _O2)
#define _MAX_O_BYTE ((_O1_BYTE > _O2_BYTE) ? _O1_BYTE : _O2_BYTE)
int PQCLEAN_RAINBOWIIICCYCLICCOMPRESSED_CLEAN_rainbow_sign(uint8_t *signature, const sk_t *sk, const uint8_t *_digest) { int PQCLEAN_RAINBOWIIICCYCLICCOMPRESSED_CLEAN_rainbow_sign(uint8_t *signature, const sk_t *sk, const uint8_t *_digest) {
uint8_t mat_l1[_O1 * _O1_BYTE]; uint8_t mat_l1[_O1 * _O1_BYTE];

2
crypto_sign/rainbowIIIc-cyclic-compressed/clean/rainbow_config.h
View File

@ -9,6 +9,7 @@
#define _V1 68 #define _V1 68
#define _O1 36 #define _O1 36
#define _O2 36 #define _O2 36
#define _MAX_O 36
#define _HASH_LEN 48 #define _HASH_LEN 48
@ -27,6 +28,7 @@
#define _V2_BYTE (_V2) #define _V2_BYTE (_V2)
#define _O1_BYTE (_O1) #define _O1_BYTE (_O1)
#define _O2_BYTE (_O2) #define _O2_BYTE (_O2)
#define _MAX_O_BYTE (_MAX_O)
#define _PUB_N_BYTE (_PUB_N) #define _PUB_N_BYTE (_PUB_N)
#define _PUB_M_BYTE (_PUB_M) #define _PUB_M_BYTE (_PUB_M)

2
crypto_sign/rainbowIIIc-cyclic/clean/rainbow.c
View File

@ -15,8 +15,6 @@
#include <string.h> #include <string.h>
#define MAX_ATTEMPT_FRMAT 128 #define MAX_ATTEMPT_FRMAT 128
#define _MAX_O ((_O1 > _O2) ? _O1 : _O2)
#define _MAX_O_BYTE ((_O1_BYTE > _O2_BYTE) ? _O1_BYTE : _O2_BYTE)
int PQCLEAN_RAINBOWIIICCYCLIC_CLEAN_rainbow_sign(uint8_t *signature, const sk_t *sk, const uint8_t *_digest) { int PQCLEAN_RAINBOWIIICCYCLIC_CLEAN_rainbow_sign(uint8_t *signature, const sk_t *sk, const uint8_t *_digest) {
uint8_t mat_l1[_O1 * _O1_BYTE]; uint8_t mat_l1[_O1 * _O1_BYTE];

2
crypto_sign/rainbowIIIc-cyclic/clean/rainbow_config.h
View File

@ -9,6 +9,7 @@
#define _V1 68 #define _V1 68
#define _O1 36 #define _O1 36
#define _O2 36 #define _O2 36
#define _MAX_O 36
#define _HASH_LEN 48 #define _HASH_LEN 48
@ -27,6 +28,7 @@
#define _V2_BYTE (_V2) #define _V2_BYTE (_V2)
#define _O1_BYTE (_O1) #define _O1_BYTE (_O1)
#define _O2_BYTE (_O2) #define _O2_BYTE (_O2)
#define _MAX_O_BYTE (_MAX_O)
#define _PUB_N_BYTE (_PUB_N) #define _PUB_N_BYTE (_PUB_N)
#define _PUB_M_BYTE (_PUB_M) #define _PUB_M_BYTE (_PUB_M)

2
crypto_sign/rainbowIa-classic/clean/rainbow.c
View File

@ -15,8 +15,6 @@
#include <string.h> #include <string.h>
#define MAX_ATTEMPT_FRMAT 128 #define MAX_ATTEMPT_FRMAT 128
#define _MAX_O ((_O1 > _O2) ? _O1 : _O2)
#define _MAX_O_BYTE ((_O1_BYTE > _O2_BYTE) ? _O1_BYTE : _O2_BYTE)
int PQCLEAN_RAINBOWIACLASSIC_CLEAN_rainbow_sign(uint8_t *signature, const sk_t *sk, const uint8_t *_digest) { int PQCLEAN_RAINBOWIACLASSIC_CLEAN_rainbow_sign(uint8_t *signature, const sk_t *sk, const uint8_t *_digest) {
uint8_t mat_l1[_O1 * _O1_BYTE]; uint8_t mat_l1[_O1 * _O1_BYTE];

2
crypto_sign/rainbowIa-classic/clean/rainbow_config.h
View File

@ -10,6 +10,7 @@
#define _V1 32 #define _V1 32
#define _O1 32 #define _O1 32
#define _O2 32 #define _O2 32
#define _MAX_O 32
#define _HASH_LEN 32 #define _HASH_LEN 32
@ -28,6 +29,7 @@
#define _V2_BYTE (_V2 / 2) #define _V2_BYTE (_V2 / 2)
#define _O1_BYTE (_O1 / 2) #define _O1_BYTE (_O1 / 2)
#define _O2_BYTE (_O2 / 2) #define _O2_BYTE (_O2 / 2)
#define _MAX_O_BYTE (_MAX_O / 2)
#define _PUB_N_BYTE (_PUB_N / 2) #define _PUB_N_BYTE (_PUB_N / 2)
#define _PUB_M_BYTE (_PUB_M / 2) #define _PUB_M_BYTE (_PUB_M / 2)

2
crypto_sign/rainbowIa-cyclic-compressed/clean/rainbow.c
View File

@ -15,8 +15,6 @@
#include <string.h> #include <string.h>
#define MAX_ATTEMPT_FRMAT 128 #define MAX_ATTEMPT_FRMAT 128
#define _MAX_O ((_O1 > _O2) ? _O1 : _O2)
#define _MAX_O_BYTE ((_O1_BYTE > _O2_BYTE) ? _O1_BYTE : _O2_BYTE)
int PQCLEAN_RAINBOWIACYCLICCOMPRESSED_CLEAN_rainbow_sign(uint8_t *signature, const sk_t *sk, const uint8_t *_digest) { int PQCLEAN_RAINBOWIACYCLICCOMPRESSED_CLEAN_rainbow_sign(uint8_t *signature, const sk_t *sk, const uint8_t *_digest) {
uint8_t mat_l1[_O1 * _O1_BYTE]; uint8_t mat_l1[_O1 * _O1_BYTE];

2
crypto_sign/rainbowIa-cyclic-compressed/clean/rainbow_config.h
View File

@ -10,6 +10,7 @@
#define _V1 32 #define _V1 32
#define _O1 32 #define _O1 32
#define _O2 32 #define _O2 32
#define _MAX_O 32
#define _HASH_LEN 32 #define _HASH_LEN 32
@ -28,6 +29,7 @@
#define _V2_BYTE (_V2 / 2) #define _V2_BYTE (_V2 / 2)
#define _O1_BYTE (_O1 / 2) #define _O1_BYTE (_O1 / 2)
#define _O2_BYTE (_O2 / 2) #define _O2_BYTE (_O2 / 2)
#define _MAX_O_BYTE (_MAX_O / 2)
#define _PUB_N_BYTE (_PUB_N / 2) #define _PUB_N_BYTE (_PUB_N / 2)
#define _PUB_M_BYTE (_PUB_M / 2) #define _PUB_M_BYTE (_PUB_M / 2)

2
crypto_sign/rainbowIa-cyclic/clean/rainbow.c
View File

@ -15,8 +15,6 @@
#include <string.h> #include <string.h>
#define MAX_ATTEMPT_FRMAT 128 #define MAX_ATTEMPT_FRMAT 128
#define _MAX_O ((_O1 > _O2) ? _O1 : _O2)
#define _MAX_O_BYTE ((_O1_BYTE > _O2_BYTE) ? _O1_BYTE : _O2_BYTE)
int PQCLEAN_RAINBOWIACYCLIC_CLEAN_rainbow_sign(uint8_t *signature, const sk_t *sk, const uint8_t *_digest) { int PQCLEAN_RAINBOWIACYCLIC_CLEAN_rainbow_sign(uint8_t *signature, const sk_t *sk, const uint8_t *_digest) {
uint8_t mat_l1[_O1 * _O1_BYTE]; uint8_t mat_l1[_O1 * _O1_BYTE];

2
crypto_sign/rainbowIa-cyclic/clean/rainbow_config.h
View File

@ -10,6 +10,7 @@
#define _V1 32 #define _V1 32
#define _O1 32 #define _O1 32
#define _O2 32 #define _O2 32
#define _MAX_O 32
#define _HASH_LEN 32 #define _HASH_LEN 32
@ -28,6 +29,7 @@
#define _V2_BYTE (_V2 / 2) #define _V2_BYTE (_V2 / 2)
#define _O1_BYTE (_O1 / 2) #define _O1_BYTE (_O1 / 2)
#define _O2_BYTE (_O2 / 2) #define _O2_BYTE (_O2 / 2)
#define _MAX_O_BYTE (_MAX_O / 2)
#define _PUB_N_BYTE (_PUB_N / 2) #define _PUB_N_BYTE (_PUB_N / 2)
#define _PUB_M_BYTE (_PUB_M / 2) #define _PUB_M_BYTE (_PUB_M / 2)

2
crypto_sign/rainbowVc-classic/clean/rainbow.c
View File

@ -15,8 +15,6 @@
#include <string.h> #include <string.h>
#define MAX_ATTEMPT_FRMAT 128 #define MAX_ATTEMPT_FRMAT 128
#define _MAX_O ((_O1 > _O2) ? _O1 : _O2)
#define _MAX_O_BYTE ((_O1_BYTE > _O2_BYTE) ? _O1_BYTE : _O2_BYTE)
int PQCLEAN_RAINBOWVCCLASSIC_CLEAN_rainbow_sign(uint8_t *signature, const sk_t *sk, const uint8_t *_digest) { int PQCLEAN_RAINBOWVCCLASSIC_CLEAN_rainbow_sign(uint8_t *signature, const sk_t *sk, const uint8_t *_digest) {
uint8_t mat_l1[_O1 * _O1_BYTE]; uint8_t mat_l1[_O1 * _O1_BYTE];

2
crypto_sign/rainbowVc-classic/clean/rainbow_config.h
View File

@ -9,6 +9,7 @@
#define _V1 92 #define _V1 92
#define _O1 48 #define _O1 48
#define _O2 48 #define _O2 48
#define _MAX_O 48
#define _HASH_LEN 64 #define _HASH_LEN 64
@ -27,6 +28,7 @@
#define _V2_BYTE (_V2) #define _V2_BYTE (_V2)
#define _O1_BYTE (_O1) #define _O1_BYTE (_O1)
#define _O2_BYTE (_O2) #define _O2_BYTE (_O2)
#define _MAX_O_BYTE (_MAX_O)
#define _PUB_N_BYTE (_PUB_N) #define _PUB_N_BYTE (_PUB_N)
#define _PUB_M_BYTE (_PUB_M) #define _PUB_M_BYTE (_PUB_M)

2
crypto_sign/rainbowVc-cyclic-compressed/clean/rainbow.c
View File

@ -15,8 +15,6 @@
#include <string.h> #include <string.h>
#define MAX_ATTEMPT_FRMAT 128 #define MAX_ATTEMPT_FRMAT 128
#define _MAX_O ((_O1 > _O2) ? _O1 : _O2)
#define _MAX_O_BYTE ((_O1_BYTE > _O2_BYTE) ? _O1_BYTE : _O2_BYTE)
int PQCLEAN_RAINBOWVCCYCLICCOMPRESSED_CLEAN_rainbow_sign(uint8_t *signature, const sk_t *sk, const uint8_t *_digest) { int PQCLEAN_RAINBOWVCCYCLICCOMPRESSED_CLEAN_rainbow_sign(uint8_t *signature, const sk_t *sk, const uint8_t *_digest) {
uint8_t mat_l1[_O1 * _O1_BYTE]; uint8_t mat_l1[_O1 * _O1_BYTE];

2
crypto_sign/rainbowVc-cyclic-compressed/clean/rainbow_config.h
View File

@ -9,6 +9,7 @@
#define _V1 92 #define _V1 92
#define _O1 48 #define _O1 48
#define _O2 48 #define _O2 48
#define _MAX_O 48
#define _HASH_LEN 64 #define _HASH_LEN 64
@ -27,6 +28,7 @@
#define _V2_BYTE (_V2) #define _V2_BYTE (_V2)
#define _O1_BYTE (_O1) #define _O1_BYTE (_O1)
#define _O2_BYTE (_O2) #define _O2_BYTE (_O2)
#define _MAX_O_BYTE (_MAX_O)
#define _PUB_N_BYTE (_PUB_N) #define _PUB_N_BYTE (_PUB_N)
#define _PUB_M_BYTE (_PUB_M) #define _PUB_M_BYTE (_PUB_M)

2
crypto_sign/rainbowVc-cyclic/clean/rainbow.c
View File

@ -15,8 +15,6 @@
#include <string.h> #include <string.h>
#define MAX_ATTEMPT_FRMAT 128 #define MAX_ATTEMPT_FRMAT 128
#define _MAX_O ((_O1 > _O2) ? _O1 : _O2)
#define _MAX_O_BYTE ((_O1_BYTE > _O2_BYTE) ? _O1_BYTE : _O2_BYTE)
int PQCLEAN_RAINBOWVCCYCLIC_CLEAN_rainbow_sign(uint8_t *signature, const sk_t *sk, const uint8_t *_digest) { int PQCLEAN_RAINBOWVCCYCLIC_CLEAN_rainbow_sign(uint8_t *signature, const sk_t *sk, const uint8_t *_digest) {
uint8_t mat_l1[_O1 * _O1_BYTE]; uint8_t mat_l1[_O1 * _O1_BYTE];

2
crypto_sign/rainbowVc-cyclic/clean/rainbow_config.h
View File

@ -9,6 +9,7 @@
#define _V1 92 #define _V1 92
#define _O1 48 #define _O1 48
#define _O2 48 #define _O2 48
#define _MAX_O 48
#define _HASH_LEN 64 #define _HASH_LEN 64
@ -27,6 +28,7 @@
#define _V2_BYTE (_V2) #define _V2_BYTE (_V2)
#define _O1_BYTE (_O1) #define _O1_BYTE (_O1)
#define _O2_BYTE (_O2) #define _O2_BYTE (_O2)
#define _MAX_O_BYTE (_MAX_O)
#define _PUB_N_BYTE (_PUB_N) #define _PUB_N_BYTE (_PUB_N)
#define _PUB_M_BYTE (_PUB_M) #define _PUB_M_BYTE (_PUB_M)