Commit Graph

28 Commits

Author SHA1 Message Date
Matthias J. Kannwischer
3d7d2024fa
FrodoKEM: Fix bug in the output of the ct_verify function (#367)
* Fix bug in the output of the ct_verify function

A bug in the CCA transformation was reported on the pqc-forum on 2020-12-10
https://groups.google.com/a/list.nist.gov/g/pqc-forum/c/kSUKzDNc5ME

It was fixed today in 669522db63.
This commit ports that fix to PQClean

* add note to SECURITY.md

* update upstream commit in META.yml
2020-12-14 10:39:10 -05:00
Thom Wiggers
cdd11413f3
Fix missed overflowing mul in FrodoKEM
It happened in another place
2020-11-24 11:50:33 +01:00
Thom Wiggers
6d0684df63
Fix more overflowing muls in Frodo 2020-11-19 07:48:32 +01:00
John M. Schanck
9064186cdb astyle 2020-09-17 07:19:31 -04:00
John M. Schanck
a59cf4cba7 frodo: satisfy test_boolean 2020-09-17 07:19:31 -04:00
Douglas Stebila
ae1530d192 Fix timing leak in decapsulation.
As identified in: Qian Guo, Thomas Johansson, Alexander Nilsson. A 
key-recovery timing attack on post-quantum primitives using the 
Fujisaki-Okamoto transformation and its application on FrodoKEM. In 
CRYPTO 2020.

Based on 
155c24c3df
2020-06-19 13:15:13 -04:00
Thom Wiggers
35e4b0faa1
fixup! Fix uint8_t to uint16_t upcast in Frodo 2020-03-13 16:30:01 -04:00
Thom Wiggers
5436ec0476
Fix uint8_t to uint16_t upcast in Frodo 2020-03-13 15:58:15 -04:00
Thom Wiggers
f792b925b4 Enable optimizers on Windows (#244) 2019-10-21 14:23:59 +02:00
Thom Wiggers
2108bdcdb5
Make a static global explicitly const 2019-07-18 13:42:37 +02:00
Thom Wiggers
199adb8072
Add -Wredundant-decls 2019-05-20 16:12:01 +02:00
Douglas Stebila
3494c96e53
Update to latest changes from upstream, fix correctness on MS Visual Studio (#163) 2019-05-05 18:33:34 -04:00
Joost Rijneveld
68b12866ce
Use more standard Wvla 2019-04-24 13:52:02 +02:00
Joost Rijneveld
e32666a0ab
Throw errors when using variable-length arrays
Windows already complains about this in CI, but this will
let us catch these issues on Linux as well.
2019-04-24 12:35:17 +02:00
Thom Wiggers
b5d4e93478
Add -O3 to CFLAGS 2019-04-17 11:56:16 +02:00
Thom Wiggers
eb5f7f1e57
Fix int/size_t comparison in frodo 2019-04-16 13:37:50 +02:00
Matthias J. Kannwischer
5587cdb4a8 Add -Wmissing-prototypes (#109)
* fix prototypes for sphincs and static functions in aes.c

* fix missing prototypes in all frodo variants

* fix missing prototypes in kyber

* remove const from non-pointer arguments in Frodo

* add missing prototypes to requirements in README
2019-04-13 11:47:29 -04:00
Douglas Stebila
cfc9705751 test_format wasn't actually checking output of astyle
It was only checking the return code, but astyle was always returning 0. 
Changed to parse the output and look for the string "Formatted"
2019-04-10 21:23:33 -04:00
Douglas Stebila
4162be0401 Switch for int and unsigned char to size_to and uint8_t 2019-04-02 14:06:06 -04:00
Douglas Stebila
41bc57689c Fix more compiler warnings 2019-03-31 21:55:55 -04:00
Douglas Stebila
1e5e9d96f8 Fix compiler warnings and bug 2019-03-31 21:52:35 -04:00
Douglas Stebila
9cb1c56ac1 Make Frodo code endian-agnostic 2019-03-31 21:44:36 -04:00
Douglas Stebila
028fb2120e Fix typo 2019-03-21 23:53:53 -04:00
Douglas Stebila
ca798ee18a Fix Windows warnings 2019-03-21 23:51:34 -04:00
Douglas Stebila
f0ba4f2051 Add Windows Makefile 2019-03-21 23:48:52 -04:00
Douglas Stebila
e153dfdf56 Apply clang-tidy 2019-03-21 23:40:12 -04:00
Douglas Stebila
7485f35366 Apply astyle 2019-03-21 23:27:16 -04:00
Douglas Stebila
a2399091a7 Initial FrodoKEM-640-SHAKE implementation 2019-03-21 22:56:45 -04:00