kris/th5
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

crypto/tls: fix flakey test.

Browse Source 
A test added in b37d2fdcc4d9 didn't work with some values of GOMAXPROCS
because the defer statements were in the wrong order: the Pipe could be
closed before the TLS Client was.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/9187047
This commit is contained in:
Adam Langley 2013-05-16 12:29:23 -04:00
parent 7b0cd8f727
commit 44490a3db4
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
handshake_client_test.go
View File

@ -84,7 +84,7 @@ func TestEmptyRecords(t *testing.T) {
// the first application data from the server. This test ensures that
// the empty record doesn't cause (0, nil) to be returned from
// Conn.Read.
var config = *testConfig
config := *testConfig
config.CipherSuites = []uint16{TLS_RSA_WITH_AES_256_CBC_SHA}
c, s := net.Pipe()
@ -92,8 +92,8 @@ func TestEmptyRecords(t *testing.T) {
go func() {
buf := make([]byte, 1024)
n, err := cli.Read(buf)
defer cli.Close()
defer c.Close()
defer cli.Close()
if err != nil {
t.Fatalf("error reading from tls.Client: %s", err)