kris/th5
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

all: prefer strings.LastIndexByte over strings.LastIndex

Browse Source 
strings.LastIndexByte was introduced in go1.5 and it can be used
effectively wherever the second argument to strings.LastIndex is
exactly one byte long.

This avoids generating unnecessary string symbols and saves
a few calls to strings.LastIndex.

Change-Id: I7b5679d616197b055cffe6882a8675d24a98b574
Reviewed-on: https://go-review.googlesource.com/66372
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
This commit is contained in:
Marvin Stenger 2017-09-25 15:47:44 +02:00 committed by Ian Lance Taylor
parent 0648fb0f1c
commit d547ccf7ac
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
handshake_client.go
View File

@ -848,7 +848,7 @@ func hostnameInSNI(name string) string {
if len(host) > 0 && host[0] == '[' && host[len(host)-1] == ']' { if len(host) > 0 && host[0] == '[' && host[len(host)-1] == ']' {
host = host[1 : len(host)-1] host = host[1 : len(host)-1]
} }
if i := strings.LastIndex(host, "%"); i > 0 { if i := strings.LastIndexByte(host, '%'); i > 0 {
host = host[:i] host = host[:i]
} }
if net.ParseIP(host) != nil { if net.ParseIP(host) != nil {

2
tls.go
View File

@ -122,7 +122,7 @@ func DialWithDialer(dialer *net.Dialer, network, addr string, config *Config) (*
return nil, err return nil, err
} }
colonPos := strings.LastIndex(addr, ":") colonPos := strings.LastIndexByte(addr, ':')
if colonPos == -1 { if colonPos == -1 {
colonPos = len(addr) colonPos = len(addr)
} }