Browse Source

all: prefer bytes.IndexByte over bytes.Index

bytes.IndexByte can be used wherever the second argument to
strings.Index is exactly one byte long, so we do that with this change.

This avoids generating unnecessary string symbols/converison and saves
a few calls to bytes.Index.

Change-Id: If31c775790e01edfece1169e398ad6a754fb4428
Reviewed-on: https://go-review.googlesource.com/66373
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
v1.2.3
Marvin Stenger 7 years ago
committed by Ian Lance Taylor
parent
commit
d7983b094e
1 changed files with 1 additions and 1 deletions
  1. +1
    -1
      handshake_client_test.go

+ 1
- 1
handshake_client_test.go View File

@@ -85,7 +85,7 @@ func (o *opensslOutputSink) Write(data []byte) (n int, err error) {
o.all = append(o.all, data...) o.all = append(o.all, data...)


for { for {
i := bytes.Index(o.line, []byte{'\n'})
i := bytes.IndexByte(o.line, '\n')
if i < 0 { if i < 0 {
break break
} }


Loading…
Cancel
Save