From 113bae628347e7ba85bd140373362d0e1e9c26d4 Mon Sep 17 00:00:00 2001 From: Adam Langley Date: Mon, 16 Mar 2015 16:45:29 -0700 Subject: [PATCH] crypto/tls: panic with unknown hash functions. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Just so that we notice in the future if another hash function is added without updating this utility function, make it panic when passed an unknown handshake hash function. (Which should never happen.) Change-Id: I60a6fc01669441523d8c44e8fbe7ed435e7f04c8 Reviewed-on: https://go-review.googlesource.com/7646 Reviewed-by: Andrew Gerrand Reviewed-by: Joël Stemmer --- prf.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/prf.go b/prf.go index f39a2a8..d2f9e28 100644 --- a/prf.go +++ b/prf.go @@ -10,6 +10,7 @@ import ( "crypto/md5" "crypto/sha1" "hash" + "strconv" ) // Split a premaster secret in two as specified in RFC 4346, section 5. @@ -303,5 +304,5 @@ func tls12HashID(h crypto.Hash) uint8 { case crypto.SHA384: return hashSHA384 } - return 0 + panic("tls12HashID called with unknown hash " + strconv.Itoa(int(h))) }