2014-06-20 20:00:00 +01:00
|
|
|
/* Copyright (c) 2014, Google Inc.
|
|
|
|
*
|
|
|
|
* Permission to use, copy, modify, and/or distribute this software for any
|
|
|
|
* purpose with or without fee is hereby granted, provided that the above
|
|
|
|
* copyright notice and this permission notice appear in all copies.
|
|
|
|
*
|
|
|
|
* THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
|
|
|
|
* WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
|
|
|
|
* MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY
|
|
|
|
* SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
|
|
|
|
* WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION
|
|
|
|
* OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN
|
|
|
|
* CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */
|
|
|
|
|
|
|
|
#include <openssl/rand.h>
|
|
|
|
|
2015-09-24 23:03:14 +01:00
|
|
|
#include <assert.h>
|
2015-04-25 01:40:19 +01:00
|
|
|
#include <limits.h>
|
2015-04-13 19:04:21 +01:00
|
|
|
#include <string.h>
|
|
|
|
|
2017-05-31 22:05:20 +01:00
|
|
|
#if defined(BORINGSSL_FIPS)
|
|
|
|
#include <unistd.h>
|
|
|
|
#endif
|
|
|
|
|
2015-06-17 05:53:09 +01:00
|
|
|
#include <openssl/chacha.h>
|
2015-09-24 23:03:14 +01:00
|
|
|
#include <openssl/cpu.h>
|
2015-04-13 19:04:21 +01:00
|
|
|
#include <openssl/mem.h>
|
|
|
|
|
|
|
|
#include "internal.h"
|
2017-04-14 19:16:20 +01:00
|
|
|
#include "../../internal.h"
|
2017-05-31 22:05:20 +01:00
|
|
|
#include "../delocate.h"
|
2015-04-13 19:04:21 +01:00
|
|
|
|
|
|
|
|
|
|
|
/* It's assumed that the operating system always has an unfailing source of
|
|
|
|
* entropy which is accessed via |CRYPTO_sysrand|. (If the operating system
|
|
|
|
* entropy source fails, it's up to |CRYPTO_sysrand| to abort the process—we
|
|
|
|
* don't try to handle it.)
|
|
|
|
*
|
|
|
|
* In addition, the hardware may provide a low-latency RNG. Intel's rdrand
|
|
|
|
* instruction is the canonical example of this. When a hardware RNG is
|
|
|
|
* available we don't need to worry about an RNG failure arising from fork()ing
|
2017-04-11 00:53:20 +01:00
|
|
|
* the process or moving a VM, so we can keep thread-local RNG state and use it
|
|
|
|
* as an additional-data input to CTR-DRBG.
|
2015-04-13 19:04:21 +01:00
|
|
|
*
|
|
|
|
* (We assume that the OS entropy is safe from fork()ing and VM duplication.
|
|
|
|
* This might be a bit of a leap of faith, esp on Windows, but there's nothing
|
|
|
|
* that we can do about it.) */
|
|
|
|
|
2017-04-11 00:53:20 +01:00
|
|
|
/* kReseedInterval is the number of generate calls made to CTR-DRBG before
|
|
|
|
* reseeding. */
|
|
|
|
static const unsigned kReseedInterval = 4096;
|
|
|
|
|
2017-04-12 00:19:27 +01:00
|
|
|
/* CRNGT_BLOCK_SIZE is the number of bytes in a “block” for the purposes of the
|
|
|
|
* continuous random number generator test in FIPS 140-2, section 4.9.2. */
|
|
|
|
#define CRNGT_BLOCK_SIZE 16
|
|
|
|
|
2017-04-11 00:53:20 +01:00
|
|
|
/* rand_thread_state contains the per-thread state for the RNG. */
|
2015-04-13 19:04:21 +01:00
|
|
|
struct rand_thread_state {
|
2017-04-11 00:53:20 +01:00
|
|
|
CTR_DRBG_STATE drbg;
|
|
|
|
/* calls is the number of generate calls made on |drbg| since it was last
|
|
|
|
* (re)seeded. This is bound by |kReseedInterval|. */
|
|
|
|
unsigned calls;
|
2017-04-12 00:19:27 +01:00
|
|
|
/* last_block_valid is non-zero iff |last_block| contains data from
|
|
|
|
* |CRYPTO_sysrand|. */
|
|
|
|
int last_block_valid;
|
2017-05-31 22:05:20 +01:00
|
|
|
|
|
|
|
#if defined(BORINGSSL_FIPS)
|
|
|
|
/* last_block contains the previous block from |CRYPTO_sysrand|. */
|
|
|
|
uint8_t last_block[CRNGT_BLOCK_SIZE];
|
|
|
|
/* next and prev form a NULL-terminated, double-linked list of all states in
|
|
|
|
* a process. */
|
|
|
|
struct rand_thread_state *next, *prev;
|
|
|
|
#endif
|
2015-04-13 19:04:21 +01:00
|
|
|
};
|
|
|
|
|
2017-05-31 22:05:20 +01:00
|
|
|
#if defined(BORINGSSL_FIPS)
|
|
|
|
/* thread_states_list is the head of a linked-list of all |rand_thread_state|
|
|
|
|
* objects in the process, one per thread. This is needed because FIPS requires
|
|
|
|
* that they be zeroed on process exit, but thread-local destructors aren't
|
|
|
|
* called when the whole process is exiting. */
|
|
|
|
DEFINE_BSS_GET(struct rand_thread_state *, thread_states_list);
|
|
|
|
DEFINE_STATIC_MUTEX(thread_states_list_lock);
|
|
|
|
|
|
|
|
static void rand_thread_state_clear_all(void) __attribute__((destructor));
|
|
|
|
static void rand_thread_state_clear_all(void) {
|
|
|
|
CRYPTO_STATIC_MUTEX_lock_write(thread_states_list_lock_bss_get());
|
|
|
|
for (struct rand_thread_state *cur = *thread_states_list_bss_get();
|
|
|
|
cur != NULL; cur = cur->next) {
|
|
|
|
CTR_DRBG_clear(&cur->drbg);
|
|
|
|
}
|
|
|
|
/* |thread_states_list_lock is deliberately left locked so that any threads
|
|
|
|
* that are still running will hang if they try to call |RAND_bytes|. */
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
2015-04-13 19:04:21 +01:00
|
|
|
/* rand_thread_state_free frees a |rand_thread_state|. This is called when a
|
|
|
|
* thread exits. */
|
2017-04-11 00:53:20 +01:00
|
|
|
static void rand_thread_state_free(void *state_in) {
|
2017-05-31 22:05:20 +01:00
|
|
|
struct rand_thread_state *state = state_in;
|
|
|
|
|
2017-04-11 00:53:20 +01:00
|
|
|
if (state_in == NULL) {
|
2015-04-13 19:04:21 +01:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2017-05-31 22:05:20 +01:00
|
|
|
#if defined(BORINGSSL_FIPS)
|
|
|
|
CRYPTO_STATIC_MUTEX_lock_write(thread_states_list_lock_bss_get());
|
|
|
|
|
|
|
|
if (state->prev != NULL) {
|
|
|
|
state->prev->next = state->next;
|
|
|
|
} else {
|
|
|
|
*thread_states_list_bss_get() = state->next;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (state->next != NULL) {
|
|
|
|
state->next->prev = state->prev;
|
|
|
|
}
|
|
|
|
|
|
|
|
CRYPTO_STATIC_MUTEX_unlock_write(thread_states_list_lock_bss_get());
|
|
|
|
|
2017-04-11 00:53:20 +01:00
|
|
|
CTR_DRBG_clear(&state->drbg);
|
2017-05-31 22:05:20 +01:00
|
|
|
#endif
|
|
|
|
|
2015-04-13 19:04:21 +01:00
|
|
|
OPENSSL_free(state);
|
|
|
|
}
|
|
|
|
|
2016-03-02 03:57:32 +00:00
|
|
|
#if defined(OPENSSL_X86_64) && !defined(OPENSSL_NO_ASM) && \
|
2016-11-04 22:59:33 +00:00
|
|
|
!defined(BORINGSSL_UNSAFE_DETERMINISTIC_MODE)
|
2015-09-24 23:03:14 +01:00
|
|
|
|
|
|
|
/* These functions are defined in asm/rdrand-x86_64.pl */
|
|
|
|
extern int CRYPTO_rdrand(uint8_t out[8]);
|
|
|
|
extern int CRYPTO_rdrand_multiple8_buf(uint8_t *buf, size_t len);
|
|
|
|
|
|
|
|
static int have_rdrand(void) {
|
2017-04-25 20:37:53 +01:00
|
|
|
return (OPENSSL_ia32cap_get()[1] & (1u << 30)) != 0;
|
2015-09-24 23:03:14 +01:00
|
|
|
}
|
|
|
|
|
2017-05-31 23:44:59 +01:00
|
|
|
static int hwrand(uint8_t *buf, const size_t len) {
|
2015-09-24 23:03:14 +01:00
|
|
|
if (!have_rdrand()) {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
const size_t len_multiple8 = len & ~7;
|
|
|
|
if (!CRYPTO_rdrand_multiple8_buf(buf, len_multiple8)) {
|
|
|
|
return 0;
|
|
|
|
}
|
2017-05-31 23:44:59 +01:00
|
|
|
const size_t remainder = len - len_multiple8;
|
2015-09-24 23:03:14 +01:00
|
|
|
|
2017-05-31 23:44:59 +01:00
|
|
|
if (remainder != 0) {
|
|
|
|
assert(remainder < 8);
|
2015-09-24 23:03:14 +01:00
|
|
|
|
|
|
|
uint8_t rand_buf[8];
|
|
|
|
if (!CRYPTO_rdrand(rand_buf)) {
|
|
|
|
return 0;
|
|
|
|
}
|
2017-05-31 23:44:59 +01:00
|
|
|
OPENSSL_memcpy(buf + len_multiple8, rand_buf, remainder);
|
2015-09-24 23:03:14 +01:00
|
|
|
}
|
|
|
|
|
2017-05-31 23:44:59 +01:00
|
|
|
#if defined(BORINGSSL_FIPS_BREAK_CRNG)
|
|
|
|
// This breaks the "continuous random number generator test" defined in FIPS
|
|
|
|
// 140-2, section 4.9.2, and implemented in rand_get_seed().
|
|
|
|
OPENSSL_memset(buf, 0, len);
|
|
|
|
#endif
|
|
|
|
|
2015-09-24 23:03:14 +01:00
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
#else
|
|
|
|
|
|
|
|
static int hwrand(uint8_t *buf, size_t len) {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
#endif
|
|
|
|
|
2017-04-11 00:53:20 +01:00
|
|
|
#if defined(BORINGSSL_FIPS)
|
|
|
|
|
2017-04-12 00:19:27 +01:00
|
|
|
static void rand_get_seed(struct rand_thread_state *state,
|
|
|
|
uint8_t seed[CTR_DRBG_ENTROPY_LEN]) {
|
|
|
|
if (!state->last_block_valid) {
|
2017-05-18 19:26:36 +01:00
|
|
|
if (!hwrand(state->last_block, sizeof(state->last_block))) {
|
|
|
|
CRYPTO_sysrand(state->last_block, sizeof(state->last_block));
|
|
|
|
}
|
2017-04-12 00:19:27 +01:00
|
|
|
state->last_block_valid = 1;
|
|
|
|
}
|
|
|
|
|
2017-05-18 19:26:36 +01:00
|
|
|
/* We overread from /dev/urandom or RDRAND by a factor of 10 and XOR to
|
|
|
|
* whiten. */
|
2017-04-11 00:53:20 +01:00
|
|
|
#define FIPS_OVERREAD 10
|
|
|
|
uint8_t entropy[CTR_DRBG_ENTROPY_LEN * FIPS_OVERREAD];
|
2017-05-18 19:26:36 +01:00
|
|
|
|
|
|
|
if (!hwrand(entropy, sizeof(entropy))) {
|
|
|
|
CRYPTO_sysrand(entropy, sizeof(entropy));
|
|
|
|
}
|
2017-04-11 00:53:20 +01:00
|
|
|
|
2017-04-12 00:19:27 +01:00
|
|
|
/* See FIPS 140-2, section 4.9.2. This is the “continuous random number
|
|
|
|
* generator test” which causes the program to randomly abort. Hopefully the
|
|
|
|
* rate of failure is small enough not to be a problem in practice. */
|
|
|
|
if (CRYPTO_memcmp(state->last_block, entropy, CRNGT_BLOCK_SIZE) == 0) {
|
2017-05-31 23:44:59 +01:00
|
|
|
printf("CRNGT failed.\n");
|
2017-05-18 19:37:44 +01:00
|
|
|
BORINGSSL_FIPS_abort();
|
2017-04-12 00:19:27 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
for (size_t i = CRNGT_BLOCK_SIZE; i < sizeof(entropy);
|
|
|
|
i += CRNGT_BLOCK_SIZE) {
|
|
|
|
if (CRYPTO_memcmp(entropy + i - CRNGT_BLOCK_SIZE, entropy + i,
|
|
|
|
CRNGT_BLOCK_SIZE) == 0) {
|
2017-05-31 23:44:59 +01:00
|
|
|
printf("CRNGT failed.\n");
|
2017-05-18 19:37:44 +01:00
|
|
|
BORINGSSL_FIPS_abort();
|
2017-04-12 00:19:27 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
OPENSSL_memcpy(state->last_block,
|
|
|
|
entropy + sizeof(entropy) - CRNGT_BLOCK_SIZE,
|
|
|
|
CRNGT_BLOCK_SIZE);
|
|
|
|
|
2017-04-11 00:53:20 +01:00
|
|
|
OPENSSL_memcpy(seed, entropy, CTR_DRBG_ENTROPY_LEN);
|
|
|
|
|
|
|
|
for (size_t i = 1; i < FIPS_OVERREAD; i++) {
|
|
|
|
for (size_t j = 0; j < CTR_DRBG_ENTROPY_LEN; j++) {
|
|
|
|
seed[j] ^= entropy[CTR_DRBG_ENTROPY_LEN * i + j];
|
|
|
|
}
|
2015-04-13 19:04:21 +01:00
|
|
|
}
|
2017-04-11 00:53:20 +01:00
|
|
|
}
|
2015-04-13 19:04:21 +01:00
|
|
|
|
2017-04-11 00:53:20 +01:00
|
|
|
#else
|
|
|
|
|
2017-04-12 00:19:27 +01:00
|
|
|
static void rand_get_seed(struct rand_thread_state *state,
|
|
|
|
uint8_t seed[CTR_DRBG_ENTROPY_LEN]) {
|
2017-05-18 19:26:36 +01:00
|
|
|
/* If not in FIPS mode, we don't overread from the system entropy source and
|
|
|
|
* we don't depend only on the hardware RDRAND. */
|
2017-04-11 00:53:20 +01:00
|
|
|
CRYPTO_sysrand(seed, CTR_DRBG_ENTROPY_LEN);
|
|
|
|
}
|
|
|
|
|
|
|
|
#endif
|
|
|
|
|
|
|
|
void RAND_bytes_with_additional_data(uint8_t *out, size_t out_len,
|
|
|
|
const uint8_t user_additional_data[32]) {
|
|
|
|
if (out_len == 0) {
|
|
|
|
return;
|
2015-04-13 19:04:21 +01:00
|
|
|
}
|
|
|
|
|
Work around an apparent Linux or glibc bug on ppc64le in FIPS mode.
POWER8 has hardware transactional memory, which glibc uses to implement
locks. In some cases, taking a lock begins a transaction, wrapping
arbitrary user code (!) until the lock is released. If the transaction
is aborted, everything rewinds and glibc tries again with some other
implementation.
The kernel will abort the transaction in a variety of cases. Notably, on
a syscall, the transaction aborts and the syscall *does not happen*.
https://www.kernel.org/doc/Documentation/powerpc/transactional_memory.txt
Yet, for some reason, although the relevant change does appear to be in
the kernel, the transaction is being rewound with getrandom happening
anyway. This does not work very well.
Instead, only guard the DRBG access with the lock, not CRYPTO_sysrand.
This lock is only used to protect the DRBG from the destructor that
zeros everything.
Change-Id: Ied8350f1e808a09300651de4200c7b0d07b3a158
Reviewed-on: https://boringssl-review.googlesource.com/16985
Commit-Queue: David Benjamin <davidben@google.com>
Commit-Queue: Adam Langley <agl@google.com>
Reviewed-by: Adam Langley <agl@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
2017-06-07 20:30:11 +01:00
|
|
|
/* Additional data is mixed into every CTR-DRBG call to protect, as best we
|
|
|
|
* can, against forks & VM clones. We do not over-read this information and
|
|
|
|
* don't reseed with it so, from the point of view of FIPS, this doesn't
|
|
|
|
* provide “prediction resistance”. But, in practice, it does. */
|
|
|
|
uint8_t additional_data[32];
|
|
|
|
if (!hwrand(additional_data, sizeof(additional_data))) {
|
|
|
|
/* Without a hardware RNG to save us from address-space duplication, the OS
|
|
|
|
* entropy is used. This can be expensive (one read per |RAND_bytes| call)
|
|
|
|
* and so can be disabled by applications that we have ensured don't fork
|
|
|
|
* and aren't at risk of VM cloning. */
|
|
|
|
if (!rand_fork_unsafe_buffering_enabled()) {
|
|
|
|
CRYPTO_sysrand(additional_data, sizeof(additional_data));
|
|
|
|
} else {
|
|
|
|
OPENSSL_memset(additional_data, 0, sizeof(additional_data));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
for (size_t i = 0; i < sizeof(additional_data); i++) {
|
|
|
|
additional_data[i] ^= user_additional_data[i];
|
|
|
|
}
|
|
|
|
|
2017-04-11 00:53:20 +01:00
|
|
|
struct rand_thread_state stack_state;
|
2015-04-13 19:04:21 +01:00
|
|
|
struct rand_thread_state *state =
|
|
|
|
CRYPTO_get_thread_local(OPENSSL_THREAD_LOCAL_RAND);
|
2017-04-11 00:53:20 +01:00
|
|
|
|
2015-04-13 19:04:21 +01:00
|
|
|
if (state == NULL) {
|
|
|
|
state = OPENSSL_malloc(sizeof(struct rand_thread_state));
|
|
|
|
if (state == NULL ||
|
|
|
|
!CRYPTO_set_thread_local(OPENSSL_THREAD_LOCAL_RAND, state,
|
|
|
|
rand_thread_state_free)) {
|
2017-04-11 00:53:20 +01:00
|
|
|
/* If the system is out of memory, use an ephemeral state on the
|
|
|
|
* stack. */
|
|
|
|
state = &stack_state;
|
|
|
|
}
|
|
|
|
|
2017-04-12 00:19:27 +01:00
|
|
|
state->last_block_valid = 0;
|
2017-04-11 00:53:20 +01:00
|
|
|
uint8_t seed[CTR_DRBG_ENTROPY_LEN];
|
2017-04-12 00:19:27 +01:00
|
|
|
rand_get_seed(state, seed);
|
2017-04-11 00:53:20 +01:00
|
|
|
if (!CTR_DRBG_init(&state->drbg, seed, NULL, 0)) {
|
|
|
|
abort();
|
2015-04-13 19:04:21 +01:00
|
|
|
}
|
2017-04-11 00:53:20 +01:00
|
|
|
state->calls = 0;
|
2017-05-31 22:05:20 +01:00
|
|
|
|
|
|
|
#if defined(BORINGSSL_FIPS)
|
|
|
|
if (state != &stack_state) {
|
|
|
|
CRYPTO_STATIC_MUTEX_lock_write(thread_states_list_lock_bss_get());
|
|
|
|
struct rand_thread_state **states_list = thread_states_list_bss_get();
|
|
|
|
state->next = *states_list;
|
|
|
|
if (state->next != NULL) {
|
|
|
|
state->next->prev = state;
|
|
|
|
}
|
|
|
|
state->prev = NULL;
|
|
|
|
*states_list = state;
|
|
|
|
CRYPTO_STATIC_MUTEX_unlock_write(thread_states_list_lock_bss_get());
|
|
|
|
}
|
|
|
|
#endif
|
2017-04-11 00:53:20 +01:00
|
|
|
}
|
2015-04-13 19:04:21 +01:00
|
|
|
|
2017-04-11 00:53:20 +01:00
|
|
|
if (state->calls >= kReseedInterval) {
|
|
|
|
uint8_t seed[CTR_DRBG_ENTROPY_LEN];
|
2017-04-12 00:19:27 +01:00
|
|
|
rand_get_seed(state, seed);
|
Work around an apparent Linux or glibc bug on ppc64le in FIPS mode.
POWER8 has hardware transactional memory, which glibc uses to implement
locks. In some cases, taking a lock begins a transaction, wrapping
arbitrary user code (!) until the lock is released. If the transaction
is aborted, everything rewinds and glibc tries again with some other
implementation.
The kernel will abort the transaction in a variety of cases. Notably, on
a syscall, the transaction aborts and the syscall *does not happen*.
https://www.kernel.org/doc/Documentation/powerpc/transactional_memory.txt
Yet, for some reason, although the relevant change does appear to be in
the kernel, the transaction is being rewound with getrandom happening
anyway. This does not work very well.
Instead, only guard the DRBG access with the lock, not CRYPTO_sysrand.
This lock is only used to protect the DRBG from the destructor that
zeros everything.
Change-Id: Ied8350f1e808a09300651de4200c7b0d07b3a158
Reviewed-on: https://boringssl-review.googlesource.com/16985
Commit-Queue: David Benjamin <davidben@google.com>
Commit-Queue: Adam Langley <agl@google.com>
Reviewed-by: Adam Langley <agl@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
2017-06-07 20:30:11 +01:00
|
|
|
#if defined(BORINGSSL_FIPS)
|
|
|
|
/* Take a read lock around accesses to |state->drbg|. This is needed to
|
|
|
|
* avoid returning bad entropy if we race with
|
|
|
|
* |rand_thread_state_clear_all|.
|
|
|
|
*
|
|
|
|
* This lock must be taken after any calls to |CRYPTO_sysrand| to avoid a
|
2017-06-08 23:13:19 +01:00
|
|
|
* bug on ppc64le. glibc may implement pthread locks by wrapping user code
|
|
|
|
* in a hardware transaction, but, on some older versions of glibc and the
|
|
|
|
* kernel, syscalls made with |syscall| did not abort the transaction. */
|
Work around an apparent Linux or glibc bug on ppc64le in FIPS mode.
POWER8 has hardware transactional memory, which glibc uses to implement
locks. In some cases, taking a lock begins a transaction, wrapping
arbitrary user code (!) until the lock is released. If the transaction
is aborted, everything rewinds and glibc tries again with some other
implementation.
The kernel will abort the transaction in a variety of cases. Notably, on
a syscall, the transaction aborts and the syscall *does not happen*.
https://www.kernel.org/doc/Documentation/powerpc/transactional_memory.txt
Yet, for some reason, although the relevant change does appear to be in
the kernel, the transaction is being rewound with getrandom happening
anyway. This does not work very well.
Instead, only guard the DRBG access with the lock, not CRYPTO_sysrand.
This lock is only used to protect the DRBG from the destructor that
zeros everything.
Change-Id: Ied8350f1e808a09300651de4200c7b0d07b3a158
Reviewed-on: https://boringssl-review.googlesource.com/16985
Commit-Queue: David Benjamin <davidben@google.com>
Commit-Queue: Adam Langley <agl@google.com>
Reviewed-by: Adam Langley <agl@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
2017-06-07 20:30:11 +01:00
|
|
|
CRYPTO_STATIC_MUTEX_lock_read(thread_states_list_lock_bss_get());
|
|
|
|
#endif
|
2017-04-11 00:53:20 +01:00
|
|
|
if (!CTR_DRBG_reseed(&state->drbg, seed, NULL, 0)) {
|
|
|
|
abort();
|
|
|
|
}
|
|
|
|
state->calls = 0;
|
Work around an apparent Linux or glibc bug on ppc64le in FIPS mode.
POWER8 has hardware transactional memory, which glibc uses to implement
locks. In some cases, taking a lock begins a transaction, wrapping
arbitrary user code (!) until the lock is released. If the transaction
is aborted, everything rewinds and glibc tries again with some other
implementation.
The kernel will abort the transaction in a variety of cases. Notably, on
a syscall, the transaction aborts and the syscall *does not happen*.
https://www.kernel.org/doc/Documentation/powerpc/transactional_memory.txt
Yet, for some reason, although the relevant change does appear to be in
the kernel, the transaction is being rewound with getrandom happening
anyway. This does not work very well.
Instead, only guard the DRBG access with the lock, not CRYPTO_sysrand.
This lock is only used to protect the DRBG from the destructor that
zeros everything.
Change-Id: Ied8350f1e808a09300651de4200c7b0d07b3a158
Reviewed-on: https://boringssl-review.googlesource.com/16985
Commit-Queue: David Benjamin <davidben@google.com>
Commit-Queue: Adam Langley <agl@google.com>
Reviewed-by: Adam Langley <agl@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
2017-06-07 20:30:11 +01:00
|
|
|
} else {
|
|
|
|
#if defined(BORINGSSL_FIPS)
|
|
|
|
CRYPTO_STATIC_MUTEX_lock_read(thread_states_list_lock_bss_get());
|
|
|
|
#endif
|
2017-04-11 00:53:20 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
int first_call = 1;
|
|
|
|
while (out_len > 0) {
|
|
|
|
size_t todo = out_len;
|
|
|
|
if (todo > CTR_DRBG_MAX_GENERATE_LENGTH) {
|
|
|
|
todo = CTR_DRBG_MAX_GENERATE_LENGTH;
|
2015-04-13 19:04:21 +01:00
|
|
|
}
|
|
|
|
|
2017-04-11 00:53:20 +01:00
|
|
|
if (!CTR_DRBG_generate(&state->drbg, out, todo, additional_data,
|
|
|
|
first_call ? sizeof(additional_data) : 0)) {
|
|
|
|
abort();
|
2015-04-13 19:04:21 +01:00
|
|
|
}
|
2017-04-11 00:53:20 +01:00
|
|
|
|
|
|
|
out += todo;
|
|
|
|
out_len -= todo;
|
|
|
|
state->calls++;
|
|
|
|
first_call = 0;
|
2015-04-13 19:04:21 +01:00
|
|
|
}
|
|
|
|
|
2017-04-11 00:53:20 +01:00
|
|
|
if (state == &stack_state) {
|
|
|
|
CTR_DRBG_clear(&state->drbg);
|
|
|
|
}
|
|
|
|
|
2017-05-31 22:05:20 +01:00
|
|
|
#if defined(BORINGSSL_FIPS)
|
|
|
|
CRYPTO_STATIC_MUTEX_unlock_read(thread_states_list_lock_bss_get());
|
|
|
|
#endif
|
|
|
|
|
2017-04-11 00:53:20 +01:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
int RAND_bytes(uint8_t *out, size_t out_len) {
|
|
|
|
static const uint8_t kZeroAdditionalData[32] = {0};
|
|
|
|
RAND_bytes_with_additional_data(out, out_len, kZeroAdditionalData);
|
2015-04-13 19:04:21 +01:00
|
|
|
return 1;
|
|
|
|
}
|
2014-06-20 20:00:00 +01:00
|
|
|
|
|
|
|
int RAND_pseudo_bytes(uint8_t *buf, size_t len) {
|
|
|
|
return RAND_bytes(buf, len);
|
|
|
|
}
|