You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

d1_lib.c 10 KiB

Set rwstate consistently. We reset it to SSL_NOTHING at the start of ever SSL_get_error-using operation. Then we only set it to a non-NOTHING value in the rest of the stack on error paths. Currently, ssl->rwstate is set all over the place. Sometimes the pattern is: ssl->rwstate = SSL_WRITING; if (BIO_write(...) <= 0) { goto err; } ssl->rwstate = SSL_NOTHING; Sometimes we only set it to the non-NOTHING value on error. if (BIO_write(...) <= 0) { ssl->rwstate = SSL_WRITING; } ssl->rwstate = SSL_NOTHING; Sometimes we just set it to SSL_NOTHING far from any callback in random places. The third case is arbitrary and clearly should be removed. But, in the second case, we sometimes forget to undo it afterwards. This is largely harmless since an error in the error queue overrides rwstate, but we don't always put something in the error queue (falling back to SSL_ERROR_SYSCALL for "I'm not sure why it failed. Perhaps it was one of your callbacks? Check your errno equivalent."), but in that case a stray rwstate value will cause it to be wrong. We could fix the cases where we fail to set SSL_NOTHING on success cases, but this doesn't account for there being multiple SSL_get_error operations. The consumer may have an SSL_read and an SSL_write running concurrently. Instead, it seems the best option is to lift the SSL_NOTHING reset to the operations and set SSL_WRITING and friends as in the second case. (Someday hopefully we can fix this to just be an enum that is internally returned. It can convert to something stateful at the API layer.) Change-Id: I54665ec066a64eb0e48a06e2fcd0d2681a42df7f Reviewed-on: https://boringssl-review.googlesource.com/7453 Reviewed-by: David Benjamin <davidben@google.com>
8 years ago
Clear the error queue on entry to core SSL operations. OpenSSL historically made some poor API decisions. Rather than returning a status enum in SSL_read, etc., these functions must be paired with SSL_get_error which determines the cause of the last error's failure. This requires SSL_read communicate with SSL_get_error with some stateful flag, rwstate. Further, probably as workarounds for bugs elsewhere, SSL_get_error does not trust rwstate. Among other quirks, if the error queue is non-empty, SSL_get_error overrides rwstate and returns a value based on that. This requires that SSL_read, etc., be called with an empty error queue. (Or we hit one of the spurious ERR_clear_error calls in the handshake state machine, likely added as further self-workarounds.) Since requiring callers consistently clear the error queue everywhere is unreasonable (crbug.com/567501), clear ERR_clear_error *once* at the entry point. Until/unless[*] we make SSL_get_error sane, this is the most reasonable way to get to the point that clearing the error queue on error is optional. With those in place, the calls in the handshake state machine are no longer needed. (I suspect all the ERR_clear_system_error calls can also go, but I'll investigate and think about that separately.) [*] I'm not even sure it's possible anymore, thanks to the possibility of BIO_write pushing to the error queue. BUG=567501,593963 Change-Id: I564ace199e5a4a74b2554ad3335e99cd17120741 Reviewed-on: https://boringssl-review.googlesource.com/7455 Reviewed-by: Steven Valdez <svaldez@google.com> Reviewed-by: David Benjamin <davidben@google.com>
8 years ago
123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344
  1. /*
  2. * DTLS implementation written by Nagendra Modadugu
  3. * (nagendra@cs.stanford.edu) for the OpenSSL project 2005.
  4. */
  5. /* ====================================================================
  6. * Copyright (c) 1999-2005 The OpenSSL Project. All rights reserved.
  7. *
  8. * Redistribution and use in source and binary forms, with or without
  9. * modification, are permitted provided that the following conditions
  10. * are met:
  11. *
  12. * 1. Redistributions of source code must retain the above copyright
  13. * notice, this list of conditions and the following disclaimer.
  14. *
  15. * 2. Redistributions in binary form must reproduce the above copyright
  16. * notice, this list of conditions and the following disclaimer in
  17. * the documentation and/or other materials provided with the
  18. * distribution.
  19. *
  20. * 3. All advertising materials mentioning features or use of this
  21. * software must display the following acknowledgment:
  22. * "This product includes software developed by the OpenSSL Project
  23. * for use in the OpenSSL Toolkit. (http://www.OpenSSL.org/)"
  24. *
  25. * 4. The names "OpenSSL Toolkit" and "OpenSSL Project" must not be used to
  26. * endorse or promote products derived from this software without
  27. * prior written permission. For written permission, please contact
  28. * openssl-core@OpenSSL.org.
  29. *
  30. * 5. Products derived from this software may not be called "OpenSSL"
  31. * nor may "OpenSSL" appear in their names without prior written
  32. * permission of the OpenSSL Project.
  33. *
  34. * 6. Redistributions of any form whatsoever must retain the following
  35. * acknowledgment:
  36. * "This product includes software developed by the OpenSSL Project
  37. * for use in the OpenSSL Toolkit (http://www.OpenSSL.org/)"
  38. *
  39. * THIS SOFTWARE IS PROVIDED BY THE OpenSSL PROJECT ``AS IS'' AND ANY
  40. * EXPRESSED OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
  41. * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
  42. * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE OpenSSL PROJECT OR
  43. * ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  44. * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
  45. * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
  46. * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
  47. * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
  48. * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  49. * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
  50. * OF THE POSSIBILITY OF SUCH DAMAGE.
  51. * ====================================================================
  52. *
  53. * This product includes cryptographic software written by Eric Young
  54. * (eay@cryptsoft.com). This product includes software written by Tim
  55. * Hudson (tjh@cryptsoft.com). */
  56. #include <openssl/ssl.h>
  57. #include <limits.h>
  58. #include <string.h>
  59. #include <openssl/err.h>
  60. #include <openssl/mem.h>
  61. #include <openssl/nid.h>
  62. #include "internal.h"
  63. #if defined(OPENSSL_WINDOWS)
  64. #include <sys/timeb.h>
  65. #else
  66. #include <sys/socket.h>
  67. #include <sys/time.h>
  68. #endif
  69. /* DTLS1_MTU_TIMEOUTS is the maximum number of timeouts to expire
  70. * before starting to decrease the MTU. */
  71. #define DTLS1_MTU_TIMEOUTS 2
  72. /* DTLS1_MAX_TIMEOUTS is the maximum number of timeouts to expire
  73. * before failing the DTLS handshake. */
  74. #define DTLS1_MAX_TIMEOUTS 12
  75. static void get_current_time(const SSL *ssl, struct timeval *out_clock);
  76. int dtls1_new(SSL *ssl) {
  77. DTLS1_STATE *d1;
  78. if (!ssl3_new(ssl)) {
  79. return 0;
  80. }
  81. d1 = OPENSSL_malloc(sizeof *d1);
  82. if (d1 == NULL) {
  83. ssl3_free(ssl);
  84. return 0;
  85. }
  86. memset(d1, 0, sizeof *d1);
  87. d1->buffered_messages = pqueue_new();
  88. d1->sent_messages = pqueue_new();
  89. if (!d1->buffered_messages || !d1->sent_messages) {
  90. pqueue_free(d1->buffered_messages);
  91. pqueue_free(d1->sent_messages);
  92. OPENSSL_free(d1);
  93. ssl3_free(ssl);
  94. return 0;
  95. }
  96. ssl->d1 = d1;
  97. /* Set the version to the highest supported version.
  98. *
  99. * TODO(davidben): Move this field into |s3|, have it store the normalized
  100. * protocol version, and implement this pre-negotiation quirk in |SSL_version|
  101. * at the API boundary rather than in internal state. */
  102. ssl->version = DTLS1_2_VERSION;
  103. return 1;
  104. }
  105. static void dtls1_clear_queues(SSL *ssl) {
  106. pitem *item = NULL;
  107. hm_fragment *frag = NULL;
  108. while ((item = pqueue_pop(ssl->d1->buffered_messages)) != NULL) {
  109. frag = (hm_fragment *)item->data;
  110. dtls1_hm_fragment_free(frag);
  111. pitem_free(item);
  112. }
  113. while ((item = pqueue_pop(ssl->d1->sent_messages)) != NULL) {
  114. frag = (hm_fragment *)item->data;
  115. dtls1_hm_fragment_free(frag);
  116. pitem_free(item);
  117. }
  118. }
  119. void dtls1_free(SSL *ssl) {
  120. ssl3_free(ssl);
  121. if (ssl == NULL || ssl->d1 == NULL) {
  122. return;
  123. }
  124. dtls1_clear_queues(ssl);
  125. pqueue_free(ssl->d1->buffered_messages);
  126. pqueue_free(ssl->d1->sent_messages);
  127. OPENSSL_free(ssl->d1);
  128. ssl->d1 = NULL;
  129. }
  130. int dtls1_supports_cipher(const SSL_CIPHER *cipher) {
  131. /* DTLS does not support stream ciphers. The NULL cipher is rejected because
  132. * it's not needed. */
  133. return cipher->algorithm_enc != SSL_RC4 && cipher->algorithm_enc != SSL_eNULL;
  134. }
  135. void dtls1_start_timer(SSL *ssl) {
  136. /* If timer is not set, initialize duration with 1 second */
  137. if (ssl->d1->next_timeout.tv_sec == 0 && ssl->d1->next_timeout.tv_usec == 0) {
  138. ssl->d1->timeout_duration = 1;
  139. }
  140. /* Set timeout to current time */
  141. get_current_time(ssl, &ssl->d1->next_timeout);
  142. /* Add duration to current time */
  143. ssl->d1->next_timeout.tv_sec += ssl->d1->timeout_duration;
  144. BIO_ctrl(SSL_get_rbio(ssl), BIO_CTRL_DGRAM_SET_NEXT_TIMEOUT, 0,
  145. &ssl->d1->next_timeout);
  146. }
  147. int DTLSv1_get_timeout(const SSL *ssl, struct timeval *out) {
  148. if (!SSL_IS_DTLS(ssl)) {
  149. return 0;
  150. }
  151. /* If no timeout is set, just return NULL */
  152. if (ssl->d1->next_timeout.tv_sec == 0 && ssl->d1->next_timeout.tv_usec == 0) {
  153. return 0;
  154. }
  155. /* Get current time */
  156. struct timeval timenow;
  157. get_current_time(ssl, &timenow);
  158. /* If timer already expired, set remaining time to 0 */
  159. if (ssl->d1->next_timeout.tv_sec < timenow.tv_sec ||
  160. (ssl->d1->next_timeout.tv_sec == timenow.tv_sec &&
  161. ssl->d1->next_timeout.tv_usec <= timenow.tv_usec)) {
  162. memset(out, 0, sizeof(struct timeval));
  163. return 1;
  164. }
  165. /* Calculate time left until timer expires */
  166. memcpy(out, &ssl->d1->next_timeout, sizeof(struct timeval));
  167. out->tv_sec -= timenow.tv_sec;
  168. out->tv_usec -= timenow.tv_usec;
  169. if (out->tv_usec < 0) {
  170. out->tv_sec--;
  171. out->tv_usec += 1000000;
  172. }
  173. /* If remaining time is less than 15 ms, set it to 0 to prevent issues
  174. * because of small devergences with socket timeouts. */
  175. if (out->tv_sec == 0 && out->tv_usec < 15000) {
  176. memset(out, 0, sizeof(struct timeval));
  177. }
  178. return 1;
  179. }
  180. int dtls1_is_timer_expired(SSL *ssl) {
  181. struct timeval timeleft;
  182. /* Get time left until timeout, return false if no timer running */
  183. if (!DTLSv1_get_timeout(ssl, &timeleft)) {
  184. return 0;
  185. }
  186. /* Return false if timer is not expired yet */
  187. if (timeleft.tv_sec > 0 || timeleft.tv_usec > 0) {
  188. return 0;
  189. }
  190. /* Timer expired, so return true */
  191. return 1;
  192. }
  193. void dtls1_double_timeout(SSL *ssl) {
  194. ssl->d1->timeout_duration *= 2;
  195. if (ssl->d1->timeout_duration > 60) {
  196. ssl->d1->timeout_duration = 60;
  197. }
  198. dtls1_start_timer(ssl);
  199. }
  200. void dtls1_stop_timer(SSL *ssl) {
  201. /* Reset everything */
  202. ssl->d1->num_timeouts = 0;
  203. memset(&ssl->d1->next_timeout, 0, sizeof(struct timeval));
  204. ssl->d1->timeout_duration = 1;
  205. BIO_ctrl(SSL_get_rbio(ssl), BIO_CTRL_DGRAM_SET_NEXT_TIMEOUT, 0,
  206. &ssl->d1->next_timeout);
  207. /* Clear retransmission buffer */
  208. dtls1_clear_record_buffer(ssl);
  209. }
  210. int dtls1_check_timeout_num(SSL *ssl) {
  211. ssl->d1->num_timeouts++;
  212. /* Reduce MTU after 2 unsuccessful retransmissions */
  213. if (ssl->d1->num_timeouts > DTLS1_MTU_TIMEOUTS &&
  214. !(SSL_get_options(ssl) & SSL_OP_NO_QUERY_MTU)) {
  215. long mtu = BIO_ctrl(SSL_get_wbio(ssl), BIO_CTRL_DGRAM_GET_FALLBACK_MTU, 0,
  216. NULL);
  217. if (mtu >= 0 && mtu <= (1 << 30) && (unsigned)mtu >= dtls1_min_mtu()) {
  218. ssl->d1->mtu = (unsigned)mtu;
  219. }
  220. }
  221. if (ssl->d1->num_timeouts > DTLS1_MAX_TIMEOUTS) {
  222. /* fail the connection, enough alerts have been sent */
  223. OPENSSL_PUT_ERROR(SSL, SSL_R_READ_TIMEOUT_EXPIRED);
  224. return -1;
  225. }
  226. return 0;
  227. }
  228. int DTLSv1_handle_timeout(SSL *ssl) {
  229. ssl->rwstate = SSL_NOTHING;
  230. /* Functions which use SSL_get_error must clear the error queue on entry. */
  231. ERR_clear_error();
  232. if (!SSL_IS_DTLS(ssl)) {
  233. return -1;
  234. }
  235. /* if no timer is expired, don't do anything */
  236. if (!dtls1_is_timer_expired(ssl)) {
  237. return 0;
  238. }
  239. dtls1_double_timeout(ssl);
  240. if (dtls1_check_timeout_num(ssl) < 0) {
  241. return -1;
  242. }
  243. dtls1_start_timer(ssl);
  244. return dtls1_retransmit_buffered_messages(ssl);
  245. }
  246. static void get_current_time(const SSL *ssl, struct timeval *out_clock) {
  247. if (ssl->ctx->current_time_cb != NULL) {
  248. ssl->ctx->current_time_cb(ssl, out_clock);
  249. return;
  250. }
  251. #if defined(OPENSSL_WINDOWS)
  252. struct _timeb time;
  253. _ftime(&time);
  254. out_clock->tv_sec = time.time;
  255. out_clock->tv_usec = time.millitm * 1000;
  256. #else
  257. gettimeofday(out_clock, NULL);
  258. #endif
  259. }
  260. int dtls1_set_handshake_header(SSL *ssl, int htype, unsigned long len) {
  261. uint8_t *message = (uint8_t *)ssl->init_buf->data;
  262. const struct hm_header_st *msg_hdr = &ssl->d1->w_msg_hdr;
  263. uint8_t serialised_header[DTLS1_HM_HEADER_LENGTH];
  264. uint8_t *p = serialised_header;
  265. ssl->d1->handshake_write_seq = ssl->d1->next_handshake_write_seq;
  266. ssl->d1->next_handshake_write_seq++;
  267. dtls1_set_message_header(ssl, htype, len, ssl->d1->handshake_write_seq, 0,
  268. len);
  269. ssl->init_num = (int)len + DTLS1_HM_HEADER_LENGTH;
  270. ssl->init_off = 0;
  271. /* Buffer the message to handle re-xmits */
  272. dtls1_buffer_message(ssl);
  273. /* Add the new message to the handshake hash. Serialize the message
  274. * header as if it were a single fragment. */
  275. *p++ = msg_hdr->type;
  276. l2n3(msg_hdr->msg_len, p);
  277. s2n(msg_hdr->seq, p);
  278. l2n3(0, p);
  279. l2n3(msg_hdr->msg_len, p);
  280. return ssl3_update_handshake_hash(ssl, serialised_header,
  281. sizeof(serialised_header)) &&
  282. ssl3_update_handshake_hash(ssl, message + DTLS1_HM_HEADER_LENGTH, len);
  283. }
  284. int dtls1_handshake_write(SSL *ssl) {
  285. return dtls1_do_handshake_write(ssl, dtls1_use_current_epoch);
  286. }