kris/boringssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Make the gdb window larger.

Browse Source 
Running can spawn gdb in an xterm, but the default xterm is rather
small. We could have everyone set their .Xdefaults, I presume, to solve
this, but very few people are running the old xterm these days.

Change-Id: I46eb3ff22f292eb44ce8c5124e83f1ab8aef9547
Reviewed-on: https://boringssl-review.googlesource.com/24846
Reviewed-by: Adam Langley <agl@google.com>
Reviewed-by: David Benjamin <davidben@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
This commit is contained in:
Adam Langley 2018-01-25 15:38:24 -08:00 committed by CQ bot account: commit-bot@chromium.org
parent ab5a947d8e
commit 449a9e6a9e
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ssl/test/runner/runner.go
View File

@ -899,10 +899,12 @@ func doExchange(test *testCase, config *Config, conn net.Conn, isResume bool, tr
return nil return nil
} }
const xtermSize = "140x50"
func valgrindOf(dbAttach bool, path string, args ...string) *exec.Cmd { func valgrindOf(dbAttach bool, path string, args ...string) *exec.Cmd {
valgrindArgs := []string{"--error-exitcode=99", "--track-origins=yes", "--leak-check=full", "--quiet"} valgrindArgs := []string{"--error-exitcode=99", "--track-origins=yes", "--leak-check=full", "--quiet"}
if dbAttach { if dbAttach {
valgrindArgs = append(valgrindArgs, "--db-attach=yes", "--db-command=xterm -e gdb -nw %f %p") valgrindArgs = append(valgrindArgs, "--db-attach=yes", "--db-command=xterm -geometry "+xtermSize+" -e gdb -nw %f %p")
} }
valgrindArgs = append(valgrindArgs, path) valgrindArgs = append(valgrindArgs, path)
valgrindArgs = append(valgrindArgs, args...) valgrindArgs = append(valgrindArgs, args...)
@ -911,7 +913,7 @@ func valgrindOf(dbAttach bool, path string, args ...string) *exec.Cmd {
} }
func gdbOf(path string, args ...string) *exec.Cmd { func gdbOf(path string, args ...string) *exec.Cmd {
xtermArgs := []string{"-e", "gdb", "--args"} xtermArgs := []string{"-geometry", xtermSize, "-e", "gdb", "--args"}
xtermArgs = append(xtermArgs, path) xtermArgs = append(xtermArgs, path)
xtermArgs = append(xtermArgs, args...) xtermArgs = append(xtermArgs, args...)
@ -919,7 +921,7 @@ func gdbOf(path string, args ...string) *exec.Cmd {
} }
func lldbOf(path string, args ...string) *exec.Cmd { func lldbOf(path string, args ...string) *exec.Cmd {
xtermArgs := []string{"-e", "lldb", "--"} xtermArgs := []string{"-geometry", xtermSize, "-e", "lldb", "--"}
xtermArgs = append(xtermArgs, path) xtermArgs = append(xtermArgs, path)
xtermArgs = append(xtermArgs, args...) xtermArgs = append(xtermArgs, args...)