boringssl/ssl/test
Adam Langley 37646838e9 Have |SSL_get_verify_result| return |X509_V_OK| when no client certificate is given.
9498e74 changed the default value of verify_result to an error. This
tripped up NGINX, which depends on a bug[1] in OpenSSL. netty-tcnative
also uses this behavior, though it currently isn't tripped up by 9498e74
because it calls |SSL_set_verify_result|. However, we would like to
remove |SSL_set_verify_result| and with two data points, it seems this
is behavior we must preserve.

This change sets |verify_result| to |X509_V_OK| when a) no client
certificate is requested or b) none is given and it's optional.

[1] See BUGS in https://www.openssl.org/docs/manmaster/ssl/SSL_get_verify_result.html

Change-Id: Ibd33660ae409bfe272963a8c39b7e9aa83c3d635
Reviewed-on: https://boringssl-review.googlesource.com/9067
Reviewed-by: David Benjamin <davidben@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
2016-08-18 20:37:10 +00:00
..
runner Have |SSL_get_verify_result| return |X509_V_OK| when no client certificate is given. 2016-08-18 20:37:10 +00:00
async_bio.cc Revert "Move C++ helpers into |bssl| namespace." 2016-07-12 08:09:33 -07:00
async_bio.h Revert "Move C++ helpers into |bssl| namespace." 2016-07-12 08:09:33 -07:00
bssl_shim.cc Adding code to send session as PSK Identity. 2016-08-16 20:35:32 +00:00
CMakeLists.txt Add malloc test support to unit tests. 2015-05-21 17:59:48 +00:00
packeted_bio.cc Revert "Move C++ helpers into |bssl| namespace." 2016-07-12 08:09:33 -07:00
packeted_bio.h Revert "Move C++ helpers into |bssl| namespace." 2016-07-12 08:09:33 -07:00
PORTING.md Fix typo. 2016-08-16 18:05:47 +00:00
README.md Adding PORTING.md for instructions on how to port the test runner 2016-08-16 17:53:28 +00:00
scoped_types.h Revert "Move C++ helpers into |bssl| namespace." 2016-07-12 08:09:33 -07:00
test_config.cc Add SSL_send_fatal_alert. 2016-07-26 22:32:18 +00:00
test_config.h Add SSL_send_fatal_alert. 2016-07-26 22:32:18 +00:00

BoringSSL SSL Tests

This directory contains BoringSSL's protocol-level test suite.

Testing a TLS implementation can be difficult. We need to produce invalid but sufficiently correct handshakes to get our implementation close to its edge cases. TLS's cryptographic steps mean we cannot use a transcript and effectively need a TLS implementation on the other end. But we do not wish to litter BoringSSL with options for bugs to test against.

Instead, we use a fork of the Go crypto/tls package, heavily patched with configurable bugs. This code, along with a test suite and harness written in Go, lives in the runner directory. The harness runs BoringSSL via a C/C++ shim binary which lives in this directory. All communication with the shim binary occurs with command-line flags, sockets, and standard I/O.

This strategy also ensures we always test against a second implementation. All features should be implemented twice, once in C for BoringSSL and once in Go for testing. If possible, the Go code should be suitable for potentially upstreaming. However, sometimes test code has different needs. For example, our test DTLS code enforces strict ordering on sequence numbers and has controlled packet drop simulation.

To run the tests manually, run go test from the runner directory. It takes command-line flags found at the top of runner/runner.go. The -help option also works after using go test -c to make a runner.test binary first.

If adding a new test, these files may be a good starting point:

  • runner/runner.go: the test harness and all the individual tests.
  • runner/common.go: contains the Config and ProtocolBugs struct which control the Go TLS implementation's behavior.
  • test_config.h, test_config.cc: the command-line flags which control the shim's behavior.
  • bssl_shim.cc: the shim binary itself.

For porting the test suite to a different implementation see PORTING.md.