602f4669ab
See the IETF thread here: https://www.ietf.org/mail-archive/web/tls/current/msg27292.html In particular, although the original publication of RFC 5246 had a syntax error in the field (the minimum length was unspecified), there is an errata from 2012 to fix it to be non-empty. https://www.rfc-editor.org/errata/eid2864 Currently, when empty, we implicitly interpret it as SHA1/*, matching the server behavior in missing extension in ClientHellos. However that text does not support doing it for CertificateRequests, and there is not much reason to. That default (which is in itself confusing and caused problems such as older OpenSSL only signing SHA-1 given SNI) was because, at the time, there were concerns over making any ClientHello extensions mandatory. This isn't applicable for CertificateRequest, which can freely advertise their true preferences. Change-Id: I113494d8f66769fde1362795fb08ff2f471ef31d Reviewed-on: https://boringssl-review.googlesource.com/c/33524 Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Adam Langley <agl@google.com> |
||
---|---|---|
.. | ||
test | ||
bio_ssl.cc | ||
CMakeLists.txt | ||
d1_both.cc | ||
d1_lib.cc | ||
d1_pkt.cc | ||
d1_srtp.cc | ||
dtls_method.cc | ||
dtls_record.cc | ||
handoff.cc | ||
handshake_client.cc | ||
handshake_server.cc | ||
handshake.cc | ||
internal.h | ||
s3_both.cc | ||
s3_lib.cc | ||
s3_pkt.cc | ||
span_test.cc | ||
ssl_aead_ctx.cc | ||
ssl_asn1.cc | ||
ssl_buffer.cc | ||
ssl_cert.cc | ||
ssl_cipher.cc | ||
ssl_file.cc | ||
ssl_key_share.cc | ||
ssl_lib.cc | ||
ssl_privkey.cc | ||
ssl_session.cc | ||
ssl_stat.cc | ||
ssl_test.cc | ||
ssl_transcript.cc | ||
ssl_versions.cc | ||
ssl_x509.cc | ||
t1_enc.cc | ||
t1_lib.cc | ||
tls13_both.cc | ||
tls13_client.cc | ||
tls13_enc.cc | ||
tls13_server.cc | ||
tls_method.cc | ||
tls_record.cc |