kris/boringssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
62882187c9
boringssl/crypto/evp
History
Adam Langley 62882187c9 Update comments to better document in-place semantics. 
(Comment-only change; no functional difference.)

Some code was broken by the |d2i_ECDSA_SIG| change in 87897a8c. It was
passing in a pointer to an existing |ECDSA_SIG| as the first argument
and then simply assuming that the structure would be updated in place.
The comments on the function suggested that this was reasonable.

This change updates the comments that use similar wording to either note
that the function will never update in-place, or else to note that
depending on that is a bad idea for the future.

I've also audited all the uses of these functions that I can find and,
in addition to the one case with |d2i_ECDSA_SIG|, there are several
users of |d2i_PrivateKey| that could become a problem in the future.
I'll try to fix them before it does become an issue.

Change-Id: I769f7b2e0b5308d09ea07dd447e02fc161795071
Reviewed-on: https://boringssl-review.googlesource.com/6902
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Adam Langley <agl@google.com>
2016-01-19 17:01:37 +00:00
..
algorithm.c
CMakeLists.txt Add a run_tests target to run all tests. 2015-10-26 20:33:44 +00:00
digestsign.c Don't default to SHA-1 in |EVP_DigestSignInit|/|EVP_DigestVerifyInit|. 2015-10-26 21:26:51 +00:00
evp_asn1.c Update comments to better document in-place semantics. 2016-01-19 17:01:37 +00:00
evp_ctx.c Become partially -Wmissing-variable-declarations-clean. 2015-11-12 20:09:20 +00:00
evp_extra_test.cc Add PSS parameter check. 2015-12-03 16:47:12 +00:00
evp_test.cc Remove stl_compat.h. 2015-11-11 22:19:36 +00:00
evp_tests.txt
evp.c Remove DH EVP_PKEY hooks. 2015-12-16 17:38:06 +00:00
internal.h Become partially -Wmissing-variable-declarations-clean. 2015-11-12 20:09:20 +00:00
p_dsa_asn1.c Fix several warnings that arise in Android. 2015-10-30 21:11:48 +00:00
p_ec_asn1.c Add |EC_GROUP_get0_order| to replace |EC_GROUP_get_order|. 2015-12-15 18:18:13 +00:00
p_ec.c Remove superfluous SHA-1 dependency from EVP ECDSA code. 2015-09-15 23:18:44 +00:00
p_rsa_asn1.c Add PSS parameter check. 2015-12-03 16:47:12 +00:00
p_rsa.c Resolve a few old TODOs. 2015-12-22 00:14:35 +00:00
pbkdf_test.cc Reject iterations=0 when calling PKCS5_PBKDF2_HMAC(). 2015-10-13 19:40:55 +00:00
pbkdf.c Reject iterations=0 when calling PKCS5_PBKDF2_HMAC(). 2015-10-13 19:40:55 +00:00
sign.c