kris/boringssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
d24fd47ff4
boringssl/crypto/fipsmodule/sha/asm
History
David Benjamin 38636aba74 Hide CPU capability symbols in C. 
Our assembly does not use the GOT to reference symbols, which means
references to visible symbols will often require a TEXTREL. This is
undesirable, so all assembly-referenced symbols should be hidden. CPU
capabilities are the only such symbols defined in C.

These symbols may be hidden by doing at least one of:

1. Build with -fvisibility=hidden
2. __attribute__((visibility("hidden"))) in C.
3. .extern + .hidden in some assembly file referencing the symbol.

We have lots of consumers and can't always rely on (1) happening. We
were doing (3) by way of d216b71f90 and
16e38b2b8f, but missed 32-bit x86 because
it doesn't cause a linker error.

Those two patches are not in upstream. Upstream instead does (3) by way
of x86cpuid.pl and friends, but we have none of these files.

Standardize on doing (2). This avoids accidentally getting TEXTRELs on
some 32-bit x86 build configurations.  This also undoes
d216b71f90 and
16e38b2b8f. They are no now longer needed
and reduce the upstream diff.

Change-Id: Ib51c43fce6a7d8292533635e5d85d3c197a93644
Reviewed-on: https://boringssl-review.googlesource.com/22064
Commit-Queue: Matt Braithwaite <mab@google.com>
Reviewed-by: Matt Braithwaite <mab@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
2017-10-23 18:36:49 +00:00
..
sha1-586.pl Remove filename argument to x86 asm_init. 2017-05-12 14:58:27 +00:00
sha1-armv4-large.pl Hide CPU capability symbols in C. 2017-10-23 18:36:49 +00:00
sha1-armv8.pl Sync ARM assembly up to 609b0852e4d50251857dbbac3141ba042e35a9ae. 2017-06-13 17:47:20 +00:00
sha1-x86_64.pl x86_64 assembly pack: "optimize" for Knights Landing, add AVX-512 results. 2017-07-26 22:01:37 +00:00
sha256-586.pl Remove filename argument to x86 asm_init. 2017-05-12 14:58:27 +00:00
sha256-armv4.pl Hide CPU capability symbols in C. 2017-10-23 18:36:49 +00:00
sha512-586.pl Remove filename argument to x86 asm_init. 2017-05-12 14:58:27 +00:00
sha512-armv4.pl Hide CPU capability symbols in C. 2017-10-23 18:36:49 +00:00
sha512-armv8.pl sha/asm/sha512-armv8.pl: adapt for kernel use. 2017-06-13 17:47:41 +00:00
sha512-x86_64.pl x86_64 assembly pack: "optimize" for Knights Landing, add AVX-512 results. 2017-07-26 22:01:37 +00:00