Commit Graph

788 Commits

Author SHA1 Message Date
Thom Wiggers
770a421c16 Fix isolation in test_metadata_sizes (#258) 2019-12-12 11:36:34 +01:00
Thom Wiggers
5f0ddcad78 Add ccache to speed up builds (#257)
* Add ccache to speed up builds

* Fix circleci config

* fixup! Fix circleci config

* Try again with environment variables

* Set up ccache on MacOS
2019-12-12 11:35:19 +01:00
Thom Wiggers
377a6d8d2e
Merge pull request #252 from PQClean/fix-valgrind-circleci-failure
Fix Valgrind failures on CircleCI for Kyber-AVX2
2019-11-20 09:52:07 +01:00
Thom Wiggers
1e2aac2e22
Don't use -march=native for keccak
CircleCI has AVX512 support and the compiler will generate instructions that Valgrind doesn't handle.
2019-11-19 11:13:29 +01:00
mergify[bot]
130189f6fe
Merge pull request #250 from PQClean/rainbow_memcpy
Rainbow: memcpy -> memmove since buffers may overlap
2019-11-13 19:27:51 +00:00
mergify[bot]
b4322c706b
Merge branch 'master' into rainbow_memcpy 2019-11-13 13:22:00 +00:00
Thom Wiggers
e762163478
Don't advertise MacOS support for Kyber-AVX2
In light of #251
2019-11-13 13:27:26 +01:00
Matthias J. Kannwischer
b830b6c1d5 rainbow: memcpy -> memmove since buffers may overlap 2019-11-13 10:47:26 +01:00
Thom Wiggers
bb8ed7af9b
Merge pull request #248 from leonbotros/threebears
Add {Baby,Mama,Papa}Bear reference implementations
2019-11-04 11:45:49 +01:00
Thom Wiggers
c8347a0866
Merge pull request #240 from PQClean/clang9.0.0
Fix Clang 9.0.0 warnings
2019-10-30 14:06:56 +01:00
Leon Botros
f1511f35b9 use the same compiler flags as other implementations 2019-10-25 19:09:12 +02:00
Leon Botros
5720e25c54 add -Werror 2019-10-25 13:35:23 +02:00
Leon Botros
6a7506f520 move modulus function to source, namespace it 2019-10-25 13:14:25 +02:00
Leon Botros
bc2fdb6921 remove empty lines at end of file 2019-10-24 19:35:55 +02:00
Leon Botros
cbbc9cd18f fix namespacing for mamabear, papabear 2019-10-24 19:35:55 +02:00
Leon Botros
03b4153941 remove empty line, add version 2019-10-24 19:35:55 +02:00
Leon Botros
a7850eab51 add duplicate consistency checks 2019-10-24 19:35:55 +02:00
Leon Botros
c53d332090 add ThreeBears 2019-10-24 19:35:55 +02:00
mergify[bot]
edf3774628
Merge pull request #245 from PQClean/arm64_on_hw
Run ARM64 tests on REAL HARDWARE 🎉
2019-10-23 20:09:44 +00:00
Thom Wiggers
23f761efb5 Run ARM64 tests on REAL HARDWARE 🎉 2019-10-23 08:01:02 +02:00
Matthias J. Kannwischer
42c2525efb remove ternary operator in rainbow to compute max
clang-tidy9.0.0 added a new check: bugprone-branch-clone
(https://releases.llvm.org/9.0.0/tools/clang/tools/extra/docs/ReleaseNotes.html)
This doesn't like both branches of an if are the same.
This lead to a warning in rainbow, as where the maximum of two values (which
are always the same) is computed in a macro.
I don't always agree with this warning, but here I think it's worth to
remove the macro.
2019-10-23 08:00:26 +02:00
Matthias J. Kannwischer
762706f5fe remove unnecessary if in kyber768
clang-tidy9.0.0 added a new check: bugprone-branch-clone
(https://releases.llvm.org/9.0.0/tools/clang/tools/extra/docs/ReleaseNotes.html)
This doesn't like both branches of an if are the same.
In this case I don't think there is any reason to do this, so I've removed it.
2019-10-23 08:00:26 +02:00
Matthias J. Kannwischer
138e06fec7 ignore new clang warning security.insecureAPI.DeprecatedOrUnsafeBufferHandling
clang9.0.0 (https://releases.llvm.org/9.0.0/tools/clang/docs/ReleaseNotes.html)
adds a new satic analyzer: security.insecureAPI.DeprecatedOrUnsafeBufferHandling
which throws warnings if you use "unsafe" buffer handling functions which
includes memset and memcpy.
We have memset and mempy all over the place, so I think it's best to ignore this warning.
All the occurences that I looked at seemed perfectly "safe" to me.
2019-10-23 08:00:26 +02:00
Matthias J. Kannwischer
e6ec07bcf9
Switch to gcc9.2 and xcode11.2 for MacOS builds (#246) 2019-10-23 07:59:59 +02:00
Thom Wiggers
54d6301eea
Merge pull request #243 from PQClean/fix-upload-test-results
Make sure the emulated jobs upload their test results properly
2019-10-21 14:30:34 +02:00
Sebastian
56a0fcb135 qTESLA (#239)
* Copied qTESLA-p-I round2 (2019-08-19) code

* Code compiles, NIST-KAT works

* Included detached signature API

* Generated testvectors

* Fixed name in api.h

* code style

* Fixed error in Makefile

* Passing pytest

* Fixing types (uint8_t bytes and size_t indices)

* Replaced SHAKE with SHAKE128 where necessary

* Fixed bug: (signed) integer overflow

* Added qTESLA-p-III

* Code is now independent of machine endianness

* repaired Microsoft makefile
2019-10-21 14:26:27 +02:00
Thom Wiggers
f792b925b4 Enable optimizers on Windows (#244) 2019-10-21 14:23:59 +02:00
Thom Wiggers
02917216f1
Make sure the emulated jobs upload their test results properly 2019-10-17 09:37:14 +02:00
Sebastian
298dd2cf22 fix clang-tidy complaint about falcon (#242)
See https://circleci.com/gh/PQClean/PQClean/7991
2019-10-16 08:23:33 +02:00
mergify[bot]
abe2a5aa2c
Merge pull request #241 from PQClean/fix_kyber90s
Fix kyber-90s warning if size_t is not 32 bits
2019-10-15 18:16:00 +00:00
Matthias J. Kannwischer
df8cc49670 fix kyber-90s warning if size_t is not 32 bits 2019-10-15 15:20:57 +02:00
mergify[bot]
c39e85dddf
Merge pull request #238 from PQClean/kyber90s-aes
Update Kyber-90s to use aes256_ecb instead of local AES implementation
2019-10-04 12:48:58 +00:00
Matthias J. Kannwischer
39246b808d fix for big-endian 2019-10-04 13:10:29 +02:00
Matthias J. Kannwischer
9571a3b017 use common aes256_ecb instead of providing local AES implementation 2019-10-04 09:31:16 +02:00
Thom Wiggers
07543ba929 Document security issues (#236)
It seems wise to include _some_ form of guidance on what we know about
problems with certain (versions of) implementations.

[ci skip]
2019-09-25 10:47:49 +02:00
mergify[bot]
dd11ffc241
Merge pull request #230 from PQClean/fix_rainbow
Fix and re-add Rainbow
2019-09-24 20:44:43 +00:00
Matthias J. Kannwischer
1e04996465 re-add duplicate consistency checks 2019-09-24 14:43:23 +02:00
Matthias J. Kannwischer
db7200dc54 fix algorithm names in META.yml 2019-09-24 14:38:18 +02:00
Matthias J. Kannwischer
f08f65c8b6 remove unsupported -Wcast-align=strict 2019-09-24 13:50:38 +02:00
Matthias J. Kannwischer
3a4673bfd6 refactor gf16+gf256 arithmetic of rainbow to fix undefined behaviour 2019-09-24 13:48:51 +02:00
Matthias J. Kannwischer
0523cd693b fix and re-add rainbow 2019-09-24 13:48:51 +02:00
mergify[bot]
546c8cd173
Merge pull request #226 from PQClean/kyber-90s
Add 90s variants of Kyber
2019-09-24 10:17:16 +00:00
Thom Wiggers
ac1f8cc74d
fixup! Add Kyber90s
Fix CRYPTO_ALGNAME
2019-09-24 08:01:54 +02:00
Thom Wiggers
7931383443
fixup! Add Kyber90s
Add duplicate consistency files
2019-09-24 08:01:54 +02:00
Thom Wiggers
526a841886
Add Kyber90s 2019-09-24 08:01:54 +02:00
Thom Wiggers
588dcaf5cb
Merge pull request #235 from pornin/master
Fixed sampler bug (update to new upstream Falcon code 2019-09-18).
2019-09-24 07:58:39 +02:00
Thomas Pornin
db2a8214f7 Merge remote-tracking branch 'upstream/master' 2019-09-23 11:22:40 -04:00
Thom Wiggers
993803e02d Ignore pointless clang-tidy warning. (#237)
* Ignore pointless clang-tidy warning.

It wants you to write type suffixes for integers using uppercase. Let's
just disable this warning.

https://clang.llvm.org/extra/clang-tidy/checks/readability-uppercase-literal-suffix.html

* Clean up bugprone-narrowing-conversion
2019-09-23 17:16:58 +02:00
Thomas Pornin
2515f13378 Updated version number, and added an explicit cast to appease some versions of clang-tidy. 2019-09-20 09:01:32 -04:00
Thom Wiggers
bdb42f1911 Allow to automatically merge PRs if approved and CI agrees (#234) 2019-09-20 10:39:42 +02:00