Commit Graph

846 Commits

Author SHA1 Message Date
Thom Wiggers
b263cd07d7
Speed up circleci tests 2020-03-31 14:03:02 +02:00
Douglas Stebila
ce4bd09860 Use the right AES CTX 2020-03-26 21:11:07 -04:00
Douglas Stebila
dc401c40d7 Don't return void 2020-03-26 20:18:02 -04:00
Douglas Stebila
585a001fda Split aes*_keyexp up into ecb and ctr variants 2020-03-26 20:18:02 -04:00
mergify[bot]
bfbf99eb76
Merge pull request #280 from PQClean/ds-falcon-type-punning
Avoid type-punning warning in Falcon when strict-aliasing turned on
2020-03-14 20:23:46 +00:00
mergify[bot]
57265306de
Merge branch 'master' into ds-falcon-type-punning 2020-03-14 09:51:06 +00:00
mergify[bot]
36283693d2
Merge pull request #270 from PQClean/fix_newhope
Fix NewHope CCA verify function
2020-03-14 04:52:05 +00:00
Douglas Stebila
b50dbbf544 Trigger build 2020-03-13 17:06:45 -04:00
Douglas Stebila
20aa6ea3dc Change formatting
[skip ci]
2020-03-13 17:05:29 -04:00
Douglas Stebila
d0d53ab52a Avoid type-punning error when strict-aliasing turned on 2020-03-13 17:00:32 -04:00
mergify[bot]
dfb12bb3e3
Merge branch 'master' into fix_newhope 2020-03-13 20:16:35 +00:00
Thom Wiggers
d7b739af13
Clean up README and CONTRIBUTING (#273)
* Clean up the docs a bit

* Document that qemu-user-static needs Linux
2020-03-13 16:15:12 -04:00
Matthias J. Kannwischer
85c6605bbf
fix MSVS warning 2020-03-09 15:45:20 -04:00
Matthias J. Kannwischer
de5cda4d7b
Fix NewHope verify
https://github.com/mupq/pqm4/issues/132 repoorted that the NewHope verify function does not actually return 0 or 1, but 0 or -1, which consequenctly breaks the cmov in the FO transform.
This bug was introduced when I integrated this into PQClean.
2020-03-09 15:45:19 -04:00
mergify[bot]
9023fef558
Merge pull request #275 from PQClean/fix-remaining-leaks
Fix remaining memory leaks
2020-03-04 03:11:09 +00:00
Thom Wiggers
8c2f5994b9
Fix duplicate consistency 2020-03-03 10:15:57 -05:00
Thom Wiggers
2b267defdb
Enable leak check in Valgrind 2020-03-03 10:15:56 -05:00
Thom Wiggers
fe4e12308b
Fix memory leaks in LEDAkem 2020-03-03 10:15:56 -05:00
Thom Wiggers
81caa58b57
Fix memory leaks in NewHope 2020-03-03 10:15:56 -05:00
Thom Wiggers
9a4e9da47e
Fix FIPS202 API memory leaks in Dilithium 2020-03-03 10:15:56 -05:00
Thom Wiggers
0564c906f7
Force running brew update
This will add ~5m to the build time, but Travis CI SUCK at keeping their tools up to date...
2020-03-03 10:07:38 -05:00
Thom Wiggers
9b41a86f8e
Update Travis CI to XCode 11.3 2020-03-03 10:06:21 -05:00
Thom Wiggers
07f96fa057
Merge pull request #274 from PQClean/fix_detecting_changes
Fix detecting of to-be-tested changes on Windows
2020-02-19 15:05:35 -05:00
Thom Wiggers
acf7760f4d
Fix detecting of to-be-tested changes on Windows 2020-02-19 11:53:14 -05:00
Thom Wiggers
f13961dbfc
Merge pull request #272 from PQClean/kyber-fix-leak
Fix memory leak in Kyber
2020-02-17 11:02:07 +01:00
Douglas Stebila
b4de294f68 Fix memory leak in Kyber 2020-02-16 14:55:19 -05:00
Thom Wiggers
bbad7871d2
Fix SHAKE256 memory leak in Dilithium (#271) 2020-02-16 10:18:05 -05:00
mergify[bot]
6de728361e
Merge pull request #265 from PQClean/functest_keys_on_heap
Move keys in crypto_sign/functest.c to the heap
2020-02-12 11:53:29 +00:00
mergify[bot]
b2bdf88091
Merge branch 'master' into functest_keys_on_heap 2020-02-12 01:36:23 +00:00
Thom Wiggers
1a4739e2bf
Move keys to heap for KEMs as well 2020-02-11 12:23:06 +01:00
Thom Wiggers
65a6a63e08
Put all common primitives on the heap (#266)
* Put AES ctx on the heap

This forces people to use the ``ctx_release`` functions, because otherwise there will be leaks

* Put fips202 on the heap

* Add much more docs for fips202.h

* fixup! Put fips202 on the heap

* Put SHA2 on the heap-supporting API

* Fix clang-tidy warnings

* Fix unreachable free() in falcon

* Fix McEliece8192128f-sse GNU Makefile
2020-02-11 11:15:14 +01:00
Thom Wiggers
8a6f612605
Merge pull request #268 from PQClean/fix-mceliece8192128f-sse-makefile
Fix McEliece8192128f makefile
2020-02-11 09:18:25 +01:00
Thom Wiggers
7862f7faae
Fix McEliece8192128f makefile 2020-02-11 09:17:55 +01:00
Thom Wiggers
53d50fd751
Fix alignment problems with vectors in McEliece AVX2 and fix McEliece 8192128f (#267)
* Fix alignment problems with vectors

* Fix required CPU flags for McEliece

* Fix McElice8192128f that was missed in #259

* fixup! Fix McElice8192128f that was missed in #259

* Fix initialization
2020-02-07 11:13:59 +01:00
Thom Wiggers
b3f9d4f8d6
Classic McEliece (#259)
* Add McEliece reference implementations

* Add Vec implementations of McEliece

* Add sse implementations

* Add AVX2 implementations

* Get rid of stuff not supported by Mac ABI

* restrict to two cores

* Ditch .data files

* Remove .hidden from all .S files

* speed up duplicate consistency tests by batching

* make cpuinfo more robust

* Hope to stabilize macos cpuinfo without ccache

* Revert "Hope to stabilize macos cpuinfo without ccache"

This reverts commit 6129c3cabe1abbc8b956bc87e902a698e32bf322.

* Just hardcode what's available at travis

* Fixed-size types in api.h

* namespace all header files in mceliece

* Ditch operations.h

* Get rid of static inline functions

* fixup! Ditch operations.h
2020-02-05 13:09:56 +01:00
Thom Wiggers
8ffb087545
Move keys in crypto_sign/functest.c to the heap
Having the keys on the stack increases the stack space consumption by
quite a bit, and this in turn results in the sanitizer tests failing
for Rainbow.

Moving the keys to the heap in the test seems like a harmless change.
2020-02-05 12:38:08 +01:00
mergify[bot]
7729c76b3e
Merge pull request #263 from PQClean/fix-clang-builds-to-use-clang
Fix clang builds to actually use clang
2020-01-23 03:11:50 +00:00
mergify[bot]
e45513adf9
Merge branch 'master' into fix-clang-builds-to-use-clang 2020-01-22 15:38:18 +00:00
Thom Wiggers
dcad0bd878 Also run duplicate consistency checks on windows (#261) 2020-01-22 10:05:20 -05:00
Thom Wiggers
e380ddcf22
Fix clang builds to actually use clang 2020-01-22 10:36:36 +01:00
Thom Wiggers
8eca85fcd2
Merge pull request #262 from PQClean/threebears
Add ephemeral versions of ThreeBears (Duplicate of #260)
2020-01-17 11:06:09 +01:00
Leon Botros
f9d192036e
Add ephemeral versions of ThreeBears 2020-01-15 10:43:50 +01:00
mergify[bot]
96fb401fb3
Merge pull request #256 from PQClean/redo-dilithium
Redo Dilithium/clean and add Dilithium's AVX2 implementations
2019-12-13 14:50:50 +00:00
mergify[bot]
7483647ddf
Merge branch 'master' into redo-dilithium 2019-12-13 09:35:58 +00:00
Thom Wiggers
a655ec8a9d SPHINCS+ optimized implementations (#253)
* Add state destroy to SHA2 API

* Include optimized SPHINCS+ implementations

I've generated new implementations from the sphincsplus repository.

* Don't destroy sha256ctx after finalize

* Attempt to shut up MSVC

* Make sure to drop errors in rmtree
2019-12-12 14:29:29 +01:00
Thom Wiggers
6d13a3dffc
Specify arrays with sizes again 2019-12-12 14:11:12 +01:00
Thom Wiggers
3943dde3f1
Matthias' feedback 2019-12-12 13:51:46 +01:00
Thom Wiggers
cc07873937 Update PR template along practice (#254)
* remove automatically checked property

* Allow PR-submitters to self-document.

We don't ever use these, so allow submitters of PRs to self-document.
2019-12-12 13:38:34 +01:00
Thom Wiggers
770a421c16 Fix isolation in test_metadata_sizes (#258) 2019-12-12 11:36:34 +01:00
Thom Wiggers
5f0ddcad78 Add ccache to speed up builds (#257)
* Add ccache to speed up builds

* Fix circleci config

* fixup! Fix circleci config

* Try again with environment variables

* Set up ccache on MacOS
2019-12-12 11:35:19 +01:00