pqc/.github/pull_request_template.md
2019-04-09 11:17:54 +02:00

867 B

Manually checked properties

  • #if/#ifdefs only for header encapsulation
  • api.h does not include other files
  • No stringification macros
  • Output-parameter pointers in functions are on the left
  • Negative return values on failure of API functions (within restrictions of FO transform).
  • const arguments are labeled as const
  • variable declarations at the beginning (except in for (size_t i=...)
  • Optional:
    • All integer types are of fixed size, using stdint.h types (including uint8_t instead of unsigned char)
    • Integers used for indexing are of size size_t