1
1
mirror of https://github.com/henrydcase/pqc.git synced 2024-11-22 23:48:58 +00:00

Pull request template draft

[ci skip]
This commit is contained in:
Thom Wiggers 2019-02-27 14:55:06 +01:00 committed by Thom Wiggers
parent 67ba4b661c
commit 1938f78bf1

17
.github/pull_request_template.md vendored Normal file
View File

@ -0,0 +1,17 @@
<!-- This template will help you get your code into PQClean. -->
<!-- Type some lines about your submission -->
## Manually checked properties
<!-- These checkboxes serve for the maintainers of PQClean to verify your submission. Please do not check them yourself. -->
* [ ] `#ifdef`s only for header encapsulation
* [ ] `api.h` does not include other files
* [ ] No stringification macros
* [ ] Output-parameter pointers in functions are on the left
* [ ] Negative return values on failure of API functions (within restrictions of FO transform).
* [ ] `const` arguments are labeled as `const`
* [ ] (optional) All integer types are of fixed size, using `stdint.h` types (including `uint8_t` instead of `unsigned char`)
* [ ] Integers used for indexing are of size `size_t`
* [ ] variable declarations at the beginning (except in `for (size_t i=...`)