1
1
mirror of https://github.com/henrydcase/pqc.git synced 2024-11-26 17:31:38 +00:00
pqcrypto/.github/pull_request_template.md
Thom Wiggers cc07873937 Update PR template along practice (#254)
* remove automatically checked property

* Allow PR-submitters to self-document.

We don't ever use these, so allow submitters of PRs to self-document.
2019-12-12 13:38:34 +01:00

688 B

Manually checked properties

  • No stringification macros
  • Output-parameter pointers in functions are on the left
  • Negative return values on failure of API functions (within restrictions of FO transform).
  • variable declarations at the beginning (except in for (size_t i=...)
  • Optional:
    • All integer types are of fixed size, using stdint.h types (including uint8_t instead of unsigned char)
    • Integers used for indexing are of size size_t